Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220322221517.2510440-1-eranian@google.com> <20220324145902.GG8939@worktop.programming.kicks-ass.net>
 <CABPqkBTVFNOW0Y-suYVRjf07aBC41gEw1m4Ym78sR39BRzLDcQ@mail.gmail.com>
 <20220325082855.GL8939@worktop.programming.kicks-ass.net> <CABPqkBSNG=kLae6dN9iCuyuMVAvt-n+waW9SL4AfNDCOc3px0A@mail.gmail.com>
In-Reply-To: <CABPqkBSNG=kLae6dN9iCuyuMVAvt-n+waW9SL4AfNDCOc3px0A@mail.gmail.com>
From:   Stephane Eranian <eranian@google.com>
Date:   Tue, 29 Mar 2022 16:47:52 -0700
Message-ID: <CABPqkBQ6ZyqSzQyJeNW5GE22V1sygB3zz5JQ45AT1TxMnwWScg@mail.gmail.com>
Subject: Re: [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, kim.phillips@amd.com,
        acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com,
        rafael@kernel.org, ravi.bangoria@amd.com, Sandipan.Das@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 29, 2022 at 2:58 PM Stephane Eranian <eranian@google.com> wrote:
>
> On Fri, Mar 25, 2022 at 1:29 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Thu, Mar 24, 2022 at 10:31:38PM -0700, Stephane Eranian wrote:
> > > On Thu, Mar 24, 2022 at 7:59 AM Peter Zijlstra <peterz@infradead.org> wrote:
> > > >
> > > > On Tue, Mar 22, 2022 at 03:15:04PM -0700, Stephane Eranian wrote:
> > > > > V7 makes the following changes:
> > > > >    - rebased to 5.17-rc8
> > > > >    - Restrict BRS to be used only with RETIRED_TAKEN_BRANCH event in order to
> > > > >      avoid adding more skid to other events in case that are monitored
> > > > >      concurrently
> > > > >    - fixed bugs in the perf tool enhanced error handling for IBS and BRS
> > > >
> > > > But afaict you failed to pick up the build fixes I did in my tree :/ Let
> > > > me try and be careful preserving those while munging this in.
> > >
> > > Sorry. I missed that. I can resubmit if you prefer.
> >
> > Nah, fixed it up again.. Even converted to static_call() this time.
> >
> > Could you please test this branch?
>
> Started testing. BRS does not come up so far. Let me debug this.
>
False alarm. I had not forced the config option. With the config
option enabled, it works as expected.
I just found a minor issue in case BRS is not enabled. To be
consistent, we should do:

--- a/arch/x86/events/perf_event.h
+++ b/arch/x86/events/perf_event.h
@@ -1265,7 +1265,7 @@ static inline s64 amd_brs_adjust_period(s64 period)
 #else
 static inline int amd_brs_init(void)
 {
-       return 0;
+       return -EOPNOTSUPP;
 }

Thanks.

> >
> >   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=perf/amd
> >
> > I've since done more Changelog edits, and I should do a comment with the
> > static_call_mod() usage, but I think this ought to work.
> >
> > At least it now actually builds...