Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Kevin Groeneveld <kgroeneveld@lenbrook.com>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: sr: fix typo in CDROM(CLOSETRAY|EJECT) handling
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v8vwun30.fsf@ca-mkp.ca.oracle.com>
References: <20220323002242.21157-1-kgroeneveld@lenbrook.com>
Date:   Tue, 29 Mar 2022 23:38:21 -0400
In-Reply-To: <20220323002242.21157-1-kgroeneveld@lenbrook.com> (Kevin
        Groeneveld's message of "Tue, 22 Mar 2022 20:22:42 -0400")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Hrgp7Oeir9naFYz2UWNaPCd+tMuGIYF96O2TuMQyRZ+QKDi74EhhT/K090e7?=
 =?us-ascii?Q?ShPHYOcgUtjrlVoh9BzMxzH0IeJKcNY7b57GcLToWnAfH006b59hZ8nLW3gw?=
 =?us-ascii?Q?1VzQUV1gMKYwZRyiNbSbFC/G5UQhRPFC9lAiV6sUJUwWwmSdKcxNQqRRG9yr?=
 =?us-ascii?Q?fAPDzD9dhbKdwFzQDN71CeDV3PB4ycnA5gJarPfDVImqSJpl3icxNhWs6c2n?=
 =?us-ascii?Q?ltQThg8c2rHottkmtFzoflCNn2KuxWIOWHhUtJQWJDv6EJ6xHMSH8KkQCE1G?=
 =?us-ascii?Q?rI3NJWwJfOBU0RaFwpzjZstUk6H62pRVBOGYycC5KXo4SLDuM97ak8FTbUR/?=
 =?us-ascii?Q?9Ej1ZS5/eZPZR54l4OZrNwdCh1d0pVclYzSUPDJ+x1pfQW5Umx4qlKDun+vN?=
 =?us-ascii?Q?5VVkW5F1HVuUeXCmzEWLXrmcHx1nRj3YS1+IQvqXyTQk2Fgz7yax0BEA+FUR?=
 =?us-ascii?Q?F3mIYBaMyjRMFOGI9XEsxXuPVTrb6anXd/eRPBh1Z6jG2KPrLVUz2w1vidnb?=
 =?us-ascii?Q?x/9or2U1YaSwhfrdenv14upLS3l2jM7rQ9FH77ozWHfQ2eWZ3CVj1rBY7eL5?=
 =?us-ascii?Q?xCmvZjGJ9ALb9mmK6FgLKTEosx/i0IDZTxnZwmVfGH/dIfDjZbBshfJWgeEZ?=
 =?us-ascii?Q?LI2KjILhb5vthnTFlMJguPiwmQ4NkkYf3L7WU6y/Qjj9XKaibwN4D5W6DWhL?=
 =?us-ascii?Q?AZ4EJ7pipx78267oRG01oTQIsFF62cnyt3WxnfZI8kCPuYY+AASbU2w8cKMA?=
 =?us-ascii?Q?J7R6erwtSXO8X2dfQGVgjunRCBNDLM/DyiW11DNVtpWy+uoZPbKTheFBCSyA?=
 =?us-ascii?Q?/Zqzjxs4C487dlVFHskkMg7Taw9WpoeRRln4bOY9D5KWImVPQYcQ6XeB+LWS?=
 =?us-ascii?Q?ibzna92MOUmEB3nXKRFJmNqlVNCjSoX/eIQiqSz9nyIC5Hmz/LiAQL1K9RSM?=
 =?us-ascii?Q?oSsuPJhsGR/yQCS577NXXnCk95kV7JCp4MyJhKizAtIWlKcFIDjt7niDaIOd?=
 =?us-ascii?Q?XvEzkORbAHQIH+VAsvfNh/IbQzh6BZWndTaPDHJew9ZLYeajk+RvI+g9lu5U?=
 =?us-ascii?Q?MTSun7smB/TqVg6jOum2cPLh+c4ikO+ABez3kNPX1G+jCnra6YDtKuBjfPey?=
 =?us-ascii?Q?Sc3KB6w0Yvey2w9YvO8Gk4sfNk+t34khreuC4cnGMVC+d7ao1HPBrOyFvQc5?=
 =?us-ascii?Q?mlWoXdZSopNEC9a05fs3Noi3y+VhKJ6IJz5dO0z4AOo0TxWGcCRkLDMbeTYl?=
 =?us-ascii?Q?6Li4+vLKxXbxz44QLRsPjMkAHGmzb761xgPoh+Hu+8OTqGm0MB6vrOqclnuo?=
 =?us-ascii?Q?pLYrtauL336s/HghnTKG/Esogy1p0Squb5eV4xvufzb9swluLdYhI1kfe9HT?=
 =?us-ascii?Q?0yCHIrbc6taJxXHohhqTvLfA8wl3vGVmqtSmiy8VXWZyX8gjYSoiDOk7j6Z0?=
 =?us-ascii?Q?2P/fjGpAbvz3bAXuCBv+JX+gbItJz8ciYZ2rd7npiiaUS0h6rJqhR75vW3Ns?=
 =?us-ascii?Q?f2gjS9IvyYDKL0ggSB6tY7OxkcbOX1jh0YYf1Dt/+duDp1stxxRf7JSn3uHO?=
 =?us-ascii?Q?XIaKVB4zyC4uIPqJ2sfZrvBwho9hIitNtdrU02yRiB4iWCmsWTu+z8nWV1gR?=
 =?us-ascii?Q?uvV8MAbpE5EdTIUiGi5/5bMRLVUywhS6k/sF9i/S0PF+oeSVR4lmJ5iw+dEx?=
 =?us-ascii?Q?DEGzX0oM1OTqyU67FbqbqXfKTq/huiYQpgCh29SDOwMuyCIiNn3qHkM0GpHO?=
 =?us-ascii?Q?0vLE8jz1MYQs9zRNoO9duTNdn0shVis=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20c00d77-2ea3-4e40-07ab-08da11febe3c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 03:38:23.8567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7PeiwchN7Hv+zSHOQRkxedzEGdQjZlpu5dy9EpdP/BINEMiFPTBiByzraKFe6uyAHx2Qd9l2LuGU73deNMrtE3ndW6LbQ+159necOLHWIvs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2767
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10301 signatures=695566
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=823 spamscore=0
 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203300015
X-Proofpoint-GUID: Nq-SDBY5X1SZDZp4Hj5_02lUatyzzVCy
X-Proofpoint-ORIG-GUID: Nq-SDBY5X1SZDZp4Hj5_02lUatyzzVCy
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Kevin,

> Commit 2e27f576abc6 ("scsi: scsi_ioctl: Call scsi_cmd_ioctl() from
> scsi_ioctl()") seems to have a typo as it is checking ret instead of
> cmd in the if statement checking for CDROMCLOSETRAY and CDROMEJECT.
> This changes the behaviour of these ioctls as the cdrom_ioctl handling
> of these is more restrictive than the scsi_ioctl version.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering