Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e47ed54f-dacc-f9c7-0307-a47b38fc675d@redhat.com>
Date:   Tue, 29 Mar 2022 16:32:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 3/4] input/i8042: Add debug output for quirks
Content-Language: en-US
To:     Werner Sembach <wse@tuxedocomputers.com>,
        dmitry.torokhov@gmail.com, tiwai@suse.de, mpdesouza@suse.com,
        arnd@arndb.de, samuel@cavoj.net, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220329142718.30921-2-wse@tuxedocomputers.com>
 <20220329142718.30921-3-wse@tuxedocomputers.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220329142718.30921-3-wse@tuxedocomputers.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 3/29/22 16:27, Werner Sembach wrote:
> Make new quirk table easily debugable with some debug output.
> 
> With no functional change, evaluation of i8042_reset_quirk and
> i8042_reset_never_quirk had to be moved for this.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/input/serio/i8042-x86ia64io.h | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 1d2b34aac0c7..5c0eb5594fb1 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1421,6 +1421,31 @@ static int __init i8042_platform_init(void)
>  
>  	i8042_check_quirks();
>  
> +	pr_debug("Active quirks (empty means none):%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
> +		i8042_nokbd ? " nokbd" : "",
> +		i8042_noaux ? " noaux" : "",
> +		i8042_nomux ? " nomux" : "",
> +		i8042_unlock ? " unlock" : "",
> +		i8042_probe_defer ? "probe_defer" : "",
> +		i8042_reset == I8042_RESET_DEFAULT ?
> +			"" : i8042_reset == I8042_RESET_ALWAYS ?
> +				" reset_always" : " reset_never",
> +		i8042_direct ? " direct" : "",
> +		i8042_dumbkbd ? " dumbkbd" : "",
> +		i8042_noloop ? " noloop" : "",
> +		i8042_notimeout ? " notimeout" : "",
> +		i8042_kbdreset ? " kbdreset" : "",
> +#ifdef CONFIG_X86
> +		i8042_dritek ? " dritek" : "",
> +#else
> +		"",
> +#endif
> +#ifdef CONFIG_PNP
> +		i8042_nopnp ? " nopnp" : "");
> +#else
> +		"");
> +#endif
> +
>  	retval = i8042_pnp_init();
>  	if (retval)
>  		return retval;