Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Mar 2022 12:08:24 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
        Iwona Winiarska <iwona.winiarska@intel.com>,
        openbmc@lists.ozlabs.org,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        linux-kernel@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
        Jason M Bills <jason.m.bills@linux.intel.com>
Subject: Re: [PATCH] peci: PECI should depend on ARCH_ASPEED
Message-ID: <YkM9CPbeARpWHMPw@heinlein>
References: <f7ea35c723da72a89028da5b976ad417fbd7bf52.1648545587.git.geert@linux-m68k.org>
 <YkLgapMN2JqM+Lte@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="z4wolAb7mS9MAQex"
Content-Disposition: inline
In-Reply-To: <YkLgapMN2JqM+Lte@kroah.com>
Precedence: bulk


--z4wolAb7mS9MAQex
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 29, 2022 at 12:33:14PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Mar 29, 2022 at 11:21:37AM +0200, Geert Uytterhoeven wrote:
> > The Platform Environment Control Interface (PECI) is only available on
> > Baseboard Management Controllers (BMC) for Intel processors.  Currently
> > the only supported BMCs are ASpeed BMC SoCs.  Hence add a dependency on
> > ARCH_ASPEED, to prevent asking the user about the PECI subsystem when
> > configuring a kernel without ASpeed SoC support.
> >=20
> > Fixes: 6523d3b2ffa238ac ("peci: Add core infrastructure")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> >  drivers/peci/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/drivers/peci/Kconfig b/drivers/peci/Kconfig
> > index 89872ad833201510..0d3ef8ba0998d649 100644
> > --- a/drivers/peci/Kconfig
> > +++ b/drivers/peci/Kconfig
> > @@ -2,6 +2,7 @@
> > =20
> >  menuconfig PECI
> >  	tristate "PECI support"
> > +	depends on ARCH_ASPEED || COMPILE_TEST
>=20
> I hate ARCH_ dependencies as there is nothing specific with that one
> platform that means that this driver subsystem will only work on that
> one.

The motivation in the commit message isn't even accurate because the chips
under ARCH_NPCM are usually used as a BMC as well and PECI is just as impor=
tant
for them.  HPE also has a custom chip they use as BMC and they've started t=
he
process for upstreaming that support.

> I'm all for fixing build dependancies, but it should be fine to build
> all drivers for all arches.

There are a few drivers, like PECI and FSI, that are likely only useful
when being used in the BMC space.  Is it worth having a "config BMC" for
drivers which are likely only useful in a BMC environment and that we can
"if BMC" around these drivers so they get hidden from the menuconfig for
typical use cases?

--=20
Patrick Williams

--z4wolAb7mS9MAQex
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmJDPQgACgkQqwNHzC0A
wRmUxQ/+PopAViu2crFxUxSdeLGnJt8czmB3zKxtmlaUU06S07tm0FcbGqljwTIK
Nghx8aPmUjbnOIskWOPRM0BLyk0QrNM8OgGfY7+mTuMqhPTh/42XTJ+bKHnENtTP
d5VxxLNrqUkEiLqO130YqgEAiRmlRsZOEIuxHeA9KQdPr9KkSyBez/3WK5FhVVHI
8kJT1Ht6aVNWWflRMrHqRMUyWvqDmCsegHnsDboU29+xlgKwMb4KgtmnzVeSqpyJ
5qJZZ24PbOYPLsOlFHHwcB9IaWrOeNNDyvOwoQBndRq3hsGEL7DMIwtHBUJWbgUm
Z4Tpy7oanwY+uFDdLExhy+HhoxwyEStzW28q1xDPprZzhwjQRPMczRyQ3vXvpRq0
mib9w8xfYF0YFG28sTS394jpRtuVuZf40AJxHubMhjo+F8GNK4doO1GvGZMNnbRY
KuR2xAUL5o+nNhiBxTKVDsG/uZa5ffqcVfOiqoWMW6wCeW1IV/usk0NUP1XCsaUh
3Zx2OujVymFsXfdyPyhPVQdiKstZ0FM9Ef8mqT4Xn73FxsJA0nyubeGj63uENTiG
iOwn6YauefJybKd7LxBHSXSd+b5pBBcYDqph5IxE4qhdzOsmEg8yyJ0KWXtcIj7Y
4AkAPp8U9dWbrVxS6ItFjDQeJyNBHTTVmGQR85eYFnNeyGia5P0=
=89Q3
-----END PGP SIGNATURE-----

--z4wolAb7mS9MAQex--