Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3752c4c3-120f-e520-1cb0-cca7e8adac2d@oracle.com>
Date:   Tue, 29 Mar 2022 17:31:47 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] drm/v3d: Use kvcalloc
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>
Cc:     Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        dan.carpenter@oracle.com, Melissa Wen <mwen@igalia.com>
References: <20220312152656.51625-1-harshit.m.mogalapalli@oracle.com>
 <20220328122536.cobmqclwtl2ca6k4@mail.igalia.com>
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <20220328122536.cobmqclwtl2ca6k4@mail.igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnBNSUNXZWovUlNEL0VFZXQzVGozanROWlhnSjI3V3pOSkRIb3dvTnJKc1lh?=
 =?utf-8?B?bVhmMG5UKzZieFhpemJOaS9wNS8vanJmQ0FGVEpYaGl4RTMvK3FDRWhpQU1Q?=
 =?utf-8?B?YUptVGpDTkVpMHhDRUdBeU1RSFI0N0ovelRxVk1pa1RlcVhxdG1ITE80Mjd4?=
 =?utf-8?B?ODk1SU9DVEJsOVgxN2FIOEhEaEVUQTZrRDRFaEpXbjhzcS9hNXFEMlFvR2Jm?=
 =?utf-8?B?RXFrMVE4SmY3OERxb3dRalFwdmRUVjFoUExsaGMzSVhRRXJxTU5tandMZDZp?=
 =?utf-8?B?Mm9jbWsrMEJidTF4SWxPczV4enJSOXcvZEd6eTJUMHViaFQxMktzMmdUN2kv?=
 =?utf-8?B?djg1eVBOdmMyNXpVam5lSW9IcjZDVlczNUJlblZOT25QeWNVL2NoRTJZSVFY?=
 =?utf-8?B?RXlpc0ZvWXNZdVp4ZUJ1dUU3WXRkVDR4Nm8ybVJQcktnR1p6ZVZvREM1YXNj?=
 =?utf-8?B?WkkvRlRIYUFDQXd0RWZvYjVMN1ZGcFNoOWE0V1VEVVV0SlM2bGVTNGZEZVNM?=
 =?utf-8?B?UnNheFN6QXhabEZ5NzA0SWRsVXBHdEFqL0VsdU5KZkJGYm8zQXY4SG56VElv?=
 =?utf-8?B?b1lzYktmeDJDaWVZQzZiem5mcWNhUnNMNWp0TVJuaUdaL2pHbHUrOEtkKzlw?=
 =?utf-8?B?dzZSSHVnUEo0NE9XMS9qeFEwdkJjVzRZeW9QeVF6bGcyQ1ZKQlJ2RmdHWEdZ?=
 =?utf-8?B?TlVJSTJKaEFOV0lrMlJpUzM4bUZTUlFWZFVwb3QxTmdaUlJFMzZQcEZ5YjVL?=
 =?utf-8?B?RFIzelp6UlpZZ015SVMxMmthUmRMK29scUtzT0pQOE1YL2hXMXZNTkRUVUI4?=
 =?utf-8?B?MllqYXVwRjJxdjRXQUtLZXVEZFQ4V2tUb2FhWXRxNS85S0JkUkpYcGdvMGtO?=
 =?utf-8?B?bE00aC9HL2VkazBvWGZTOHZBL0JleFl1VFpSWlJaVWYxcEdjR0piZ2tVTk8y?=
 =?utf-8?B?ajJWenoyTmJhTVEwTExkSC9SRjZTY3RLaDBlWUMzczBjQjEvdit6cWJzOFNG?=
 =?utf-8?B?Z29QS3ZVQ25nV0w5Uk1BOHNqYVdBU0xvRUFLYjM0ZXZLOGVTUFovRVp4OHhi?=
 =?utf-8?B?T2lldkpuclc0SlZCaXRhUDkra2p0SjFWZmNueXFJa3ExNmV4TW1Yd2VEdERF?=
 =?utf-8?B?aHdaaEc4S3NRU294NHR1dUdTUDZsVVVxTHd4NmVuYjRPVEord1Jad1c5RDZx?=
 =?utf-8?B?amphWllHb0ZWN0M4M1JPNUtKRFNUelV2cU54cUlwVEl4SmlTaytwQS9qeVJY?=
 =?utf-8?B?ZEw2RTBmbk5sOHhDdXJDd2t4dDdtRkFDNzRhSllxRDZndjhtS1dxMHFVVmZs?=
 =?utf-8?B?WkMyUnhlM1J6M251MUY1TWtEdjkvRTlQelJXa2tWMXZiZWJ5YU8vbkV0bEVN?=
 =?utf-8?B?UGI5TitYQVVGNnlsZlczbDRPUjRXRmk3MDFBM3pZajV5NnV2a0hTMFRpMlRj?=
 =?utf-8?B?KzgrZ0J4OVdRL0d1dzVmajNZemJTUlJMcjFiZkh5VjZ3em1lcWhDWHcrcG9i?=
 =?utf-8?B?bGV3QWpHNjNnek5QMHkwRnA5Sm5UUmFnYnU0dXhsRUxxR3Z1TDZBN0FFSm9t?=
 =?utf-8?B?U3FGSUtLQURPdUsyQUtGK05CNzh5K2RLYzJaVnVuaTdCazRkbWh4ZDEyWHBM?=
 =?utf-8?B?TEI4Qmh4WUN3R1R4emJ5cDA0UzRjU1hOTEdCUE5rVjQyVVhJT0FHbjdCRGlX?=
 =?utf-8?B?SGFpaXFZcy82azIzSHZMZGNrSlRzcVk3VlVYYWFQUkluVFN6WFRtd2JPNXhC?=
 =?utf-8?B?UThnYklxN1RKZG9aMitTQnNlUjZwR0wvMkIwWHlwbG8yLzl5aXVwVDJEcEpC?=
 =?utf-8?B?N2RLNytvNCsrOHJnV3d4UTFyRkhzWFdGbFRBRUlXOUNaMlUwelVNVGdHUXlF?=
 =?utf-8?B?cU9YRzF6SThHYU5temhubmE5d3NrMUtHYjUzQXZIMlNrUGkwTjQxUUJJZk5z?=
 =?utf-8?B?cCsxdDE1TmhHM3g5NWYyTVNHaEhDUDE0Ti9xNG9OSnBMb2ROeEtqUHZtdUVl?=
 =?utf-8?B?eDJVOUZNQnZEWkg0QU1zd1hJazZiYW4xWW9lMk5Rb2hkTS8wVFBZQlBSQTFn?=
 =?utf-8?B?bmJ6bjkvZUhIK3I1ekFMQkFZRWpiZGIrNVJ4a1pUTmJaQ2tkTUs5b282UHE2?=
 =?utf-8?B?VmcycThuaEtWZnF4bWYrOG4rQlVNUTRCdnprMTNQUFg1cEowRk1ic1ErWXA0?=
 =?utf-8?B?N1F5Q1E2T0E1NXlRWXRRRmVNRXlSWlVZUTg1R3NSMWhkREJRY2NMbFlYWW5y?=
 =?utf-8?B?anZjd2lxUnFQVHF5bG1KL2x2YkpRMldmOXNFMVBPM1hUSktuZ1B4STR4Zko2?=
 =?utf-8?B?QTMrQkhCMU1UdHh6aWlXNW1JL21iWDB5RUJLb3MycGU0bW56dUFjb1ViZC9a?=
 =?utf-8?Q?OmC44tzueidOK78+hbhAEtyyZ3+mpeu8eYLT4?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6883885f-2ad0-4d6c-7b7e-08da117bf11f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4191.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2022 12:02:05.2867
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qByGj+uy1O8Os9aAVBlnICzbMI7Ali6FGtmc4omyEaqZjxn2KIGnYApZeCFKYnNkl3lTGWnHcI67OSGK30+UPv7xdnSR2GdX8olAv7cPB1c4EI4W1oifqPQxlLVXKgJj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3290
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10300 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0
 adultscore=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203290073
X-Proofpoint-GUID: vOOYQCulSxC3zrP5vjIu14imTEWihdZG
X-Proofpoint-ORIG-GUID: vOOYQCulSxC3zrP5vjIu14imTEWihdZG
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/03/22 5:55 pm, Melissa Wen wrote:
> On 03/12, Harshit Mogalapalli wrote:
>> kvcalloc is same as kvmalloc_array + __GFP_ZERO.
>>
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>> ---
>>   drivers/gpu/drm/v3d/v3d_gem.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
>> index c7ed2e1cbab6..f7d37228461e 100644
>> --- a/drivers/gpu/drm/v3d/v3d_gem.c
>> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
>> @@ -308,9 +308,8 @@ v3d_lookup_bos(struct drm_device *dev,
>>   		return -EINVAL;
>>   	}
>>   
>> -	job->bo = kvmalloc_array(job->bo_count,
>> -				 sizeof(struct drm_gem_cma_object *),
>> -				 GFP_KERNEL | __GFP_ZERO);
>> +	job->bo = kvcalloc(job->bo_count, sizeof(struct drm_gem_cma_object *),
>> +			   GFP_KERNEL);
> 
> Hi Harshit,
> Hi Melissa,

> This change seems valid to me, but I believe, in this point, v3d should
> move to use the DRM function `drm_gem_objects_lookup()`, and then your
> change goes there, since drm_get_objects_lookup() has the same issue
> you're pointing. What do you think?
> 
Thanks for looking at the patch.

Yes, you are right, the issue is same there as well.

Few other similar instances in drm/ subsystem.

drivers/gpu/drm/drm_gem.c:700 drm_gem_objects_lookup() warn: Please 
consider using kvcalloc instead
drivers/gpu/drm/ttm/ttm_tt.c:99 ttm_tt_alloc_page_directory() warn: 
Please consider using kvcalloc instead
drivers/gpu/drm/ttm/ttm_tt.c:108 ttm_dma_tt_alloc_page_directory() warn: 
Please consider using kvcalloc instead
drivers/gpu/drm/ttm/ttm_tt.c:121 ttm_sg_tt_alloc_page_directory() warn: 
Please consider using kvcalloc instead
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:541 amdgpu_cs_parser_bos() warn: 
Please consider using kvcalloc instead
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:152 
svm_range_dma_map_dev() warn: Please consider using kvcalloc instead
drivers/gpu/drm/v3d/v3d_gem.c:311 v3d_lookup_bos() warn: Please consider 
using kvcalloc instead
drivers/gpu/drm/vc4/vc4_gem.c:746 vc4_cl_lookup_bos() warn: Please 
consider using kvcalloc instead
drivers/gpu/drm/lima/lima_gem.c:42 lima_heap_alloc() warn: Please 
consider using kvcalloc instead
drivers/gpu/drm/panfrost/panfrost_drv.c:147 panfrost_lookup_bos() warn: 
Please consider using kvcalloc instead
drivers/gpu/drm/panfrost/panfrost_mmu.c:452 
panfrost_mmu_map_fault_addr() warn: Please consider using kvcalloc instead
drivers/gpu/drm/panfrost/panfrost_mmu.c:460 
panfrost_mmu_map_fault_addr() warn: Please consider using kvcalloc instead

Tool Used: Smatch.

> I already sent a patchset to replace steps in v3d_lookup_bos() by
> drm_gem_objects_lookup(), as I mentioned. The patchset is here:
> https://patchwork.freedesktop.org/series/101610/
> Willing to review it? ^
> 

Sorry Melissa, I am still a beginner, Can't review it.

Regards,
Harshit

> Thanks,
> 
> Melissa
> 
>>   	if (!job->bo) {
>>   		DRM_DEBUG("Failed to allocate validated BO pointers\n");
>>   		return -ENOMEM;
>> -- 
>> 2.31.1
>>