Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a2728619ef71add19d9b87af554fd2fc9bc0b7e0.camel@intel.com>
Subject: Re: [PATCH v2 01/21] x86/virt/tdx: Detect SEAM
From:   Kai Huang <kai.huang@intel.com>
To:     Isaku Yamahata <isaku.yamahata@gmail.com>,
        "Tian, Kevin" <kevin.tian@intel.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Luck, Tony" <tony.luck@intel.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>
Date:   Wed, 30 Mar 2022 12:28:14 +1300
In-Reply-To: <20220329175234.GA1915371@ls.amr.corp.intel.com>
References: <cover.1647167475.git.kai.huang@intel.com>
         <a258224c26b6a08400d9a8678f5d88f749afe51e.1647167475.git.kai.huang@intel.com>
         <BN9PR11MB527657C2AA8B9ACD94C9D5468C189@BN9PR11MB5276.namprd11.prod.outlook.com>
         <51982ec477e43c686c5c64731715fee528750d85.camel@intel.com>
         <BN9PR11MB52765EE37C00F0FFA01447968C1D9@BN9PR11MB5276.namprd11.prod.outlook.com>
         <20220329175234.GA1915371@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-03-29 at 10:52 -0700, Isaku Yamahata wrote:
> On Mon, Mar 28, 2022 at 08:10:47AM +0000,
> "Tian, Kevin" <kevin.tian@intel.com> wrote:
> 
> > > From: Huang, Kai <kai.huang@intel.com>
> > > Sent: Monday, March 28, 2022 11:55 AM
> > > 
> > > SEAMRR and TDX KeyIDs are configured by BIOS and they are static during
> > > machine's runtime.  On the other hand, TDX module can be updated and
> > > reinitialized at runtime (not supported in this series but will be supported in
> > > the future).  Theoretically, even P-SEAMLDR can be updated at runtime
> > > (although
> > > I think unlikely to be supported in Linux).  Therefore I think detecting
> > > SEAMRR
> > > and TDX KeyIDs at boot fits better.
> > 
> > If those info are static it's perfectly fine to detect them until they are
> > required... and following are not solid cases (e.g. just exposing SEAM
> > alone doesn't tell the availability of TDX) but let's also hear the opinions
> > from others.
> 
> One use case is cloud use case.  If TDX module is initialized dynamically at
> runtime, cloud management system wants to know if the physical machine is
> capable of TDX in addition to if TDX module is initialized.  Also how many TDs
> can be run on the machine even when TDX module is not initialized yet.  The
> management system will schedule TDs based on those information.

Thanks Isaku.  I'll keep current way for now.

-- 
Thanks,
-Kai