Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Mar 2022 10:09:58 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Mikhail Zhilkin <csharper2005@gmail.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        NOGUCHI Hiroshi <drvlabo@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Karim <Karimdplay@gmail.com>, M <x1@disroot.org>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: add support for Sercomm partitions
Message-ID: <20220330100958.57dc4d61@xps13>
In-Reply-To: <20220329122016.4122899-1-csharper2005@gmail.com>
References: <20220329122016.4122899-1-csharper2005@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mikhail,

csharper2005@gmail.com wrote on Tue, 29 Mar 2022 12:20:16 +0000:

> This adds an MTD partition parser for the Sercomm partition table that
> is used in some Beeline, Netgear and Sercomm routers.
>=20
> The Sercomm partition map table contains real partition offsets, which
> may differ from device to device depending on the number and location of
> bad blocks on NAND.
>=20
> Device tree example:
> partitions {
> 	compatible =3D "sercomm,sc-partitions", "fixed-partitions";
> 	#address-cells =3D <1>;
> 	#size-cells =3D <1>;
>=20
> 	partition@0 {
> 		label =3D "u-boot";
> 		reg =3D <0x0 0x100000>;
> 		scpart-id =3D <0>;
> 		read-only;
> 	};
> };

You'll need a DT binding patch and Rob's ack!

>=20
> This is essentially the same code as proposed by NOGUCHI Hiroshi
> <drvlabo@gmail.com> here:

I would credit Hiroshi with a Suggested-by at least

> https://github.com/openwrt/openwrt/pull/1318#issuecomment-420607394

And use a Link: tag for this.

>=20
> Signed-off-by: Mikhail Zhilkin <csharper2005@gmail.com>
> ---


Thanks,
Miqu=C3=A8l