Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1524754pxb; Wed, 30 Mar 2022 05:38:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm0gfvH/KWMczFPsVZvsq1uaRNWbb2DP2ISaute9gai6c70Ia6bqiJKwS5l1yKSQGbRxvy X-Received: by 2002:a05:6402:84b:b0:419:85:b724 with SMTP id b11-20020a056402084b00b004190085b724mr10412050edz.413.1648643881396; Wed, 30 Mar 2022 05:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648643881; cv=none; d=google.com; s=arc-20160816; b=lLJEndB1I8AeC6mmI930S1FMkK/GPULLKi5FyaNwJi2ZOqeJ1jqt7knp244sezDgsP hj2fhLxuvR+4gtXXxtsx58d6AscsHLv4G0CsGzDv+1bYlEFZenOCAwgkIRqD+hswa6Cz eYUYFjGZV2flzY+hWCh6ubY1dJaWKVbAlnp4cs2+pQvCKQtTVcpo04PTNgOvJ8+rhVrE 3QIJF3tOcmgfb5O+RtEHwNDmw6+7z9ZmT8m+PGyTuKTMnZfotQZXEcdIBS5tXrV7FxnS UR7W+nftOcyyy0O9YjeOjuGTy7Skf/LlduxJ5XCw1AMqCAG0NA8O6+b2NpOCglCWtqlX DIXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1XSbfxQBYM8jiURN7YjMld2r5EWAezEnXs/mdxCulMk=; b=TbshguALuATvT1QxfQLZIZwadqwu2AllfGFf4POb1oGs2/wDxXUjAEqBDb9hCBin+2 ZN2PfJUUlNHOTq/AeCZaAS6zzyZvUf0tTM0//LrQI5dnWGn4MMkdLZ3888v2prIfBjyu 5lozjdwBbiNriBa99U0qM/wcVQ8F8IGc3R1Tn2ZAdYwq/ICQNvuJiyTrON1yVwSJgTfZ Z0I0kbXlSseMzOTHWiIWlQyRFz/kmxesrHZPF51QgCZMmRaB6AjnHFaG1SgT5fg1tf6W AeT7HPnLFCdyrBilW417eY5KbyZWioAjxn0Tjcoq/eia3AX2EV+HUc0FGuqz1sMO/JKT zTgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XIfGakTw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oz16-20020a170906cd1000b006df76385c62si19699250ejb.258.2022.03.30.05.37.35; Wed, 30 Mar 2022 05:38:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XIfGakTw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239301AbiC3LEt (ORCPT + 99 others); Wed, 30 Mar 2022 07:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245718AbiC3LEn (ORCPT ); Wed, 30 Mar 2022 07:04:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B513C6EFC; Wed, 30 Mar 2022 04:02:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0765A6150E; Wed, 30 Mar 2022 11:02:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED1A4C340EC; Wed, 30 Mar 2022 11:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648638177; bh=QxskefdCnGyYAS0bbSv9f6+Vt1kzl7DgdMfQgK4palk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XIfGakTwWw+ACnf8FdqpXKU3TpxJ6GNX1Th7+CY+vingXZspGIR1VdqDaU3vtT6Vo dmg+7JnU1TrLpkDYXuWexRY5t4pfEYoYySgRf+3IrRH8H0n6gRI4ELTy8ettmGKJw+ Y7AkkOQnF8TpkD+pa/vIhdu9hZhGn7N1SZZ8itHPQc8MSO9fCUzbSkFEBrn/j55gAl tA0uMCjjUQITrk82tFWkTdXhTVogX0EsmQEUPW0S/bo8w04scn5eElR/b3fnUsIr7J 6Iz/veRWW0KbQg6iRYmqqA2YY7l/zM1gOZmuv6mogGE7UfkycV//92Fk98MT4vVu+k oAs64CI4vAUUQ== Date: Wed, 30 Mar 2022 14:02:53 +0300 From: Leon Romanovsky To: Guo Zhengkui Cc: Mustafa Ismail , Shiraz Saleem , Jason Gunthorpe , Yishai Hadas , "open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA" , open list , zhengkui_guo@outlook.com Subject: Re: [PATCH linux-next] RDMA: simplify if-if to if-else Message-ID: References: <20220328130900.8539-1-guozhengkui@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328130900.8539-1-guozhengkui@vivo.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2022 at 09:08:59PM +0800, Guo Zhengkui wrote: > `if (!ret)` can be replaced with `else` for simplification. > > Signed-off-by: Guo Zhengkui > --- > drivers/infiniband/hw/irdma/puda.c | 4 ++-- > drivers/infiniband/hw/mlx4/mcg.c | 3 +-- > 2 files changed, 3 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky