Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Wenchao Hao <haowenchao@huawei.com>
Cc:     Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        Mike Christie <michael.christie@oracle.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        <open-iscsi@googlegroups.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Zhiqiang Liu <liuzhiqiang26@huawei.com>,
        Wu Bo <wubo40@huawei.com>, <linfeilong@huawei.com>
Subject: Re: [PATCH] scsi:libiscsi: remove unnecessary memset in
 iscsi_conn_setup
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq14k3gxhv7.fsf@ca-mkp.ca.oracle.com>
References: <20220317150116.194140-1-haowenchao@huawei.com>
Date:   Tue, 29 Mar 2022 23:02:45 -0400
In-Reply-To: <20220317150116.194140-1-haowenchao@huawei.com> (Wenchao Hao's
        message of "Thu, 17 Mar 2022 11:01:16 -0400")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PvFQAxolNQk66WkBbRvSoG+yDmaA4zvybJSgfWOvrrEK0/lDGJ48FrzVtOJp?=
 =?us-ascii?Q?92Dy8rV/cwTgcKksgqiEqP5XmNhCyRUjRolyvJaiDvL3c22NCUAYpprIonyn?=
 =?us-ascii?Q?Zik750fiIW+jA1pkNOW9xLY+8Y4AAFWrmyOb2OGDLb68bXNikkuCwqPook2f?=
 =?us-ascii?Q?xxSW9fpyH4IrzAOM1/vISuiP0m1ZCQnFl1uf2fojDLuaHeoJKBrNP162OLX5?=
 =?us-ascii?Q?Dld9G8QCS1yhwTD+e9aRK1UVgGXQxUG2WEgSelTT1vs0TTvAuIfeSWtwG+4w?=
 =?us-ascii?Q?+EgtiX0K5xJoyHfhYl12m/w24pVyjImwVeuPVAKe3gK+YZ9TeeTVNCfzrf9K?=
 =?us-ascii?Q?uGKLK5LZzMKLZcT2vsao535JoMqqqZsgnT7eywlghDZv47XKXjJwB6oxl9Yz?=
 =?us-ascii?Q?dLvPJP+4uDWZz0Eh/zDt/t6aDrWgOEG/RYs+ngLCqlXeOvR2+ARidSxln+Rn?=
 =?us-ascii?Q?/u2P3WfsBfEo1GT5eog5ZIGPHKUef8Xv+XUnoJc7N57o/MS4wKrGaU8gidan?=
 =?us-ascii?Q?4Qr23iX2wjYDimCHcdOkIO/e5qcyDEi1a/T6faiUQTzDxlEnOZWhaIPfI4Fq?=
 =?us-ascii?Q?aPO7l8P5mho3KCz0cNUxj7gUKe8IxMwlY98UFhajmyFJBqRuGwYNkOA3JG48?=
 =?us-ascii?Q?6QnzmCqsFtXOQtQ0cd6UESpC0/zJaRS8YK714qeBYLDcvdIw9GBQkC8f/F8B?=
 =?us-ascii?Q?IFD2TWaoNtHl6dFRs68swCGerQ4RcA0b9815PHPvrBr1ov43bOfoJvjNTXKk?=
 =?us-ascii?Q?iSuaNVApIbcJBCmxSZ8srshgonodU+jalFhbplDx7xWGj8Wz4FEtcmTzQM9b?=
 =?us-ascii?Q?s0KHKetQAn3bnJdnppXgcHWqwa9AQt/o6rWL9G0tTL4Spo2DZt1U+DdTTa0J?=
 =?us-ascii?Q?mNI0ob1lwmNW9+6rz3UMaNIqXR29zOXr4SNytNmXp81R83mipKb4V3D5UJQB?=
 =?us-ascii?Q?ddf4xjDAiZErq998gmK7yeepP0c3qacwP6lIdfpXjTIZDOaPTk0l05B41NKl?=
 =?us-ascii?Q?igDbxz79AK0yJwxKTt6FDtc0JOyejQzb5XB2Oy5xDU1ONCe99YYfce2UnUYG?=
 =?us-ascii?Q?f/NyirOzylKVA4yD6gAabF03xKdnurWd9j+wGf0wvEIQlqgcrf7yNVSgQw8y?=
 =?us-ascii?Q?RqEVcU5o48RIE+cAAL/xCA4FFwQbKz4H36sUtpGzbfKRtD9I6yShhF76Qc2b?=
 =?us-ascii?Q?eg+hk6DCrG1rQvz6ZQCLO/bPXAxYCqT0clvjUowp9wAynT2rRpiwZr6zYeA2?=
 =?us-ascii?Q?W+R/GtRLmgvXZYE9XP2/N8CjzB82OBokMmEAZ7Mq5gHR+Ksxfz24k2PNhd0W?=
 =?us-ascii?Q?5q4NArehUgH9o2jk7VSfJPDAjifKRKRYIMnaUaOEBbxMThGoWhKxFkUdKVMW?=
 =?us-ascii?Q?NFlcGFYX9BxXceBvD6bcK3LeoA3xkjUKq5FskaiE9AuYPykTvd+x5QASfUdk?=
 =?us-ascii?Q?3Y3EplIHTZQIF10AaJsgFhmeeowgIC/E/Uds++2T5vfa8C+hnQ0QJ8Ub4IOq?=
 =?us-ascii?Q?E7gxNeCA73ZLVji0yjySAB5OCBwsSc8LB/pkYrSVrzaCEzTV5m2lMWPux/Eb?=
 =?us-ascii?Q?H108yG18kwuGlw6EwL6Yn6KRkx+7tmLghtaAf6D3FTuQ7IRnA7zbNY3Hya1W?=
 =?us-ascii?Q?K8NH4u+7j2H6PU8L128sUaSHQKATKKy6aF2DHLi8gCGcXNwrwHGNp6Y3cZmn?=
 =?us-ascii?Q?HWT+7knJ8bBM1GCAOEnk7TWXijEXQEyQAhSuqNXJ8CieMVV7naJHjCCtbrJU?=
 =?us-ascii?Q?fGbNsDpqMMCIxpQ3ZNxQB1Cz2VdN8/c=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13339cf1-d162-4589-f507-08da11f9c4d0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 03:02:47.5715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9hfSZTWYGn341IxHfwiG2jRHc6r9VYnjY95aP2RfE9ZTcw0//Wwv5fiAOI0mbvNb4l17xF/9I3wbHiNsJMh2KZ3RrAcYaJ4OV8OLXatCgYk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1309
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10301 signatures=695566
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 adultscore=0 mlxlogscore=770 phishscore=0 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203300013
X-Proofpoint-ORIG-GUID: yf0Ip1-AYXewesPT_mDpH6MiEEH6zdRE
X-Proofpoint-GUID: yf0Ip1-AYXewesPT_mDpH6MiEEH6zdRE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Wenchao,

> iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is
> zero filled already including the dd_data. So it is unnecessary to
> call memset again.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering