Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1684402pxb; Wed, 30 Mar 2022 08:17:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbXXUAhzhaXjr0r70Y3uk2AjEt45dTlW2mFdpbKKHFgQUgf2PqLLcnsf4wzYaMRZJiCWsF X-Received: by 2002:a05:6402:d72:b0:419:938d:f4ce with SMTP id ec50-20020a0564020d7200b00419938df4cemr11440638edb.166.1648653477500; Wed, 30 Mar 2022 08:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648653477; cv=none; d=google.com; s=arc-20160816; b=PU1SsEXVwNAO1Yev6PczVfs3DWBHwlbq2SjYMFOgRp3ILJxEJCVnA4iIDg9u+hmERO wvk/Lqqxylx1V3OaHPr/OcsWqHX8Yp9CPetYWmp0SbyoFILhrOZFiObHEtUmVaoZrWKE rKCCQyjXguVIYFzUyjGsVYQcTEyxhKJSorwpXayUIdlB2bpsb6d9KJD88TxkBWZrk3z1 DEvMHjlTJmXVbbYetoH1/+/S8FxSs7Px8hmgU7GlOrc7gOcZ7TO2dDCqhatnWoOloNBj vJ94a+UKQn4FqSkVMESlD/FlTfG4Bu747idLpKMESSPHozLeNTXvJnB/qjBBHCh/ojpw Ti4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=AXoZ2kOsBGxApaH2uMkV8eqTHgAw2J7XwWz8cHkyEEA=; b=S4bWgqxBgBLlhZDZ2T0glMTNm2zo3TYKIsMsN6Z8gD5sk1jhWugzLHND8miXGzQdAq drt8+vyiIDFn20tj2A/CSDPqoindQ9r7G5yjQVEc5CWfS/R8nI4INURIXW4tXxGhmGAe 7wK8dnOO29ST8LLvoQoGW1GfU5LYqUm8fdH9bHqqJ4IJX2GlyJASOkeadTuTvP55r9xx GFuG5GjdkwcUDhcK+Cb2ZgIWCSIYDHriS6M9OHhqux7P5onmc1LfWQ/t6osEGZDMNpCq gJPVZuXInZPrG48pdkDTIV6kAZUMBOJd8z9oIQVwUzxSiBI2gqJBhh237I4H8j2QDnn5 THHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="iPGClli/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a170906220500b006df76385ce4si19371431ejs.388.2022.03.30.08.17.30; Wed, 30 Mar 2022 08:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="iPGClli/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243663AbiC3HLJ (ORCPT + 99 others); Wed, 30 Mar 2022 03:11:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243645AbiC3HLC (ORCPT ); Wed, 30 Mar 2022 03:11:02 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8B03149275; Wed, 30 Mar 2022 00:09:17 -0700 (PDT) Received: from [IPV6:2a01:e0a:120:3210:878d:2faa:2c0:e971] (unknown [IPv6:2a01:e0a:120:3210:878d:2faa:2c0:e971]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 34EBE1F4393C; Wed, 30 Mar 2022 08:09:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1648624154; bh=/auqYgE6atGKx1zfpIcEhqQjKbm1Uw144zMxSSF/g/o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iPGClli/3o3NAp53WWmMTF3RjhB2nByGxFdd/5ztxrBrj3veqCFJDkEkSurnUXg7K N0jLbpI/Ce4RL1LCFVWSP8p9EUI9X56DVB80xXwLZZItZ6dmLqBRIkKgRV4deRjNB8 FV5xoGK2XrKidUvTDI/yTlKK32X08Fls9d1+CFZNVDzYcZURuXGkSiUOP1k+mJr+1G Qzm5qpU3cLeRhwEKDXbVN9/K62RH74UhObs87uMqOuXsQZp/sVm62OT4pdi3dDem6t E3ttd5emyUDrHNyLflrEdronwdm67m94UT/1bXQuChMyRWYDlNsaHFDngRfooxYe4f TngR6V2WXHMBA== Message-ID: Date: Wed, 30 Mar 2022 09:09:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 00/15] Move HEVC stateless controls out of staging Content-Language: en-US To: mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, jonas@kwiboo.se, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk References: <20220228140838.622021-1-benjamin.gaignard@collabora.com> From: Benjamin Gaignard In-Reply-To: <20220228140838.622021-1-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 28/02/2022 à 15:08, Benjamin Gaignard a écrit : > This series aims to make HEVC uapi stable and usable for hardware > decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) > and 2 out of the tree drivers (rkvdec and RPI). > > After the remarks done on version 2, I have completely reworked to patches > split so changelogs are meaningless. I have also drop "RFC" from the > titles. > > Version 4: > - Add num_entry_point_offsets field in struct v4l2_ctrl_hevc_slice_params > - Fix V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS name > - Initialize control V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS > - Fix space/tab issue in kernel-doc > - Add patch to change data_bit_offset definition > - Fix hantro-media SPDX license > - put controls under stateless section in v4l2-ctrls-defs.c > > At the end fluster tests results on IMX8MQ is 77/147 for HEVC codec. Dear reviewers, This series is waiting for your feedback, Thanks, Benjamin > > Benjamin > > > Benjamin Gaignard (12): > media: uapi: HEVC: Add missing fields in HEVC controls > media: uapi: HEVC: Rename HEVC stateless controls with STATELESS > prefix > media: uapi: HEVC: Add document uAPI structure > media: uapi: HEVC: Define V4L2_CID_STATELESS_HEVC_SLICE_PARAMS as a > dynamic array > media: uapi: Move parsed HEVC pixel format out of staging > media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS control > media: uapi: Move the HEVC stateless control type out of staging > media: controls: Log HEVC stateless control in .std_log > media: uapi: Create a dedicated header for Hantro control > media: uapi: HEVC: fix padding in v4l2 control structures > media: uapi: Change data_bit_offset definition > media: uapi: move HEVC stateless controls out of staging > > Hans Verkuil (3): > videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY > v4l2-ctrls: add support for dynamically allocated arrays. > vivid: add dynamic array test control > > .../userspace-api/media/drivers/hantro.rst | 5 - > .../media/v4l/ext-ctrls-codec-stateless.rst | 833 ++++++++++++++++++ > .../media/v4l/ext-ctrls-codec.rst | 780 ---------------- > .../media/v4l/pixfmt-compressed.rst | 7 +- > .../media/v4l/vidioc-g-ext-ctrls.rst | 20 + > .../media/v4l/vidioc-queryctrl.rst | 8 + > .../media/videodev2.h.rst.exceptions | 5 + > .../media/test-drivers/vivid/vivid-ctrls.c | 15 + > drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 198 ++++- > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 37 +- > drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- > drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- > drivers/staging/media/hantro/hantro_drv.c | 27 +- > drivers/staging/media/hantro/hantro_hevc.c | 8 +- > drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- > .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- > .../staging/media/sunxi/cedrus/cedrus_h265.c | 2 +- > include/media/hevc-ctrls.h | 250 ------ > include/media/v4l2-ctrls.h | 48 +- > include/uapi/linux/hantro-media.h | 19 + > include/uapi/linux/v4l2-controls.h | 439 +++++++++ > include/uapi/linux/videodev2.h | 13 + > 23 files changed, 1697 insertions(+), 1170 deletions(-) > delete mode 100644 include/media/hevc-ctrls.h > create mode 100644 include/uapi/linux/hantro-media.h >