Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1727835pxb; Wed, 30 Mar 2022 09:03:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvovaXLBhIE/6l8/cuLt4fE6b6A49aEbyusfLDSQKgLTimK840BOcQbjFrC59wxL55fRUI X-Received: by 2002:ab0:6c49:0:b0:35a:fc8e:85f4 with SMTP id q9-20020ab06c49000000b0035afc8e85f4mr143245uas.22.1648656231967; Wed, 30 Mar 2022 09:03:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648656231; cv=none; d=google.com; s=arc-20160816; b=jOIt3KdmufOiAsnFIA1L9cv943oymGUcRhDaYwyQhoUJSND+NJ40x2tYeWiRbUfbbO iXWqp+2ns/pHKu9xumdy1CwRr3avKC+asYWAEA3v7u6cob10X+2sretjJRL2fThS2AMn 6D2GZXkVNaDOy78vUB+2YsO36/nrpzmqe9NTdspnakziXLQrcVQdKpM8QoCdRpsGCjUj IHjlItVMZHLQB5D/BPScqUSsmQaZBjLWF0WJ9fwH9Js/bs/I6r4cv4cHbWgAVMOVVGgk oE404YY/bYg7B3VZ5oiWWRGfQ+inNNtB0HP3u5rPGG+gD1Knom0ezmnj6GY5Ofy4o5LF 0MUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cFscs9a4lBA8lnwkkutsSsPBXiFXGYRCiVbsg2PtHhk=; b=r37KMDNAVZ23l76+PaeErBb79t2G+yVwcJLsodhHm61d5XXOfe9nVN0IbKqlDVGsuY Bl8nJwBQL7TkQW2f6cYaGWcQ4fpfCOE/8d0mac1jt3+7Nxi7tkOJlCd3/XeKlc+K5gkz TmFjtq23SgqCMb3k6qP6CSHgK59MBffixPxySe1kVHoATgz+bxkLQY98oL4RR/nAyd0n qzBtHvD5ftw0PWIed12hd3gC8/QgRQFooMHIPHPFDQqfl+JUgk67bq8LJvg3dmS4B10x EpZOV9HX18fP36xfah45EU5VdcyvrrrajwK6TFCNBwVKXsmAjmldS+HHcjdXv7QePppQ fKkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oCRtzICX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a056122139000b00343a31b7b37si131039vkp.143.2022.03.30.09.03.34; Wed, 30 Mar 2022 09:03:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oCRtzICX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346517AbiC3Nwr (ORCPT + 99 others); Wed, 30 Mar 2022 09:52:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346471AbiC3Nwd (ORCPT ); Wed, 30 Mar 2022 09:52:33 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D8E213CA15; Wed, 30 Mar 2022 06:50:47 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id u26so24468037eda.12; Wed, 30 Mar 2022 06:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cFscs9a4lBA8lnwkkutsSsPBXiFXGYRCiVbsg2PtHhk=; b=oCRtzICXcGnyB/eQ+oVQIlB7OaiwlgstHYPMvB0t35KOpq9RjfKcUMPhcNU1QGGk5U ko+WAQ9c/s29BJ2Xi6zT0QOqaKwYa63tKfxYFA6vYTSY+ARO4sJfGg8ulScWZX56axd6 +D3aqi00sV8Wlcl9LR8VszDTpAz/JzLLElryVuJsUhJANOGTgPqzBHnjuytvZK5AMM7g 3accHYU9lHPfXqyunhqaU7Bfk9rPkDSCDu0b9UvT2RvsT3dUic+e74s1kD+W1X1eCPPN eD7WmauBrYBig6O3sIZTUWrc/RGEP2IWDhoGAP1T2F0Qbw/pNofoNmiWXX/AvIYLAQJB gT6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cFscs9a4lBA8lnwkkutsSsPBXiFXGYRCiVbsg2PtHhk=; b=JdJ/3JJsWFWQRf4dUF+n5bDPihDqthO/WAcxRZdvszYD/DSL4JC6P0utcYdWu0EZfr o2+2WzHxnNy3NAdoplkzi2hKf4qdALjbUHFR5DyO2vFUv9FMLT3YS29828Yw7vC29TWH YfEQv1OtzsHo5N4RpGA7m2soxqcsq1b3TepSck+ig0DaTMQ/dRAz89YiIUbWQ+8iHKaS R4EA49/8bKoJ3gGUgcFJ45em8QRByz0mlImPgbpN2l8ROs8aU64HJwBlJRlXoZsP5LOn wQji2w0FyAcaQmdSwkx/ZUANhjMMNPWzH4kQYHERF7U2nqG3+ZGv+FMNYFNkh11/hCUZ v9pQ== X-Gm-Message-State: AOAM533hH0B1WAvOe/HttXAjhDS6DvVaHXwUG5Y0fJh1dQiftgruteGc /J04oThH91TWhXvaaZYFMWY= X-Received: by 2002:a05:6402:2789:b0:419:5317:7d39 with SMTP id b9-20020a056402278900b0041953177d39mr10689377ede.53.1648648245946; Wed, 30 Mar 2022 06:50:45 -0700 (PDT) Received: from krava ([193.85.244.190]) by smtp.gmail.com with ESMTPSA id j21-20020a170906255500b006e08c4862ccsm7369328ejb.96.2022.03.30.06.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 06:50:45 -0700 (PDT) Date: Wed, 30 Mar 2022 15:50:43 +0200 From: Jiri Olsa To: Shunsuke Nakamura Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [RFC PATCH v2 4/7] libperf: Introduce perf_{evsel, evlist}__open_opt with extensible struct opts Message-ID: References: <20220325043829.224045-1-nakamura.shun@fujitsu.com> <20220325043829.224045-5-nakamura.shun@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220325043829.224045-5-nakamura.shun@fujitsu.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2022 at 01:38:26PM +0900, Shunsuke Nakamura wrote: SNIP > diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c > index b17842581dea..db9b7274feb5 100644 > --- a/tools/lib/perf/evsel.c > +++ b/tools/lib/perf/evsel.c > @@ -1,4 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > +#ifndef _GNU_SOURCE > +#define _GNU_SOURCE > +#endif I think we can make this global set in Makefile, like we do in perf jirka