Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "VURDIGERENATARAJ, CHANDAN" <CHANDAN.VURDIGERENATARAJ@amd.com>
To:     "Lin, Tsung-hua (Ryan)" <Tsung-hua.Lin@amd.com>
CC:     "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        Drew Davenport <ddavenport@chromium.org>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Li, Leon" <Leon.Li@amd.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        David Airlie <airlied@linux.ie>,
        Sean Paul <seanpaul@chromium.org>,
        Louis Li <ching-shih.li@amd.corp-partner.google.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        =?iso-8859-1?Q?St=E9phane_Marchesin?= <marcheu@chromium.org>,
        "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>,
        "Wentland, Harry" <Harry.Wentland@amd.com>,
        "Lin, Tsung-hua (Ryan)" <Tsung-hua.Lin@amd.com>,
        Mark Yacoub <markyacoub@google.com>
Subject: RE: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc
 of the 3250c is not correct
Thread-Topic: [PATCH v2] drm/amdgpu: fix that issue that the number of the
 crtc of the 3250c is not correct
Thread-Index: AQHYQ+Hv6rbl9hCEq0aViheFKo1J4qzXTxsA
Date:   Wed, 30 Mar 2022 04:29:38 +0000
Message-ID: <MW4PR12MB566833076458CCAC433C4187961F9@MW4PR12MB5668.namprd12.prod.outlook.com>
References: <20220127081237.13903-1-Tsung-Hua.Lin@amd.com>
 <20220330024643.162230-1-tsung-hua.lin@amd.com>
In-Reply-To: <20220330024643.162230-1-tsung-hua.lin@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?qchmbPmBGeiVeuuPBTdJvcsXCzRYIwxV3jLdIzTheCbVsjvIrillVvgE7u?=
 =?iso-8859-1?Q?jvHoRl6NKEUL1c2tHTS0tgUfwnv+DAdfblNiSCH6FWEWzg+YowdgzP2G4X?=
 =?iso-8859-1?Q?R+ukrV34f+RkMFNSZAoqHgj2R+gsrt1YbiBtNFpI+ytz1gM2YmaQPO0aDK?=
 =?iso-8859-1?Q?FzMRIcXZgERLxAcmnsi4S0Q64nkhlujj2YiZWgQSo3KIskQSFrL+YCQJP2?=
 =?iso-8859-1?Q?wNRI69wbrGd4ovmorL56jNcoOFu5bdMVpA0RhUAO3nvCuA/cjnlw6Qd8bN?=
 =?iso-8859-1?Q?gGBsxrAe2AlOEklR1svUJ4mB7mPAOdvq5e+sAu2L2TtyMeW9tobueMtTNO?=
 =?iso-8859-1?Q?+S3VHA/8gN2bqIC8/OYTvWMF3ZFT8O/w5BSSxEGPhFrTOluOG+MDWb8UVR?=
 =?iso-8859-1?Q?h2atpyhpP11LPQ+6d0hD2A3B2UvXCv5mH5r2RIcJfge5fIc2XfGaVFvXAq?=
 =?iso-8859-1?Q?PQQMrFLUzoFoCmMjOuqiPHqTpx/Xm4Pv2/SKDHZ8zuNbl5gr3w6mm8jMzN?=
 =?iso-8859-1?Q?p2UD/RxgmKhiUliGT6KpBiTeWCSmuywf0HZgE2PjoHgGK3J0g/KSQ63kOi?=
 =?iso-8859-1?Q?TBz7vVBvthipZDW2d349YF9jqtzCGywXFEyZcs/cd7QIeJAKUhgrWCfDFL?=
 =?iso-8859-1?Q?CPBK/31HannxOl2UPM1z0QLlFfsBq8lA4zDmzCv7NYJ1lwdVusuFG7JYKO?=
 =?iso-8859-1?Q?JU6uVbfBEVkDixrj/TTWNogtrB0xvo17wUgzNUIbDg+SwinegcADSNCpkb?=
 =?iso-8859-1?Q?Fg3KccAz9sYDp9VCfhbFPpNKUm9+RXJoJotmUUDLAl++q+wx2GUqN14BEb?=
 =?iso-8859-1?Q?0O/JIN0QJTFi+P0EHOJzMs8JwYRiqUUip+G9xnmHMww5kabpEJyUYSMaqS?=
 =?iso-8859-1?Q?PGeH+nnmQAq5NwtdpMlx2iaLo7pqRVrwXg5jQ7DfIhJcsmbPqBvoTgCSEc?=
 =?iso-8859-1?Q?JZjV70I21DmubAJe5R0ghT2qSPKX8xocB8rDyZgC6zqwvgF8xfjQue5emA?=
 =?iso-8859-1?Q?LNw5lX8sI0F/+URv0OJGSffCWBgg+LP0mJ/8uOG+aSq9Y1AWzziqo1XcUb?=
 =?iso-8859-1?Q?D/rBWFwBNxJL0v17HWC8jx1b7rgknXYoVkpjigRv7YzTElDnunwDLRHb8J?=
 =?iso-8859-1?Q?AxFsQ+Gv3uaV2ek6kZqkqo8N5/iaWjjMFh8eMyOu0Ge0JtnjEneZZ58YE5?=
 =?iso-8859-1?Q?Rytia/HJU3JxrWuuJHi2NORZ21diRjKNX1XrOGcT27lUnT3968Kl4yLJBb?=
 =?iso-8859-1?Q?SbM+Q5KeYWE9hjZH+qMEzNocOJk1KVl0xIOyTMaU2GUBpf944FbpPpw9Ua?=
 =?iso-8859-1?Q?lyXRoq8VypU8tFA4S6IBOHEruJ3W4R+mYK2A/URG6VD4kHYAzs+zZvrNPk?=
 =?iso-8859-1?Q?yh0l07cIaA043uesAGVVawo97yOlR77A64qfneRYzFGbxu7/tJk5QGLtLO?=
 =?iso-8859-1?Q?FSFBx/BdkqTKMexXEfUfPpWlSOy5KVMKdeYVVwUr9DbRjOHAphKBdBaFJz?=
 =?iso-8859-1?Q?EASvIJ2qxdHe9UcORJcz9pEmbiXmkZqdesXFDOQ343qyOsMnH91W/elJbo?=
 =?iso-8859-1?Q?Qv8td9m97+O/wu5k70MVvtTSPXvl0YrDlw8RxUoHxLxZMVLXj2ttWFWn9o?=
 =?iso-8859-1?Q?YmAk9y4FoISc76XN7BsPS4RxNm7WaRLt+z8WiksGalneDRz8gCjagZhxqF?=
 =?iso-8859-1?Q?coj7V9X1TAKr2nahrKyEptUPs6m7Gx/WtAniLBhKLPyA991IzbWHQil+qZ?=
 =?iso-8859-1?Q?jl/0ylEs0BjUTdVHchcdqt6yUKn3/ssSSWpKYw4ik8dP3juWsS7ALlt4+5?=
 =?iso-8859-1?Q?JRSjL6kSaA=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB5668.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0580cd3b-6e72-4f79-b316-08da1205e712
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 04:29:38.5058
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eXKlIFfHmJ5UoNbv/dIhUaSEe0apWap/WfSg3T6WEHNn2q3PQKiDJMcavDCQLakvuEXIzJJffvODYU0uIvGw9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4323
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Ryan,

Is this change applicable on a specific kernel version?
On latest I see IP DISCOVERY based impl for CHIP_RAVEN.

>[Why]
>External displays take priority over internal display when there are fewer=
 display controllers than displays.
>
> [How]
>The root cause is because of that number of the crtc is not correct.
>The number of the crtc on the 3250c is 3, but on the 3500c is 4.
>On the source code, we can see that number of the crtc has been fixed at 4=
.
>Needs to set the num_crtc to 3 for 3250c platform.
>
>v2:
>   - remove unnecessary comments and Id
>
>Signed-off-by: Ryan Lin <tsung-hua.lin@amd.com>
>
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/g=
pu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index 40c91b448f7da..455a2c45e8cda 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -2738,9 +2738,15 @@ static int dm_early_init(void *handle)
> 		break;
> #if defined(CONFIG_DRM_AMD_DC_DCN1_0)
> 	case CHIP_RAVEN:
>-		adev->mode_info.num_crtc =3D 4;
>-		adev->mode_info.num_hpd =3D 4;
>-		adev->mode_info.num_dig =3D 4;
>+		if (adev->rev_id >=3D 8) {

May I know what this ">=3D8" indicate? Also, should it be external_rev_id i=
f its based on old version?

>+			adev->mode_info.num_crtc =3D 3;
>+			adev->mode_info.num_hpd =3D 3;
>+			adev->mode_info.num_dig =3D 3;
>+		} else {
>+			adev->mode_info.num_crtc =3D 4;
>+			adev->mode_info.num_hpd =3D 4;
>+			adev->mode_info.num_dig =3D 4;
>+		}
> 		break;
> #endif
> #if defined(CONFIG_DRM_AMD_DC_DCN2_0)
>--
>2.25.1
>

BR,
Chandan V N