Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-2ca61ae4-4f05-454d-94fd-d41e1afbec2f-1648581688394@3c-app-gmx-bs54>
From:   Robert Schlabbach <robert_s@gmx.net>
To:     Thorsten Leemhuis <regressions@leemhuis.info>
Cc:     Antti Palosaari <crope@iki.fi>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug 215726 - si2157.c: mention name of the missing firmware
 file
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 29 Mar 2022 21:21:28 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <5f660108-8812-383c-83e4-29ee0558d623@leemhuis.info>
References: <5f660108-8812-383c-83e4-29ee0558d623@leemhuis.info>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Thorsten,

the patch linked in the bugzilla ticket:

https://lore=2Ekernel=2Eorg/linux-media/6f84b7f4-3ede-ae55-e99b-a9d4108c80=
e2@gmail=2Ecom/

should indeed fix the issue=2E The error was that the rom_id and required
fields were swapped in the table, so the non-zero rom_id was taken as a
"true" required boolean value, thus incorrectly evaluating that the
chip requires a firmware file to operate when in fact it does not=2E

I have tested the patch and found it worked for me=2E But I do not know
how to push this further along:

https://patchwork=2Elinuxtv=2Eorg/project/linux-media/patch/6f84b7f4-3ede-=
ae55-e99b-a9d4108c80e2@gmail=2Ecom/

Best Regards,
-Robert Schlabbach

=C2=A0

Gesendet:=C2=A0Dienstag, 29=2E M=C3=A4rz 2022 um 10:33 Uhr
Von:=C2=A0"Thorsten Leemhuis" <regressions@leemhuis=2Einfo>
An:=C2=A0"Antti Palosaari" <crope@iki=2Efi>, "Mauro Carvalho Chehab" <mche=
hab+huawei@kernel=2Eorg>, "Robert Schlabbach" <robert_s@gmx=2Enet>
Cc:=C2=A0"regressions@lists=2Elinux=2Edev" <regressions@lists=2Elinux=2Ede=
v>, az0123456@gmx=2Ede, "Linux Media Mailing List" <linux-media@vger=2Ekern=
el=2Eorg>, "Linux Kernel Mailing List" <linux-kernel@vger=2Ekernel=2Eorg>
Betreff:=C2=A0Bug 215726 - si2157=2Ec: mention name of the missing firmwar=
e file
Hi, this is your Linux kernel regression tracker=2E

I noticed a regression report in bugzilla=2Ekernel=2Eorg that afaics nobod=
y
acted upon since it was reported about a week ago, that's why I decided
to forward it to the lists and all people that seemed to be relevant
here=2E To quote from https://bugzilla=2Ekernel=2Eorg/show_bug=2Ecgi?id=3D=
215726 :

> I get the following error messages when trying to use si2157=2Eko in lin=
ux 5=2E17:
> si2157 13-0060: found a 'Silicon Labs Si2157-A30 ROM 0x50'
> si2157 13-0060: Can't continue without a firmware
> I did work in linux 5=2E16=2E16 without a firmware file=2E Unfortunately=
 the driver does not tell me the name of the missing firmware file=2E

Could somebody take a look into this? Or was this discussed somewhere
else already? Or even fixed?