Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Mar 2022 17:52:09 +0000
To:     Joel Selvaraj <jo@jsfamily.in>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Amit Pundir <amit.pundir@linaro.org>
Reply-To: Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom ipa driver
Message-ID: <fd83bd38-813b-40a0-4848-19b4467385b9@connolly.tech>
In-Reply-To: <BY5PR02MB7009405D7C06C0B480974063D91F9@BY5PR02MB7009.namprd02.prod.outlook.com>
References: <20220330064505.243799-1-jo@jsfamily.in> <BY5PR02MB7009405D7C06C0B480974063D91F9@BY5PR02MB7009.namprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 30/03/2022 07:45, Joel Selvaraj wrote:
> Enable Qualcomm IP Accelerator (IPA) driver for mobile data functionality
> which works by using ModemManager.
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@jsfamily.in>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/=
arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index 27ba9ad1ad02..801b8c5984a3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -292,6 +292,12 @@ &mss_pil {
>   =09firmware-name =3D "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/bery=
llium/modem.mbn";
>   };
>
> +&ipa {
> +=09status =3D "okay";
> +=09memory-region =3D <&ipa_fw_mem>;
> +=09firmware-name =3D "qcom/sdm845/beryllium/ipa_fws.mbn";
> +};
> +
>   &pm8998_gpio {
>   =09vol_up_pin_a: vol-up-active {
>   =09=09pins =3D "gpio6";
> --
> 2.35.1
>

--
Kind Regards,
Caleb