Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Mar 2022 09:37:35 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     "Zhang, Qiang1" <qiang1.zhang@intel.com>
Cc:     syzbot <syzbot+4d0ae90a195b269f102d@syzkaller.appspotmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "pfink@christ-es.de" <pfink@christ-es.de>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>,
        "wg@grandegger.com" <wg@grandegger.com>
Subject: Re: [syzbot] memory leak in gs_usb_probe
Message-ID: <20220330073735.tqfmyfgzyfbqmkpn@pengutronix.de>
References: <000000000000bd6ee505db5cfec6@google.com>
 <PH0PR11MB5880D90EDFAA0A190D927914DA1F9@PH0PR11MB5880.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="u2qbbpeazfhzmyv4"
Content-Disposition: inline
In-Reply-To: <PH0PR11MB5880D90EDFAA0A190D927914DA1F9@PH0PR11MB5880.namprd11.prod.outlook.com>
Precedence: bulk


--u2qbbpeazfhzmyv4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 30.03.2022 01:57:08, Zhang, Qiang1 wrote:
> Hello,
>=20
> syzbot found the following issue on:
>=20
> HEAD commit:    52deda9551a0 Merge branch 'akpm' (patches from Andrew)
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=3D12b472dd700000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3D9ca2a67ddb200=
27f
> dashboard link: https://syzkaller.appspot.com/bug?extid=3D4d0ae90a195b269=
f102d
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binuti=
ls for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D12e96e1d700=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D12f8b513700000
>=20
> IMPORTANT: if you fix the issue, please add the following tag to the comm=
it:
> Reported-by: syzbot+4d0ae90a195b269f102d@syzkaller.appspotmail.com

[...]

> diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
> index 67408e316062..5234cfff84b8 100644
> --- a/drivers/net/can/usb/gs_usb.c
> +++ b/drivers/net/can/usb/gs_usb.c
> @@ -1092,6 +1092,7 @@ static struct gs_can *gs_make_candev(unsigned int c=
hannel,
>                 dev->data_bt_const.brp_inc =3D le32_to_cpu(bt_const_exten=
ded->dbrp_inc);
>=20
>                 dev->can.data_bittiming_const =3D &dev->data_bt_const;
> +               kfree(bt_const_extended);
>         }
>=20
>         SET_NETDEV_DEV(netdev, &intf->dev);

I have already send a similar fix:

| https://lore.kernel.org/all/20220329193450.659726-1-mkl@pengutronix.de

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--u2qbbpeazfhzmyv4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJECL0ACgkQrX5LkNig
010Jigf/UYHDKXYUu5jFycIr7rrBq8r5VIcDaqmDlplnJPSKchZQPkm8fh90b2yu
jOzjOuWc7KPzuG6RQczoTAKnFP7kZDaCyTEnsIsoE9sdOmN/mpriPLADvRVt24Xq
mdGz3n5YeqEjaX6Sc4qXOK2NuzDljYia+rN29+2hiTAehZ/ozKk+L4FDbOTqdA0+
p7onZyyAK1o9Gd0dj6oJ8uNXLuItZQpo+NiUZgfaHgbbcBNhjySxCiB/XPx1TkCw
bh3EVHr76BVZ/81Vi2boNxNOLNSrVpe7PKPLf5VRVR/yED/9GVopYwiWJWT9TW28
yj1X0NbloZxb4RBfmBy2pnMwPe1J3g==
=wJB8
-----END PGP SIGNATURE-----

--u2qbbpeazfhzmyv4--