Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2210481pxb; Wed, 30 Mar 2022 19:26:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxE50aQCzieFEs078f6n2QsWGbofqnl+NHs24SIqhqfgcpcqTckjAtv2Fg9xzoz/o1AZXHs X-Received: by 2002:a17:902:b7c1:b0:153:e971:663e with SMTP id v1-20020a170902b7c100b00153e971663emr2754370plz.78.1648693611815; Wed, 30 Mar 2022 19:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648693611; cv=none; d=google.com; s=arc-20160816; b=OL1OKRJ5yOURJ5XN+qx4BSQu/4eIsM+SqVQhX/Iu0GZKDEAV7U/v5sooVC8dY19Iek UO/e3Y5HYeJOL6YMcQLd+32dabd7uHcSEcG2GOojhL04NKWEl1W51Jh+FRro1yEyvmLv n8fXCW5vvl6ru0k8kcdiLlFtqOyYJ0BSBVPuVS6C2l2l8pJJFKPHZA07cgL6ntUfQ48z Kr79SRhbzEVAvEoBVqSOUMhqK8EzGjXjsPtl6NKwtrx2/9gjbrYWiBoW1IpH1b8Xjsck J/7kCQ62F3GTkzKmONy1k3/OAeXi5uad0/mxtoyu58hxmhHSpZQYZrSejlgMlPg9GPr+ fQcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ekBWMhJOJrwEuMsGOrTITmAnhNKuavdbk+/QN6gEvTs=; b=fB+TwXqvDldGOMkYXEhE6c1kpFv34LtjTZxTixsoBNvRhpaRNHhmg8puIrBHUq/sVg Qbsx/RZcsL8KuSl8vxzysS7XPC6y1UPtf6PtHLCUARGuuQa7aSTcLn9jjOCP7ZLPMfNC o/jUTnCBdYl6Wcf4TERcpdzeHAok43QKm7X6W48Dii2zCbaiEgEk8GINhAxv3Pc6H58u V4SjZHxqZlO9MFsNdDYZCrHkaizqbfUvYN5cTR6B0F01kO58RzSuDOLoNMcQa1hIna3t xcvzRNJ8Iq6qr8uoFUuYUzIwNPfOq3+Szlw2942PjvsyLfyx50osOXweETFYEGyUi6Zv dCyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=YSvsl56W; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n4-20020a654884000000b0039845840ff2si14567730pgs.41.2022.03.30.19.26.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 19:26:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=YSvsl56W; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 91E8D6D1A1; Wed, 30 Mar 2022 19:25:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346491AbiC3OAu (ORCPT + 99 others); Wed, 30 Mar 2022 10:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245501AbiC3OAr (ORCPT ); Wed, 30 Mar 2022 10:00:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40D53CD316; Wed, 30 Mar 2022 06:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ekBWMhJOJrwEuMsGOrTITmAnhNKuavdbk+/QN6gEvTs=; b=YSvsl56WcO71Nuk3c5QDcSCxxy aqmLXXZtjnnXGU/x8qu7GjHoG3Gp9GlgliYoXWsgeP6v49TZjlQBa95By5+e0IYOPimXw9UdZjqAr gS3NTY/kV27ln73N0wWEoMsk4JzQkWtd5NEp2fVFXSH6qaRpO8TT+G+qmv0wSmRdd13g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nZYqC-00DK3H-O3; Wed, 30 Mar 2022 15:58:28 +0200 Date: Wed, 30 Mar 2022 15:58:28 +0200 From: Andrew Lunn To: David Laight Cc: 'Guenter Roeck' , 'Michael Walle' , Xu Yilun , Tom Rix , Jean Delvare , Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , Paolo Abeni , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 1/5] hwmon: introduce hwmon_sanitize_name() Message-ID: References: <20220329160730.3265481-1-michael@walle.cc> <20220329160730.3265481-2-michael@walle.cc> <16d8b45eba7b44e78fa8205e6666f2bd@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So why not error the request to created the hwmon device with > an invalid name. > The name supplied will soon get fixed - since it is a literal > string in the calling driver. It is often not a literal string in the driver, but something based on the DT description of the hardware. Andrew