Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2215020pxb; Wed, 30 Mar 2022 19:35:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHV2t2fVhxFCOMNHNuvRvgMTniM0Ihl5PZuHV69488mlLcHbNRxFUhCETlNjyve57n1W+5 X-Received: by 2002:a17:903:32c2:b0:154:4175:a945 with SMTP id i2-20020a17090332c200b001544175a945mr37993636plr.130.1648694112313; Wed, 30 Mar 2022 19:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648694112; cv=none; d=google.com; s=arc-20160816; b=miCF1ucakpxlMBTsnwYOooWtdqQKVgyrB0iX//1GO+X8XSkWtbv/2fWIqvfBcpG/ZW II4+3AN2LJcQlxEktr+GPWfpvafpK/rorBSV4xnicjeVrS1BgIDMeymFEV+Xth4UeWAH Qcximgtjh3T6IR/kFC3ChZAY/QMCdR7ClieVfRogbyYhV684vw7SWRTC4cH69BzbrcF7 w3lH+LsR0PvZrCSzVw/76HyKT4eZJ8P+sHKcfeHwWpOuozQ21KcImZWe0y40fDbp4qbi baYTvr3yJ9REaVg4Vu5DF67/vtzeyymBnrxvVpvHbNhtK1vXVFidOAa3dfp4wjvtxXZ2 UW3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=aVrqvODcydDKmqfXUiGFmQmS2YYivT8aXnaV3vGqTVY=; b=YptfMJDfm6NTxqqVouAnrAL5E3Rz6TUi7B8ZKjgQC3emkfhqYBqmi0A4TMQ9Cf5u9F a6XTO40U0VIK+IlRmsvOPeaXB5dSOd7xJUa5kuOAGflL+DB8KsGVNrXuQKQ95TLJVENt cOv/iFS/4PIboi+toCHEIXQSEcQKK0tw9P2io/UlRqRC4TcP5fEyCcliR5X5GS/cY+wM cJC890JG8aU6WH8y103qG3jbS44Czznu8PVARpSM7lW4wcJycf6gcOk+bjwwXkQdBSDI fE/5T9pQavsmM6E2bP0QQWk+v2eaZH8EXJI/OVvBB6nDxY8ulAlJa7razzSDY+gjtADV 0JRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ETS+h89+; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id ob7-20020a17090b390700b001bf6d2ed1a3si2213152pjb.31.2022.03.30.19.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 19:35:12 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ETS+h89+; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 67F498596F; Wed, 30 Mar 2022 19:30:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244723AbiC3JUg (ORCPT + 99 others); Wed, 30 Mar 2022 05:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244719AbiC3JUe (ORCPT ); Wed, 30 Mar 2022 05:20:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED1822AC6E; Wed, 30 Mar 2022 02:18:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94042B81BB5; Wed, 30 Mar 2022 09:18:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E681C340EE; Wed, 30 Mar 2022 09:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648631927; bh=aVrqvODcydDKmqfXUiGFmQmS2YYivT8aXnaV3vGqTVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ETS+h89+1a8HgdOZdMoxpsku+eFq+yBSyCsyvVmdbSAgYUGwFhizqGvVCSdpBIjeG uzx9TvwsjKuqwivNdQSrn+tEzUbSeIWMq3yMopHNYIeIEsUmjojFvTuL7oVOMImBnK Gje3y/t6OKjlU4Qj7oCY1nk3vUK7FAQVooJxH8t0uGVDIMwSMLci6q35qSXgB4Yw4m VZycCjHT+hb10tv615NNQsh8jMzNEYHSDGqNEw9+LIzlaBhXGr58gFcizpWeM1kUhX q3hW249ou4U2YVMgtekpx3v2D1LkUzOoFWZMNhIkKSGuby4sHzTfAeg0DL7YXxsRz/ JHDL0faEzDBug== Date: Wed, 30 Mar 2022 11:18:43 +0200 From: Wolfram Sang To: Stephen Kitt Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: use i2c_match_id and simple i2c probe Message-ID: Mail-Followup-To: Wolfram Sang , Stephen Kitt , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220324165904.538861-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hozreqnn1jQnIoc+" Content-Disposition: inline In-Reply-To: <20220324165904.538861-1-steve@sk2.org> X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Hozreqnn1jQnIoc+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > +static const struct i2c_device_id cdce925_id[]; > + Instead of this declaration, I think we should move the MODULE_DEVICE_TABLES up here. --Hozreqnn1jQnIoc+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmJEIHMACgkQFA3kzBSg KbaAtw/+MbUtB2q/Iw3Bo0jpnt/Tscpb8p4CwVtnTWPAb49Pu2st/PvqGZ5wit92 0Si9Qyc9Ro9i5/auGIlfk1RGs2rPZx04nRFQuKU3cUWb8V0mZUueiGn9XdixNTYE A2EVgoFtSYbTExLukYb3Cb0w7O2CUOiUutbDB2Tkzg+5TDQab8bn2J8Gbr0RZnIJ FBxyFeyGd8wJ/o5QXMU4z9QtEzWfivyb33pe4IJNABfYJn0b+iPC5hDWEOrKIK2Z tCPbDpc6yIk7yoPZqi0knaeDqticw7G2Tcx52pQChC7ahn9q/pNrxLeUdvaEJ6HL m5sjcGXlxx2Ag9kwm1/AdXSnWuY0kvj3Gc+jbeva+9E5uhItsm0X09zD5ScG91Vv aCcWPuoWcvhDB7p53PLuLXutjHwsuMAFMNHJ/8JTNb6oX5VSsk3juQtEWRaZ++lD aIh3JR7imZW9sJlm+SSDFp+pun6hV8kUknskbjO24dU4HHo28Rx23JHc7RPOlgzC yFNlUw4P7zxR90K2c880531IO/KFBRFZICQqjM3I6nUaE92nTGzKYNu6WxHfB0J9 exgPBOnMfx20ex6yb4j6p/ukoV3EnSAJorEQpS8DiQEgr+/cl7EnEPY3Da7upkvU s7SWpOL5AVud+r/+ahqtSOqoy0xHwqxijQTkkJCCfOGgR7u7xgA= =0xij -----END PGP SIGNATURE----- --Hozreqnn1jQnIoc+--