Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 30 Mar 2022 14:02:29 +0300
From:   Ivan Bornyakov <i.bornyakov@metrotek.ru>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: imx-weim: fix pdev is NULL but dereferenced
Message-ID: <20220330110229.xczp74pd6o4xvfws@h-e2.ddg>
References: <1648635500-12631-1-git-send-email-baihaowen@meizu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1648635500-12631-1-git-send-email-baihaowen@meizu.com>
Precedence: bulk

Hi!

On Wed, Mar 30, 2022 at 06:18:20PM +0800, Haowen Bai wrote:
> pdev is NULL，so we can't dereference it dev_err(&pdev->dev
> 
> Fixes: e6cb540 ("bus: imx-weim: add DT overlay support for WEIM bus")
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/bus/imx-weim.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42..31a2213 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,9 +352,8 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>  
>  		pdev = of_find_device_by_node(rd->dn);
>  		if (!pdev) {
> -			dev_err(&pdev->dev,
> -				"Could not find platform device for '%pOF'\n",
> -				rd->dn);
> +			pr_err("%s: Could not find platform device for '%pOF'\n",
> +				__func__, rd->dn);
>  
>  			ret = notifier_from_errno(-EINVAL);
>  		} else {
> -- 
> 2.7.4
> 

This is a solid bug, but there is a fix already.

  https://lore.kernel.org/all/20220223035146.412499-1-wanjiabing@vivo.com/

For some reason it was not applied yet.