Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
In-Reply-To: <20220327155147.52e898b4@jic23-huawei>
References: <20220324222928.874522-1-swboyd@chromium.org> <20220327155147.52e898b4@jic23-huawei>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.10
Date:   Tue, 29 Mar 2022 22:25:31 +0200
Message-ID: <CAE-0n50T9uqcB9EK-RnGXPGhd6RWdrsE9pA5FJY9yC58xd=05A@mail.gmail.com>
Subject: Re: [PATCH v2] iio:proximity:sx9324: Fix hardware gain read/write
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, Gwendal Grignou <gwendal@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting Jonathan Cameron (2022-03-27 07:51:47)
> On Thu, 24 Mar 2022 15:29:28 -0700
> Stephen Boyd <swboyd@chromium.org> wrote:
>
> > There are four possible gain values according to 'sx9324_gain_vals[]':
> >
> >       1, 2, 4, and 8
> >
> > The values are off by one when writing and reading the register. The
> > bits should be set according to this equation:
> >
> >       ilog2(<gain>) + 1
> >
> > so that a gain of 8 is 0x3 in the register field and a gain of 4 is 0x2
> > in the register field, etc
>
> Example seems wrong...
>
> ilog2(8) + 1 = 3 + 1 = 0x4
> ilog2(4) + 1 = 2 + 1 = 0x3
> ilog2(2) + 1 = 1 + 1 = 0x2
> ilog2(1) + 1 = 0 + 1 = 0x1
>                        0x0 reserved.
>
> or have I misunderstood?

Nope. I hit the wrong key but your table is correct. Can you fix it when
applying?