Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 30 Mar 2022 15:56:41 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Haakon Bugge <haakon.bugge@oracle.com>
Cc:     Guo Zhengkui <guozhengkui@vivo.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Yishai Hadas <yishaih@nvidia.com>,
        OFED mailing list <linux-rdma@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "zhengkui_guo@outlook.com" <zhengkui_guo@outlook.com>
Subject: Re: [PATCH linux-next] RDMA: simplify if-if to if-else
Message-ID: <YkRTidagKVgSUGld@unreal>
References: <20220328130900.8539-1-guozhengkui@vivo.com>
 <YkQ43f9pFnU+BnC7@unreal>
 <76AE36BF-01F9-420B-B7BF-A7C9F523A45C@oracle.com>
 <YkQ/092IYsQxU9bi@unreal>
 <93D39EC2-6C71-45D8-883A-F8DAA6ECFEDF@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <93D39EC2-6C71-45D8-883A-F8DAA6ECFEDF@oracle.com>
Precedence: bulk

On Wed, Mar 30, 2022 at 12:26:51PM +0000, Haakon Bugge wrote:
> 
> 
> > On 30 Mar 2022, at 13:32, Leon Romanovsky <leon@kernel.org> wrote:
> > 
> > On Wed, Mar 30, 2022 at 11:06:03AM +0000, Haakon Bugge wrote:
> >> 
> >> 
> >>> On 30 Mar 2022, at 13:02, Leon Romanovsky <leon@kernel.org> wrote:
> >>> 
> >>> On Mon, Mar 28, 2022 at 09:08:59PM +0800, Guo Zhengkui wrote:
> >>>> `if (!ret)` can be replaced with `else` for simplification.
> >>>> 
> >>>> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> >>>> ---
> >>>> drivers/infiniband/hw/irdma/puda.c | 4 ++--
> >>>> drivers/infiniband/hw/mlx4/mcg.c   | 3 +--
> >>>> 2 files changed, 3 insertions(+), 4 deletions(-)
> >>>> 
> >>> 
> >>> Thanks,
> >>> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> >> 
> >> Fix the unbalanced curly brackets at the same time?
> > 
> > I think that it is ok to have if () ... else { ... } code.
> 
> 
> Hmm, doesn't the kernel coding style say:
> 
> "Do not unnecessarily use braces where a single statement will do."
> 
> [snip]
> 
> "This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches"

ok, if it is written in documentation, let's follow it.

Thanks for pointing that out.

> 
> 
> Thxs, H?kon
> 
> 
> > 
> > There is one place that needs an indentation fix, in mlx4, but it is
> > faster to fix when applying the patch instead of asking to resubmit.
> > 
> > thanks
> > 
> >> 
> >> 
> >> Thxs, H?kon
>