Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220327121404.1702631-1-eugene.shalygin@gmail.com>
 <20220327121404.1702631-3-eugene.shalygin@gmail.com> <df43bce6-b1bc-1abc-307b-878ee7acb261@roeck-us.net>
 <CAB95QASgzUSaLjZuxWauiSvNK7Or=1Kz8htJcjWqU+HrRutvJg@mail.gmail.com> <fef5c154-2b1b-0a2b-52c3-c3fe0b4c2abf@roeck-us.net>
In-Reply-To: <fef5c154-2b1b-0a2b-52c3-c3fe0b4c2abf@roeck-us.net>
From:   Eugene Shalygin <eugene.shalygin@gmail.com>
Date:   Wed, 30 Mar 2022 09:36:06 +0200
Message-ID: <CAB95QAR+shnkC=QjmxYzdr69WuzW41aXmrGg-j7kfXM9+zGCuw@mail.gmail.com>
Subject: Re: [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the
 ACPI global lock
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     darcagn@protonmail.com, Jean Delvare <jdelvare@suse.com>,
        linux-hwmon@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 30 Mar 2022 at 01:37, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 3/29/22 15:11, Eugene Shalygin wrote:
> > On Tue, 29 Mar 2022 at 23:23, Guenter Roeck <linux@roeck-us.net> wrote:
> >
> >>> +/* Moniker for the ACPI global lock (':' is not allowed in ASL identifiers) */
> >>> +#define ACPI_GLOBAL_LOCK_PSEUDO_PATH ":GLOBAL_LOCK"
> >>> +
> >>
> >> That needs to be documented.
> >
> > Do you mean a note in the /Documentation/..../...rst or adding details
> > here? There is an additional bit of information on this identifier
> > below, in the ec_board_info struct declaration.
> >
> My understanding was that the user would/could request its use via
> the module parameter, so it needs to be documented in the rst file.
I see now, thank you.

> >>> +     if (!mutex_path || !strlen(mutex_path)) {
> >>
> >> When would mutex_path be NULL ?
> > When it is set to NULL in the board definition struct ec_board_info.
> >
>
> Are there any such board definitions ? I don't recall seeing any.

You are right, there are no such definitions neither in this
submission nor before. I'm messaging with a user who showed a hint
that such boards might exist [1]. We have not confirmed it yet, but I
thought this little test is obvious enough to be put in the code
already.

Best regards,
Eugene

[1] https://github.com/zeule/asus-ec-sensors/issues/19