Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 30 Mar 2022 12:37:20 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Shlomo Pongratz <shlomopongratz@gmail.com>
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrew.maier@eideticom.com, logang@deltatee.com,
        bhelgaas@google.com, helgaas@kernel.org,
        Shlomo Pongratz <shlomop@pliops.com>
Subject: Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check.
Message-ID: <20220330153720.GF1716663@nvidia.com>
References: <20220330140823.28826-1-shlomop@pliops.com>
 <20220330140823.28826-2-shlomop@pliops.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220330140823.28826-2-shlomop@pliops.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yv/G9BxWtr41aw+C1NIbPiYMRBoc+vr4PCzmQer4ayvjnDfIOIOSsbmn8wzG?=
 =?us-ascii?Q?p9x86HGu8WhlfzmqNC1gs8fOrYWQN3sSPo4XzYpchpfgkaaBP4iHcMLE0NEM?=
 =?us-ascii?Q?7JdSXA8ZwDjvjr2OQ/NkAYUtlit8yuG8rfLOEMxBbLEvCzp1zp3KApHm5Of+?=
 =?us-ascii?Q?V4VPrN14HdC7/bVMPpjOGR1PbTOGmY9cD6yTxeklmvjhj36CE8B92/ZbTyKk?=
 =?us-ascii?Q?EHDA366Mz5oTFK5CZccF3GBx9RvdQj8ONXUsoR0xcppFge7zUOijVS2pd7x0?=
 =?us-ascii?Q?Sbcq6WlSwMW8BtNExDoQX9L9dGd9oBrSfMHOLCpm5AKmzoX6R1R8HSaYVgo+?=
 =?us-ascii?Q?1b2ZAoxg+O2nrDUOSmjVJucZLTZ79ysmdEoWzpdg8IMg1UdCKva+1iFbW0nc?=
 =?us-ascii?Q?VzYIs0df4keqEVvA7QZQh/Of1En4jD2dEknNYLoPX5qBo/i9Gkx33av9V03e?=
 =?us-ascii?Q?s4Z6nOe/giBfk8Oxvawi804VAi2Qlygfzp7EnlHMFm7og4R/WoVq/Gbemsf6?=
 =?us-ascii?Q?C60ocgqolIolDdHeHLfqgfKzwhd9T0iMrOqvDZm02MeJF1dw/u6IOEwLDp0X?=
 =?us-ascii?Q?HGEKfNeXWv8QTb/Grc2EWMjQpf9xJkpIy25GTH+mOQOvlt9QZidj4ldEtQQB?=
 =?us-ascii?Q?RyIwYX4MC5WwRiIbYExxHPnEoYDECD+BOPHshwRxQSYO1tuh3u9MQYC2ECuT?=
 =?us-ascii?Q?udYDd5LMJJVBo7938cCshQa0LgswdP+xPl3q+yK5pW+ffolo+yQV1A7iRB0B?=
 =?us-ascii?Q?D+Z4UmgyofojowctSsxE/iFIRyPIuesp/H+deWmgwBgSLAGggpbfVDWRPYww?=
 =?us-ascii?Q?6K83ovy+1yaSWYswC3rx3pySf9nUY3NVmgEKofzwt9mIWG00xo/kbxkK4jQD?=
 =?us-ascii?Q?ecdMQBgtMlev+coTxW+YGGl5sfdXk+9sDTBsycflDvd0Krwmved8/cSw/Lo8?=
 =?us-ascii?Q?JFoZGw18wjfJPMALAP7h5OrELDw+tiQZRFv2+71aBAIpNA9l4jr9KbJtW6wp?=
 =?us-ascii?Q?8Upj80iKUm8azUewAtFguU5+H9q/7ru9+zE335NRuVWiY3EmxGoxfG6AAE0h?=
 =?us-ascii?Q?A8VQrSoNNhJLX9M7ms4FWJLp4V5bzrYb6jQ4qTfrsJHtOWXR64013BLRN//+?=
 =?us-ascii?Q?jqQYi2t7H/3wsdjnhWgrxdMGjMhkPFc9PWgeO8ppQVTFZ1G4AgmIEkxmtbbL?=
 =?us-ascii?Q?Q8pbI5f2WiwePVqjgl8ckDh0nBncKBG92nj2HpsSm80b4ZXYWojqiAmKuJls?=
 =?us-ascii?Q?h8Qb4t73yxFioex6SaKZZY0e4aHPnyHZcU4c6NqtQEdTfZvdvAIyNiTA7bVf?=
 =?us-ascii?Q?kYR2mBOoxm3zsg5GimnCMBFp0yKw4yMiP9yYRKpcOt2DsPm+7b8KL477Cu01?=
 =?us-ascii?Q?b5oQnaaU+bhbCUJzyM6rcFBa12DqqLlZ8YFE0aNrkIW2bxlwhxsek4o0QVBb?=
 =?us-ascii?Q?PLkhx26mYU6MTj8iXiNN7llw9sPuaiqxMYBhCtVYymyEtfYwrYkltXQB9G1o?=
 =?us-ascii?Q?mbAYVJ6kVeXbHCf1rVy11FS3NElN0CqpJevnkEUMHHlAgyTOsV2BAz4IzJ5M?=
 =?us-ascii?Q?GPuT+Sd+UioJseKlkdQ8+GGbfIIGF3lB18bzkZkbtPEyzrBqQO17d+W4eXJq?=
 =?us-ascii?Q?598Lgv8z01VWjsHV/jElstHxYr5Wqn++Vzb6/shWh/zO4zYHPS7hzaZGBj6s?=
 =?us-ascii?Q?MacQmppfa6aCXYYnAEi9TShLh3IhsfLEAnCiVI8cQDEJeJJInzuudgGOMPrf?=
 =?us-ascii?Q?RY5me50tqw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15dace27-fcdc-4331-7a01-08da12632e32
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 15:37:21.3406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LFNJwH/Ms/GYVWd7w87kHV248SP9+APAuZ19vu4h/0cAO7Jlcgz5zZoGvRuWkl2N
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4836
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 30, 2022 at 05:08:23PM +0300, Shlomo Pongratz wrote:
> @@ -350,7 +353,10 @@ static struct pci_dev *pci_host_bridge_dev(struct pci_host_bridge *host)
>  
>  	if (!root)
>  		return NULL;
> -	if (root->devfn != PCI_DEVFN(0, 0))
> +
> +	/* Is it a host bridge or a root port? */

This is a better comment:

/* host bridges must have a 0 devfn, but some of the entries in the
  whilelist are root ports that can have any devfn */

> +	if (root->devfn != PCI_DEVFN(0, 0) &&
> +		pci_pcie_type(root) != PCI_EXP_TYPE_ROOT_PORT)
>  		return NULL;

Indentation is wrong

Jason