Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2225635pxb; Wed, 30 Mar 2022 19:56:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXEexNi7xQDNbp0WR1PEoBjRyv1Z5pxpTXE0tnoEnGRpdXsCWk9Rr/uT0BdmoCT14wrLKn X-Received: by 2002:a05:6a00:230d:b0:4f6:ec4f:35ff with SMTP id h13-20020a056a00230d00b004f6ec4f35ffmr3004087pfh.53.1648695380266; Wed, 30 Mar 2022 19:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648695380; cv=none; d=google.com; s=arc-20160816; b=ZnA59HNLbhRAGUFR+Zyrf64T+Z5dQXA5C/pfxiGal62rhFcSUk+R9NoKjlue72FTIj tQMm4WL6jrKt7iapJHLWPEq/Npp1yldAViauRUueUyPUjAJM6Nl9uHATwIUmeDcd7vPU Sj2/Zp3ZyxFFvTF+HZYDQ0pI64wCx2VijRqZMS6vaHSueTlbuEivBUqqLLvQyBEeSyVT IW0LyNkUAIGyk4M0Sd9AJGKllrJ3+qhm7wFnJu/Jeouv0qVZJ0OcMvOXk6hQWR4YnJSm krb+mwfXgyQMCYZY/5kAW3gkfn/cNsUPlDIk2bOgqosRgSKv3TcO3XxfYXXod6mw18c/ FxRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PCuBPF5hsRb/FMuxwZS7UpXV4qd0D79dqbvfk53dcbE=; b=EwYqPmhbeMHXKTnlUJXiSxnHxnj81OQ3N0DGelelbHaRDFIrn+za4n5P+Es5+Ru2Ic VgGROdA7oFw9i4SdTjc4AgER6+xl12E5l5zpCZc7a2Qa//XjDkXHwOesigZmTcq6vIph C9sfwuOO222BpaZ9pEtcv9OKf3I1t2jbpGVbPv9P3TJdvIDJ720nNB14sM8H78ZaKL9r JtkzeHLbSjS25L8cv4E0aiElUlD5QkJch7QEShphNnUvqU4VHFbgBstrSQphO7Hbj8sm e0aeguvKxWwVzlMeWDFbVfi/IkcR+NlwWgDc3FouARedOtw1ZhR6vgxHhqN16TIzGgyq 6hnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Ukr7Hifw; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id c16-20020a63ea10000000b00382274f6ae9si22906988pgi.589.2022.03.30.19.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 19:56:20 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Ukr7Hifw; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CE17D8F6C; Wed, 30 Mar 2022 19:40:59 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348409AbiC3PvY (ORCPT + 99 others); Wed, 30 Mar 2022 11:51:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348412AbiC3PvT (ORCPT ); Wed, 30 Mar 2022 11:51:19 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 984AB2E09D; Wed, 30 Mar 2022 08:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PCuBPF5hsRb/FMuxwZS7UpXV4qd0D79dqbvfk53dcbE=; b=Ukr7Hifw8pU5JfYiPGLkf7XKAM 0QeINXFlW1dVUv6yQ0WU0S7w1cKoH/5TDqRoNbK5IAtmT3sKbNl/daSTjjob/p/CeKCPZyYYLyb0L uVXHYJ91smhuSIXTRaExHdk/6wmhB+iLGkR0k/WoeDaS6duxaaBTbnFIezrxY3E5XyO39qQLJ2tIC iEBgjRN+fYwh9dpO5LMqGx12aO/ygCGO0F15BL6BXLfcvLezsbqiCjHyBawNW4c44Nj8Hd2A5dTJz UqP6oDboQrEY2rHdKNWhWMnf347LI7JT2kUIjoIFkyGIybDm7Kd61AvSJ1FqzX9XbrhgtaNH8dd07 aCk44OqQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZaZd-00GeeR-FT; Wed, 30 Mar 2022 15:49:29 +0000 Date: Wed, 30 Mar 2022 08:49:29 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: Christoph Hellwig , Dan Williams , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Jane Chu Subject: Re: [PATCH v11 1/8] dax: Introduce holder for dax_device Message-ID: References: <20220227120747.711169-1-ruansy.fnst@fujitsu.com> <20220227120747.711169-2-ruansy.fnst@fujitsu.com> <4fd95f0b-106f-6933-7bc6-9f0890012b53@fujitsu.com> <15a635d6-2069-2af5-15f8-1c0513487a2f@fujitsu.com> <4ed8baf7-7eb9-71e5-58ea-7c73b7e5bb73@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ed8baf7-7eb9-71e5-58ea-7c73b7e5bb73@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 06:58:21PM +0800, Shiyang Ruan wrote: > As the code I pasted before, pmem driver will subtract its ->data_offset, > which is byte-based. And the filesystem who implements ->notify_failure() > will calculate the offset in unit of byte again. > > So, leave its function signature byte-based, to avoid repeated conversions. I'm actually fine either way, so I'll wait for Dan to comment.