Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <3aa93449-6951-8085-f6a1-6739b6d515d9@intel.com>
Date:   Wed, 30 Mar 2022 17:10:36 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v2] selftests/sgx: Use rip relative addressing for
 encl_stack
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, Shuah Khan <shuah@kernel.org>
CC:     <linux-sgx@vger.kernel.org>, <nathaniel@profian.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220330222834.139769-1-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220330222834.139769-1-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWpsRGQ0SVRBbldxRk1lSkNpYnZEcVNRTlQ0UlhFa3REek92ODRuOUNoN0xZ?=
 =?utf-8?B?dWJoUmUxMitURno5aFJ2YTZjNW5uelozQjd4TmE2dDByMER0ZDZFSGpuWlVm?=
 =?utf-8?B?MEdWT2UyWGZ0WFBuVE5UV1JRTmlsQUlxZmpGNTBQcHhiaUE3LzU0UEYxd0Vy?=
 =?utf-8?B?MkdSbEdGQWRubXhDYlJNbjNTanVMcFhMQ0tSUzhsMmJBejhMZkY3TlpneUJM?=
 =?utf-8?B?eU9JTFR2cDdSUlZCWkRWNjUxVTNtTnFrUzB4dm54OHZIZnY4QWsyd2pSYjhB?=
 =?utf-8?B?M0ZackNYakVjeEtod25sbDB3TGJSdEJubG5wV0NnU29XbHZ4ckJ4VjRSN0cz?=
 =?utf-8?B?YTRNUG0vMzRvT00yOElxN01tQzduM1BmWVhFRHlVbm0wQ3RkU2NyaDN1T3hG?=
 =?utf-8?B?RFczbWNlWDU0N25rbGRoaFVHTTZnNDVoT0JDWVFyaHM1OWp0STZTcUlPaGRC?=
 =?utf-8?B?bVB0NnR6Z2JlZHhhR3BKRnlkRlN2YldXeWxSMnpma3BFN2E5NU91M0Z3MHBV?=
 =?utf-8?B?R0xHbExIQ1BRMlpES3JndnRRcDFrSkllald5M3BhM2tFZzJaLzFIa2Fwcy9U?=
 =?utf-8?B?L05VMGxYZmdNVHYvcnJpL0ZnbzllYWNNejNQZ3I0VklISU8vWGpNYmkzemFI?=
 =?utf-8?B?MGh6QW9TY2ZDNHFiLzFmZEpTQXR4T01WYnQvMkNoaThIUUR1K0FseEJuaVp2?=
 =?utf-8?B?bk1PeUdPaUVaMEpvcjFvZWxoRHErYTN6VHhUT2FoajEyd1UxRGloMzRXTDFF?=
 =?utf-8?B?Vk41VGFROGhOejVDS3lkT3FBeEpGSWg0bGpHb0pnODBRVDRoMWVtNmRjdTZI?=
 =?utf-8?B?RGFSWWpSMStaVElPVkpnTFdLZmhRMU1FVEJQeCt2Z2dBeEVNTS9ZY3JxY2h2?=
 =?utf-8?B?MEdHTUR3YTFUcU8vMlFpQWRFZzk0TEl0UjJINkZjc01CSG9rUDM4c29UNlN2?=
 =?utf-8?B?OVNYcFVhZ25QU3BnUkluQXNKU2lidklDaU1MV0pEdVcrTHJqb2xST013Yjhz?=
 =?utf-8?B?RVRoMktRYjRhVDQ3L1J3dE1MY200SFB6dCtVRGZhY3l4TEtrSGVoYUgwTTVY?=
 =?utf-8?B?dkQrZWJuTUJ6YXZ0V2pNNGxjQ0w1QWNTQWw5SEVpc0dXRzQ1Z3VhbFdlbmJ5?=
 =?utf-8?B?QktvQWZZcTAxSzQ3czlBUFp4ZC9JUVFBWHBKcC9TZFphUGxGVWNnSTE0NktL?=
 =?utf-8?B?L0F0MkM5N2xqdFJlRStNY1lWeEtkWjVsYWtheURTUHdUbFNmVlJqNVdBYUV3?=
 =?utf-8?B?UHEwUkRrN3BjSjdrMVdOd1NIZVY3b212LzVhWWNxdTVzdnBPMDgzdFhOZFcr?=
 =?utf-8?B?OENQOUJOWTdKWFoxRHJxRmwxOXl0eFhJajRQQ3RmTFhKVjVTK1FZdXdGQ2px?=
 =?utf-8?B?cDhxQjZZaGJEcEEzalEyOWNjT3RISWc4ZllsZlg2bzhOVTdsNEc3dXhVT25n?=
 =?utf-8?B?Ty9DUFhGNGpENzZFN29HRDNMNGFmR1drcmZpZE5CZGV5anJFc0xKaWF5Qytv?=
 =?utf-8?B?Nk1uY21IRzhYd2FpQUpVUDlSSHhPS3MxUkg1ZzM5V1RWNjFhVE5oNllkRWlC?=
 =?utf-8?B?YWhRb25ZaWk5UmVQZUtFc3NLWnJ6eFZTV2lrOFp5ZWlVSzdpcXF4a1NSbmMr?=
 =?utf-8?B?a0RtUTBYbS8vZmVBVk9SYW1SWUxNZWp4WllLYUV6bzdvSEM4dkQvc3pzQ3h6?=
 =?utf-8?B?bHpNTjBZVm80emd4VFZXRWFYR1lqTlp2UXFhUUkwVE1BSkt1aWRiaGx2ZnZL?=
 =?utf-8?B?UVFRbzAzNXlaRWhxNnltRFNuMXFVMkxyRGpUS3g3aEo4VFlvMG5vcG5uVHlK?=
 =?utf-8?B?TjVXSWl1cElDK3hSQjRQQURHOHgzYXRVb3RERXBGWW5sbzFrRHV0b2hTQi9T?=
 =?utf-8?B?Q0pnZStLa0YzRTdRSlRMU092bWFmR25zdXJmWXIyMTk2VlZVam96V0ZleVVQ?=
 =?utf-8?B?dmsxUGNRaGJjcE95clJ2bzlvSTd2Tll0Sk9QakFpSXIrZ1hRcFFjZHFiR3VZ?=
 =?utf-8?B?QjNlbWxoeU82YmdPR1czd2oxV3VwVWtwUUJBY3I5dFFrTm1URTByS2VDbUdT?=
 =?utf-8?B?ck0weFd3bDMzRFFNeFljdVNOdkNQUUxwZG96emVhRzdHZENCVFhSOWVJVzhV?=
 =?utf-8?B?OEx5ODR6T09Qa1FPZXZJUm1RMDlWYkl6Z3crL3BLWnZyeXFUZHdLNmMvcjho?=
 =?utf-8?B?OGRSSWhGMEI0UlBuaVJRQmpJMy9ubXZ2U0R6c09FcE50Q2VsTmJMeHNrWmRl?=
 =?utf-8?B?YmhjbWwycmJwM1A5d3JBUWhWalA4TjVOajJCWkl5UjJxRDdZUk5KL0dxNFB4?=
 =?utf-8?B?MUVWbEFtem52SGpnaE5SWkFPdmlGTjF0enBGR1k3YURFTDU0TFNGNXN5dk5E?=
 =?utf-8?Q?f0ueuy0FbfLu7muM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2025274b-d56a-447c-8776-08da12aae414
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 00:10:40.9761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m/WklIDdE8DPOy1LUKt/zV4GR3Px67FOXdMUzF5rYldiCVhIwPp1Yrpd9GscHiXLjtEBB9tXv7Q6B7q/OkxKlywHjovsuRHFzvwyVK/DNqY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4318
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 3/30/2022 3:28 PM, Jarkko Sakkinen wrote:
> Simplify the test_encl_bootstrap.S flow by using RIP-relative addressing.

It is not clear to me how this is simpler. At this point there is no
functional change (except for what appears to be an unintended bug - more below).
At this time the change seems more code utilizing subtle compiler features
to accomplish the same.

Could you please share more about your plans following this change? I need
to understand this better since it is also an area changed by the SGX2 testing
code.

> The compiler automatically puts relative addresses for RIP index addresses.

I was not aware of this. A comment would be helpful to understand the implementation.

> 
> In order to get a clean and tweakless solution, define separate entry point
> for each TCS.
> 
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
> v2:
> * Based on Reinette's example, make proper structuring with separate
>   entry points for each TCS.
> ---
>  .../selftests/sgx/test_encl_bootstrap.S       | 30 +++++++++++--------
>  1 file changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/testing/selftests/sgx/test_encl_bootstrap.S b/tools/testing/selftests/sgx/test_encl_bootstrap.S
> index 82fb0dfcbd23..cc2353f38bcc 100644
> --- a/tools/testing/selftests/sgx/test_encl_bootstrap.S
> +++ b/tools/testing/selftests/sgx/test_encl_bootstrap.S
> @@ -10,12 +10,13 @@
>  	.section ".tcs", "aw"
>  	.balign	4096
>  
> +encl_tcs1:
>  	.fill	1, 8, 0			# STATE (set by CPU)
>  	.fill	1, 8, 0			# FLAGS
>  	.quad	encl_ssa_tcs1		# OSSA
>  	.fill	1, 4, 0			# CSSA (set by CPU)
>  	.fill	1, 4, 1			# NSSA
> -	.quad	encl_entry		# OENTRY
> +	.quad	encl_entry1		# OENTRY
>  	.fill	1, 8, 0			# AEP (set by EENTER and ERESUME)
>  	.fill	1, 8, 0			# OFSBASE
>  	.fill	1, 8, 0			# OGSBASE
> @@ -23,13 +24,13 @@
>  	.fill	1, 4, 0xFFFFFFFF	# GSLIMIT
>  	.fill	4024, 1, 0		# Reserved
>  
> -	# TCS2
> +encl_tcs2:
>  	.fill	1, 8, 0			# STATE (set by CPU)
>  	.fill	1, 8, 0			# FLAGS
>  	.quad	encl_ssa_tcs2		# OSSA
>  	.fill	1, 4, 0			# CSSA (set by CPU)
>  	.fill	1, 4, 1			# NSSA
> -	.quad	encl_entry		# OENTRY
> +	.quad	encl_entry2		# OENTRY
>  	.fill	1, 8, 0			# AEP (set by EENTER and ERESUME)
>  	.fill	1, 8, 0			# OFSBASE
>  	.fill	1, 8, 0			# OGSBASE
> @@ -39,15 +40,19 @@
>  
>  	.text
>  
> -encl_entry:
> -	# RBX contains the base address for TCS, which is the first address
> -	# inside the enclave for TCS #1 and one page into the enclave for
> -	# TCS #2. By adding the value of encl_stack to it, we get
> -	# the absolute address for the stack.
> -	lea	(encl_stack)(%rbx), %rax
> +encl_entry1:
> +	lea	(encl_stack1)(%rip), %rax
>  	xchg	%rsp, %rax
>  	push	%rax
> +	jmp	encl_continue
>  
> +encl_entry2:
> +	lea	(encl_stack2)(%rip), %rax
> +	xchg	%rsp, %rax
> +	push	%rax
> +	jmp	encl_continue
> +

The code duplication (xchg and push) is not needed.

> +encl_continue:
>  	push	%rcx # push the address after EENTER
>  	push	%rbx # push the enclave base address
>  
> @@ -84,13 +89,14 @@ encl_entry:
>  
>  encl_ssa_tcs1:
>  	.space 4096
> +
>  encl_ssa_tcs2:
>  	.space 4096
>  
> +encl_stack1:

Stack grows the other way so by placing the entry here the stack of
TCS #1 will clobber the SSA of TCS #2.

>  	.balign 4096
> -	# Stack of TCS #1
>  	.space 4096
> -encl_stack:
> +
> +encl_stack2:

Here the stack of TCS #2 will actually use the stack of TCS #1.

>  	.balign 4096
> -	# Stack of TCS #2
>  	.space 4096

Last page will be unused.

Reinette