Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2227059pxb; Wed, 30 Mar 2022 19:59:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzleP1ArS4/kvkZbW3nxEN8jm6jH8jT5OduNJq5A6M1YDWV7JGDuLqVVWHUBnNNqzin3eDu X-Received: by 2002:a17:90a:a78d:b0:1bc:d11c:ad40 with SMTP id f13-20020a17090aa78d00b001bcd11cad40mr3417657pjq.246.1648695577600; Wed, 30 Mar 2022 19:59:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648695577; cv=none; d=google.com; s=arc-20160816; b=LYkSQ0sHnjvR8XAhNrRS6f7q1JaI1jAOdUCUC8T0NShFu7jv2BJNjGOQNG2ZzHh3oQ ksoi5nqlHs/FwZgWjtfrU/tmae8nZCJUTGQMT2foOdabOvHkkUET2JojHRRMIsX/Jn0d RKn2nw7xWvo7q2gGdkWHdM16Eo0t5B6hhR60H8Zcus9GxAmjL9z/xt+1cW2AacOjVVAi e6OCR9LOcW4ITJlUZRC3XVq1+bgyY9aqArnBionLWHoiYyc0mlWWzV84V7lbvOsoAUh9 Juq9JkyoA/slJtJxv5K/K7au0gNIW0BgOlrpWw0UE9L3L1VeEyvyOXZTkzV0Y1xILpGp y7Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aTlBduJWRw3cHmb9OlXgOv86CBvz4je+2vgh7wGvDRk=; b=knxXCpCDDiJ+560p+qtEyi7jAkQrxncI/sx6FyeOmVzw+rufKJZ+gQ1sh7LDc/D+xh KnTCbBzOnjohB8lIlEtl2Mnj3cTPk7dSirZ9yOusmVja4SRBvP4TlmrmhIBZFmHm03pE fq2rhPHRI7wFTQS4Ug5ETjMAtooNYSoY8/sdLYXLJNv0oSeMu3/9mflN2Q77jR5kUoFP d7O0OnEIYoqjAJKX+rux10lcCtIIqPeizc3YjADAOj3IqZ6T7IQPvcB+jnK21UeCZGGe x4APTJNnDQVsiREKKJzRGQc3whNDrgHX8JxSyZDImhQbqtxIyWNLy8BlHJ02Eu2yy4lX j74w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qL9r9Yws; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n4-20020a654884000000b0039845840ff2si14650502pgs.41.2022.03.30.19.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 19:59:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qL9r9Yws; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ADCEAE33B8; Wed, 30 Mar 2022 19:42:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348007AbiC3QUC (ORCPT + 99 others); Wed, 30 Mar 2022 12:20:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238269AbiC3QUB (ORCPT ); Wed, 30 Mar 2022 12:20:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E872DE001; Wed, 30 Mar 2022 09:18:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A6608B81D6E; Wed, 30 Mar 2022 16:18:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51A51C340EC; Wed, 30 Mar 2022 16:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648657093; bh=cjFQuqoRMfu2TXAsiXRv9EQjKvH+MdFIXY9uc5fhIeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qL9r9Yws/hUGzKuvIFY+RbuwntrMSK4P43CyL2/dnXSTyynijAjGxTx5jk0MciJBS ZU3K1UIDqMzxA88epboJ1p59x5irJJj2JLdT3IY0tPJYmpTuab09WoUfTrxDR16Dfq r8N4tXQdQIaPnia1AslHnGmOplVqsKsaI34w3RLi6u1e7bfXjxM+6aYBDQb0MMyTSr YPN+3zKng+bKVx0qXsPftkro+4iih8aIVgkJzS6owkJGyF1RHMzDG9okK9EYv0u6/k DPUA6Xn7fDXsQPvseUvtae8Ads0cYctEDf9QDUz5BscGpr2wMHyw7xssUbm6ZRtK/f ndefofeH+jTig== Date: Wed, 30 Mar 2022 09:18:12 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Shiyang Ruan , Dan Williams , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , david , Jane Chu Subject: Re: [PATCH v11 1/8] dax: Introduce holder for dax_device Message-ID: <20220330161812.GA27649@magnolia> References: <20220227120747.711169-1-ruansy.fnst@fujitsu.com> <20220227120747.711169-2-ruansy.fnst@fujitsu.com> <4fd95f0b-106f-6933-7bc6-9f0890012b53@fujitsu.com> <15a635d6-2069-2af5-15f8-1c0513487a2f@fujitsu.com> <4ed8baf7-7eb9-71e5-58ea-7c73b7e5bb73@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 08:49:29AM -0700, Christoph Hellwig wrote: > On Wed, Mar 30, 2022 at 06:58:21PM +0800, Shiyang Ruan wrote: > > As the code I pasted before, pmem driver will subtract its ->data_offset, > > which is byte-based. And the filesystem who implements ->notify_failure() > > will calculate the offset in unit of byte again. > > > > So, leave its function signature byte-based, to avoid repeated conversions. > > I'm actually fine either way, so I'll wait for Dan to comment. FWIW I'd convinced myself that the reason for using byte units is to make it possible to reduce the pmem failure blast radius to subpage units... but then I've also been distracted for months. :/ --D