Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <1721b4cb-adab-4e5b-070f-c26d0e2c6bbf@amd.com>
Date:   Wed, 30 Mar 2022 08:41:30 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 0/2] remove DC_FP_* wrappers in dml files
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>, amd-gfx@lists.freedesktop.org,
        airlied@linux.ie, alexander.deucher@amd.com,
        christian.koenig@amd.com, daniel@ffwll.ch, harry.wentland@amd.com,
        Rodrigo.Siqueira@amd.com, sunpeng.li@amd.com, Xinhui.Pan@amd.com
Cc:     Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        Jasdeep Dhillon <jdhillon@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220326202448.2046077-1-mwen@igalia.com>
From:   Rodrigo Siqueira Jordao <rjordrigo@amd.com>
In-Reply-To: <20220326202448.2046077-1-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGovTC80Tlk4QlZLeHVRNnQ4TEFYcUczekFlUm1xTGd3YVRFTnc5dmlyU3F1?=
 =?utf-8?B?YU1BQVBXdzVwck9MQmtuTHhHZ0dxeGp3bE05RHhjUkpjS1JOZE1jVzYrcXdx?=
 =?utf-8?B?b0o5UDNxaFAvcGVLbXhQaXlIYWlpcDJzMk1qYWRCbnVGYndWR0V3SlZHZVhJ?=
 =?utf-8?B?c0QxSDZSMjd3blNqbDJLRk1CVEw1dmtQT1Z1YkMzamtBaldYVzdUUjlrVlhk?=
 =?utf-8?B?QzRUczhQTHdkemZVYnE5RlVsdW1XZWU4am84TDBuMkYydUc0WnlYOWZ0aE0w?=
 =?utf-8?B?djZFNGJPeFFkMCticksrWWU3cFhTQmNDM1RUejErSzJCc25ad3Y2V2k2MXlE?=
 =?utf-8?B?eXZtTDI3OVRManRCUHJERndRRFVaUFpCL0pBdTBmRmZzV0Nlc2lxQWpLa0xL?=
 =?utf-8?B?L1ZuYVFPekdWQnBJMW52OUpUSmowYWd1RXlPdis1MFN3WWlGM3hYbHVhcDdz?=
 =?utf-8?B?QzRmeDZQVTF2QVVNUmo1Z1pFUW04VC9NODZHODB6QjR0b050YjBIc2RUUTBK?=
 =?utf-8?B?ajFzTXRaMGMrQ0dVVWZFSHZlZEI4RGc2MkR0THc4MW1ES084SmtGa3g3clZX?=
 =?utf-8?B?MGV0MjJoZkhBelE1SDhxY0RVNTBpb0xxRzVMVnNKb256LytzclNoWUJSbGNm?=
 =?utf-8?B?WDc0RUEyQVBWTHVGRWxHMWxHLzdDdXFsWlFMTi9hbThOaDRHQVh1dWFSaEdl?=
 =?utf-8?B?L09yZWJmRFpRdjNsT1F4L3JiaS9OUWVRRWtiaW5reVREa3FGRjFISzRqR1ho?=
 =?utf-8?B?WFVXbjhxdFJ1Y1J2RFFmbmRhT0dDTXBuMTZBN1ArS2JzbnVBTHNjQmQvd0pu?=
 =?utf-8?B?L3hQNWlqK1c0alZYUE9JV1kzYUFKMWl1MnJpUlIrOThxc05ueVRQSFB3L09x?=
 =?utf-8?B?V0pFdHN5aEZxZU8zQlVPczZFcWhNYVRCU1hDTDlubmlwUnNjOGVCUTZhTElF?=
 =?utf-8?B?dWo0Tit5ZzVHVFNxREhUQXRjTUg4TTYrNG9sTDlFSFZ4UGtzUzg0MFFHSEdK?=
 =?utf-8?B?azJGUFArWlVRS1VBVHg0bElDZDVVR0NtUFdWVkU0V29YQ09lQnp1cHhrMElT?=
 =?utf-8?B?VVo5cU85WGowQ1lWemRPYzBPK00xYzZiTU1EejBQL3FHWnYxSmgyQ04wRUJY?=
 =?utf-8?B?NVd5a1lNcXYzb2NEb1ZEN3VvNHNiaDNvWHBnMWt5dzk0Z21rZVVwQWRHN0Rv?=
 =?utf-8?B?L28rOCs4MTg2Sk9nTGJWTHBuWSs5emNJcFFHQWJDRUlVT1VFMDZYbHBmaVZR?=
 =?utf-8?B?R21uK2s1T1UyaHMrdDV3RmFrL2FRSVMyNXV6QlVieWJzYVpObTNrSXc3c0dM?=
 =?utf-8?B?RnM3cWdNTi9xUEFyYkM5d1B5TENEajd3TUZFdFR2N1I3R1crbWE3bGpkWHdF?=
 =?utf-8?B?S0J6ZTdoU3ZMeHVjSEZnTXZYMzAyTEF4N3BlbDdMQlczQ3J1d2owNkdERC95?=
 =?utf-8?B?WTdvUmZmbTlwekRlZ3NxTGYzZmZXa3gvMHBvaHNESDI5TlFmODRQd3BEa2U5?=
 =?utf-8?B?SkRzZEpJdDV3bmJWWVVoWTUvL1VxcmtiVGx3R1BBakFtdENHR1ZDLytoL2ln?=
 =?utf-8?B?U0c5bFBxam5kTFBEd2pyaVNpbjAzOXhPaDBxcW95OWhqMDJTdGRvSlh1RWto?=
 =?utf-8?B?WlR5Y2E5a3pVaXQ5YzloUG4zZFRtcXBxVDF3Y3NaYk4vbVRteExlQ0VQOWJD?=
 =?utf-8?B?Nzc0VDBTNXdyT0pwMEs5c21kY0xuY0luRjBUS0JTcUkxNm00OWY0bWpJRmV0?=
 =?utf-8?B?cDF6a05kNlhUOG5xRkt4SENBTnQyVFo2UUJaQkRVd0tNM09oaXlaQkpPTzJl?=
 =?utf-8?B?T2dCTEdIVGJvVFg1Z0Y1bEVDalhPRnVGM2FmQWNaQ2g0UlB3SVdLUVJ5UXJY?=
 =?utf-8?B?VUNaVysxVGkxMGRUUzFscis0b0E0Sy9QMTdGY2Iyb05DQXdQVmlRRUZpOXc1?=
 =?utf-8?B?Ukl1OEdHK1RTNTQrQjVyOEdieHBRS2o4OEJ2MVBGL1ZnRlZWa1QzOWlrUGMv?=
 =?utf-8?B?dFJLdDI0K3hYWVVld3JqY2xZMjJ3TktnYS9hVDlFcGNjWkxncER6WU9od3Bz?=
 =?utf-8?B?ZEk4Uzh4aERTL2Zidkl0dFZ5MTlpYnZBczRFTXVGbnJGR2hkY2NLNGdQakQy?=
 =?utf-8?B?TEpFaFNnTWZKN1o4TmNQMUFBclNCVTF6TVY1TWVDOFNOSnREQytMMmJQa1Mv?=
 =?utf-8?B?VDZnZEd4b3l0RTJjRXNXTUY1ZkJsU09XRnhzUUV6Tmcvc3kzWEw0ZHhuMm03?=
 =?utf-8?B?cS80Q0ljYTRSQlYyaFhkSURDQWdtTUR2VU5uUTA3QVZ6U0tFUHc2T2ZaVUVs?=
 =?utf-8?B?RUZ0MlRHMTcwRzcyU0wvRXZkRHpRUHNaOUhVN2VLdXJ0alNkU3BiMXRGUkVT?=
 =?utf-8?Q?RCzYV2XW0nTFkdnqSeivk28p2ilq23u6gIgY+Hr8Msvbt?=
X-MS-Exchange-AntiSpam-MessageData-1: s9Q+llemLqZKPw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0874440-2785-4e6d-f08c-08da124a9ecc
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2896.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 12:41:32.8863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ksTA+OsywiJjjJxzNS6EFtcIqjSPUwTageuWwkPrArkqg0gzB9qv2TVR5h3LCwvePs7gIdFIj+dZcUwNgL0CLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4295
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-03-26 16:24, Melissa Wen wrote:
>  From FPU documentation, developers must not use DC_FP_START/END in dml
> files, but invoke it when calling FPU-associated functions (isolated in
> dml folder). Therefore, the first patch renames dcn10_validate_bandwidth
> in dml/calcs to dcn_ for generalization, declares dcn10_validate_bandwidth
> in dcn10 - that calls dcn_validate_bandwidth and wraps with DC_FP_*
> accordingly. The second patch removes invocations of DC_FP_* from dml
> files and properly wraps FPU functions in dc code outside dml folder.
> 
> Melissa Wen (2):
>    drm/amd/display: detach fpu operations from dcn10_validate_bandwidth
>      in calcs
>    drm/amd/display: remove DC_FP_* wrapper from dml folder
> 
>   .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 10 ++++++++--
>   .../drm/amd/display/dc/dcn10/dcn10_resource.c | 16 ++++++++++++++++
>   .../drm/amd/display/dc/dml/calcs/dcn_calcs.c  | 19 +------------------
>   .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c  |  2 --
>   .../gpu/drm/amd/display/dc/inc/dcn_calcs.h    |  2 +-
>   5 files changed, 26 insertions(+), 23 deletions(-)
> 


Hi,

Thanks a lot for your patch!

I reviewed and tested this series and lgtm. Applied to amd-staging-drm-next.

Btw, I agree with Christian. Can you try to find a way to add a 
compilation error or warning if the developer tries to add DC_FP_* 
inside DML?

Also, about the question of recursive calling to DC_FP_*, it should be 
safe if using DC_FP_*.

Thanks
Siqueira