Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9e6abf4a-cf5c-05c9-b179-b863ef53f35f@gmail.com>
Date:   Wed, 30 Mar 2022 19:38:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent
Content-Language: en-US
To:     Alison Schofield <alison.schofield@intel.com>
Cc:     outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220330153100.5813-1-eng.alaamohamedsoliman.am@gmail.com>
 <20220330170936.GA1176693@alison-desk>
From:   Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
In-Reply-To: <20220330170936.GA1176693@alison-desk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On ٣٠‏/٣‏/٢٠٢٢ ١٩:٠٩, Alison Schofield wrote:
> On Wed, Mar 30, 2022 at 05:31:00PM +0200, Alaa Mohamed wrote:
>> Fix "WARNING: suspect code indent for conditional
>> statements (16, 32)" for line 1240
>> founded by checkpatch.pl
>>
>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> Hi Alaa,
>
> https://kernelnewbies.org/PatchPhilosophy
> Please take a look at the section on "Patch subject formatting"
> and the follow on sections about checkpatch descriptions.

I will check , Thank you

>
> Thanks,
> Alison
>
>
>> ---
>>   drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> index 14d37b369273..46e18a90529f 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> @@ -1238,7 +1238,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
>>   		/*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {
>>   		/*  if we raise bBusyTraffic in last watchdog, using lower threshold. */
>>   		if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
>> -				BusyThreshold = BusyThresholdLow;
>> +			BusyThreshold = BusyThresholdLow;
>>   
>>   		if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
>>   			pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
>> -- 
>> 2.35.1
>>
>>