Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 30 Mar 2022 16:38:32 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Logan Gunthorpe <logang@deltatee.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Shlomo Pongratz <shlomopongratz@gmail.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrew.maier@eideticom.com, bhelgaas@google.com,
        Shlomo Pongratz <shlomop@pliops.com>
Subject: Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check.
Message-ID: <20220330193832.GF2120790@nvidia.com>
References: <20220330153720.GF1716663@nvidia.com>
 <20220330191017.GA1700536@bhelgaas>
 <20220330191145.GE2120790@nvidia.com>
 <671cb318-5f4e-4372-d0ef-45be83bdf0b9@deltatee.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <671cb318-5f4e-4372-d0ef-45be83bdf0b9@deltatee.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ms8JsAHo1mbCZGsQf1A+hroUTGLn94iGTUzTPEHTvNPCXGy0B32G/pP3Uy2M?=
 =?us-ascii?Q?hGfp0cFT7hwpaJeIyWpflKZnKSxZociyRI60tIMDuGp7vc28txm9NkH1QE8n?=
 =?us-ascii?Q?CaTXzL9UkcrFgySbV90wrHa7TrQ6Nuh0BZTN0p5hi/HniYqvdoWRkJ8znOVK?=
 =?us-ascii?Q?mUTKTBo1jJN0zLR2Rnggq4Tu57UcnwEt20NKVRuJUkuVk4iY5f89pM1rpemn?=
 =?us-ascii?Q?tbsl9vKzQgOtvHWDSf1KE5P2tqJh9aX6RZ3l9prXUJRhhkOg0iclHjjjPP+n?=
 =?us-ascii?Q?QEVLbxX1TnonPcnwt3cSePL+Bu1eYsZ8MHgN19xnu4No+/s2vXNdhZfv8wRB?=
 =?us-ascii?Q?JmM6okL3qpRgIrXOILMfRmxZVsJt1k4mVz0ndHift+o34IRsnyx4pIO8qecs?=
 =?us-ascii?Q?cR92uUe/8Amoom1Rmc8w06Kw8M0sT9psuegOIFpmMcV9irre3obzxiJc0GPE?=
 =?us-ascii?Q?s7BL8Zljvqk8bJe3/Br4vHMCTsCg+TYKOeDcOgI9XlYFBm0cJDFt/pEXdhE2?=
 =?us-ascii?Q?PIs0VOsKnlcVgYG34T8utKUswg5xxw1K+xDpC1Kk270L0bJrcf0Kb3iKHxdK?=
 =?us-ascii?Q?R0A5RpCxRFaUM0UfGJcUCCWxW0aMq1BuTmCQU+Cac9JWRmAhs0tsag1ntd6i?=
 =?us-ascii?Q?wj3NHhmEicj9A3T1/xrwrOczIrrorrN8bekCSMK2MWSAH00wumKld1KN5G84?=
 =?us-ascii?Q?QdlvKMrWUzSwV329hGPZhtAGNEVjTJkqbL8w0AeR/UV9oTnl5Zqc4S3Oq2Tk?=
 =?us-ascii?Q?nZChZfbBKBPgKKhPvm0SQoEWawqSLZIkRGM0Y5vcqs64aU1dZq4qQch0cr9r?=
 =?us-ascii?Q?7IzMvUaM9qGYa/zIsuZ4uhrCA49iPEyoC0uoq3XQHq98MqNL5L34IZ0KaZII?=
 =?us-ascii?Q?UHFbhPCtf1Y/iTMFytd3OLUFu2R5PwQiyH5WgYdsglpGLkjRygXZwGH8aDk4?=
 =?us-ascii?Q?ha0N/GYUZw18H8k9d/ozSaudYoYunJSK/aCxeR8xLtA6+8JORnP30/rOrjpR?=
 =?us-ascii?Q?+gnACGVKImWZTWaakNSnwYwVFtnHglt3vjtvGj92mqsXMncbKKI/lnIucCt+?=
 =?us-ascii?Q?RovHnUPXd8r8x37gkfe0Dy1sRLlDIKSsrzGcNLPDbNNp9JkuhJgR7pX5CM07?=
 =?us-ascii?Q?88KOgUOCNFui8VYfRulN9pzxqZ9YPSlie5ECwHMCpaoRMerYhy1FP7tmylBc?=
 =?us-ascii?Q?r+7OmtasijpBjV93smy6oaklOXQgZXuG+xzVaX43oetHeh0ge7YN6p6zw8pa?=
 =?us-ascii?Q?8Yj/lg+UIpjzcGkOJY0BMBL4SnikXeybW/JZSfiDG2oAF+616dDnfB6klJWX?=
 =?us-ascii?Q?lwJKNkmiBIw7kuLOpEoGyJTuIxrkoIc9oDKWJHPLwHtCewYdGvtqmWyBHU3W?=
 =?us-ascii?Q?mRcJP0BI1NmeBp/lArP3SOwyqnuhOXxQBIPqgK5VI2LpYqS11NrAKWFNGECj?=
 =?us-ascii?Q?r8XUrG3b5kR3Xpe+20fyE8IApbZsi0RYSmy1Qb5+CpZ1oEzrSHmPeScz/dCl?=
 =?us-ascii?Q?ZzonmqNAYhWwCVo/bJZYhKEuHixUrzAAfP/wK6zXjYW239FhwB89k7BdFXEn?=
 =?us-ascii?Q?NFbG7+2KtJ+3R/PVJIHJwI5IAaCVlH9ct/dp1E+cp8gfJLKAcAh0cGnDA+hI?=
 =?us-ascii?Q?vU3qggCP8J4qfU+mFuGOCBojNG6MhaBexg8dxDVSYzBGs0mS0jsfAvFU9Q9l?=
 =?us-ascii?Q?3QIB3elKKZdtvBXaNf7Iy6+OzCZ4L4nMZC0AavdTvifCLg1MrInrJjUf0gRV?=
 =?us-ascii?Q?NS4eMHrW8Q=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2159fe5b-c28d-4fc2-5aba-08da1284e0b4
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 19:38:34.3589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SXHP3+TG/Uz+EtLXjIUO4DPk0FCOWAix+s3yMZk3UMcBvoe+PU5cUsEam7I0bd0m
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3148
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 30, 2022 at 01:36:25PM -0600, Logan Gunthorpe wrote:

> Checking simply for PCI_EXP_TYPE_ROOT_PORT instead of a zero devfn is
> probably a good idea, assuming it works for all existing systems. I'd
> expect it would be set for all the devices currently allowed.

I think if we find a PCI ID in the white list as we go up the PCI
hierarchy we should just declare success?

Does it matter if it is the top of the tree or if it is a root port or
host bridge? The IDs in this list only exist as part of SOCs, so
seeing them at all should confirm the whole SOC..

Jason