Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2239145pxb; Wed, 30 Mar 2022 20:21:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0MspPqatxC5o3aIHdiNLO03ebY/DJ+1oGBX2mA7BMmOqfTIl+oxB93w/HsGT8OSEc8mSO X-Received: by 2002:a17:90b:2308:b0:1c6:96f9:8d0 with SMTP id mt8-20020a17090b230800b001c696f908d0mr3652847pjb.127.1648696894334; Wed, 30 Mar 2022 20:21:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648696894; cv=none; d=google.com; s=arc-20160816; b=yUaIAepZ6yYwIlwzEceUk1fPQ5A6A16mElZmb3LPrmcelOBq//pVnRNexdIGTBaxzi RWod8N9hUtpojf3ly752TnWJCyME+bNTZHqH15r6eEEsEWGzpyZCtoxc0MxF2qydrVUL IV1OzSL2xf1vNsBYJY4YlF9nzSZ/iqZ5CzqvFhFUk7mzBSTnkij0XRKuVDEEdztMMztr /bhHH36MPurlwMh40Ynkr+7fZJsoRlcQLmrLCj/+Y6nNspS/j1pJ8jkCwQJIBi3OKFzJ fBGAGjpjwufslIvXh5mwmPz+nmERkGooSzQHE16C/jMhd4LyPDw/TXafHPyVzGfd5gq4 vTDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=DaR3MwFp8bDqlwUMKw41JbUHj/I2OKstsngLkvC3fEU=; b=X/npW3oK8ApfCBO1pWbZL+rxVYA2rRnNARLYkdkMfvx35+D5g7BH4P58k7K+KRWs/6 g9dTwp4zewi3O9oCmydZuEAXNxzqG+wOWHdvIdAmFco+71I3Yts+BTy420o0NfXRm+Sa B67/JNyL3XQTDo+1rSL24Eps9wIkCYGzJN6N5glt0jQTI6BikbAJn2JrdRZwnfAmUAi4 fcTro1sr4KS03aUPJnfFnuLbVSCBPNZUNll7I1nVcLHbFFCsKLg+02oAoawyvdV9PaqB SP8BosYokdYSRGw4v1EWuAu9yUYtGFioT/mOUrYDnCukoncvE0YalnEAHOTBnNpHM8RL 9GFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nR6ntNCh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m13-20020a170902f64d00b0015416a66ff0si23129120plg.145.2022.03.30.20.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 20:21:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nR6ntNCh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5875410E570; Wed, 30 Mar 2022 19:52:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352317AbiCaBde (ORCPT + 99 others); Wed, 30 Mar 2022 21:33:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiCaBdc (ORCPT ); Wed, 30 Mar 2022 21:33:32 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1474839A for ; Wed, 30 Mar 2022 18:31:46 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id b188so23874455oia.13 for ; Wed, 30 Mar 2022 18:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DaR3MwFp8bDqlwUMKw41JbUHj/I2OKstsngLkvC3fEU=; b=nR6ntNCh4/YAwUbhK2XuUXTQBF8F95GEVdVCBAlu5e1/zu2pXuFPiAqknf9j2X+mEC bciAcM17DbdUEAaR7zc27qebz+a2Z+EqjWa3xdxOmC9FV6cT+kZdibU0Cb57JJnIU3nA VTyTMjKlyMao2lNKvTAOCui00LY5xZir/rtz+ys1eu9u1rlWbjjo/Dlc1Cn3YTcQbnOX Pw64KTGFflLTOr/K+l091WVuxEhmvUw/JvX/0JRkcOur/nrPUZQ4nuNCfxR17oefO9QF 8QJHV7ZkyvcSOH6EzB5303y85qkSb0h4RFW20PbIZoiqt4y/YFIpEjNnexkpomXhu5F5 PiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DaR3MwFp8bDqlwUMKw41JbUHj/I2OKstsngLkvC3fEU=; b=Lu1JJHUOgI5rcrO3zIODA8fox01CGIf/IPd2sSAGftHBbzBgIgHztHwLTNQdDzHCLd Ajt6+IoydJJbE/jQO2wSjSdyP4FbrmX1h2aMdBjp61gwWbUDoIMBqeVxhIjGM5MnpXDP qXepxFyPBsl68UxT5JCWNnAp6sVh41FfZvNZ+uvG8dcLARdjYe+GsU+xK1e0q8PfQO/x 6rsYGpWeAwlkpdNeh8JRGTuSVBPArh7agdWEmIPSUK9Wnmqa233oPx1ldBaaurhiBExH iyLlsGydUcbVtX9vf8O3EHyDZkyVmKLqCd0N0gpmd4xg/cntZcAy2s2EkG5QvtMDR2R8 iTKA== X-Gm-Message-State: AOAM530aXNFUZVHFpUKuDU4n8QeU+6OnxW6WNoGaK6punWoZ9UyLuZBP Wsg0TM8pg3KA1A9cv8S9i8w9kg== X-Received: by 2002:aca:30c7:0:b0:2ef:8a54:c3c5 with SMTP id w190-20020aca30c7000000b002ef8a54c3c5mr1706517oiw.56.1648690305328; Wed, 30 Mar 2022 18:31:45 -0700 (PDT) Received: from ripper.. ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id b188-20020aca34c5000000b002da579c994dsm11213153oia.31.2022.03.30.18.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 18:31:44 -0700 (PDT) From: Bjorn Andersson To: Stanimir Varbanov , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: qcom: Remove ddrss_sf_tbu clock from sc8180x Date: Wed, 30 Mar 2022 18:34:15 -0700 Message-Id: <20220331013415.592748-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Qualcomm SC8180X platform was piggy backing on the SM8250 qcom_pcie_cfg, but the platform doesn't have the ddrss_sf_tbu clock, so it now fails to probe due to the missing clock. Give SC8180X its own qcom_pcie_cfg, without the ddrss_sf_tbu flag set. Fixes: 0614f98bbb9f ("PCI: qcom: Add ddrss_sf_tbu flag") Signed-off-by: Bjorn Andersson --- drivers/pci/controller/dwc/pcie-qcom.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 6ab90891801d..816028c0f6ed 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1550,6 +1550,11 @@ static const struct qcom_pcie_cfg sc7280_cfg = { .pipe_clk_need_muxing = true, }; +static const struct qcom_pcie_cfg sc8180x_cfg = { + .ops = &ops_1_9_0, + .has_tbu_clk = true, +}; + static const struct dw_pcie_ops dw_pcie_ops = { .link_up = qcom_pcie_link_up, .start_link = qcom_pcie_start_link, @@ -1656,7 +1661,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-qcs404", .data = &ipq4019_cfg }, { .compatible = "qcom,pcie-sdm845", .data = &sdm845_cfg }, { .compatible = "qcom,pcie-sm8250", .data = &sm8250_cfg }, - { .compatible = "qcom,pcie-sc8180x", .data = &sm8250_cfg }, + { .compatible = "qcom,pcie-sc8180x", .data = &sc8180x_cfg }, { .compatible = "qcom,pcie-sm8450-pcie0", .data = &sm8450_pcie0_cfg }, { .compatible = "qcom,pcie-sm8450-pcie1", .data = &sm8450_pcie1_cfg }, { .compatible = "qcom,pcie-sc7280", .data = &sc7280_cfg }, -- 2.35.1