Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
IronPort-SDR: aJb68MMyve/w9Xz/+XiwPniu2FZVI5Ku1Vk0bD8dgXZiOySck8dHB7DnJB0u+fmCTYpzQhTvr4
 AeVlPNfPc/KtDd5sw3d0qrfHpXJ7B7z3EgjGD9rVgGwjQ3Di+KzW3IN+50rc30RoFzq3GFiBZ+
 BCafZJJwQ82ju38jwdMFTlD3htgjQqKFURwZfC20TLGwfs0OCIlrjisFHynncXHAdtTQIXvW1V
 HUDmf1gV84gHzsqajsC3PPxQ8JHep3Kv6xHGK+qb8jGdVjo/17R+dtR1u1x4ZdzkYrtipReJw/
 MhA3Ix4WDuLdVifnaA4EPOSb
IronPort-SDR: sy4Z8T6u+cWAyNxu1tHO46HYcxKnl2nEUFXuuMr+hAyHSLxx8ATs4VcqxlJtktx+026XsGwHFe
 4yEEP/S6/SRkJszxhi509zz9uSNFiRi6CKngERD7nifS4Cmg0AwxDoZcnRmBEhdvwDAgAKZJw1
 +9UyS44+T27pP9tx8P0OlJFI/8O3Q4TxrA+o45FjYhoFrztaw8cFyQSWnQIbgiVheWDMFMkgbB
 rfUy5mcp3ziW46PRa0QYgxoCddyviosVaHt/9LiWT1i45AvSK8lf75aXnG90Q0R/MIZ2WY6plj
 +yk=
WDCIronportException: Internal
Message-ID: <98afa9c9-28d1-1147-2538-e8c0dfeadde4@opensource.wdc.com>
Date:   Thu, 31 Mar 2022 07:33:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] riscv: Ensure only ASIDLEN is used for sfence.vma
Content-Language: en-US
To:     Alistair Francis <alistair.francis@opensource.wdc.com>,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu
Cc:     linux-kernel@vger.kernel.org, anup@brainfault.org,
        atishp@rivosinc.com, guoren@kernel.org,
        Alistair Francis <alistair.francis@wdc.com>
References: <20220330214358.3409766-1-alistair.francis@opensource.wdc.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220330214358.3409766-1-alistair.francis@opensource.wdc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/31/22 06:43, Alistair Francis wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> When we set the value of context.id using __new_context() we set both
> the asid and the current_version with this return statement in
> __new_context():
> 
>     return asid | ver;
> 
> This means that when local_flush_tlb_all_asid() is called with the asid
> specified from context.id we can write the incorrect value.
> 
> We get away with this as hardware ignores the extra bits, as the RISC-V
> specification states:
> 
> "bits SXLEN-1:ASIDMAX of the value held in rs2 are reserved for future
> standard use. Until their use is defined by a standard extension, they
> should be zeroed by software and ignored by current implementations."
> 
> but it is still a bug and worth addressing as we are incorrectly setting
> extra bits.
> 
> This patch uses asid_mask when calling sfence.vma to ensure the asid is
> always the correct len (ASIDLEN). This is similar to what we do in
> arch/riscv/mm/context.c.
> 
> Fixes: 3f1e782998cd ("riscv: add ASID-based tlbflushing methods")
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  arch/riscv/mm/context.c  | 2 +-
>  arch/riscv/mm/tlbflush.c | 2 +-
>  include/linux/mm_types.h | 2 ++
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
> index 7acbfbd14557..4329fe54176b 100644
> --- a/arch/riscv/mm/context.c
> +++ b/arch/riscv/mm/context.c
> @@ -22,7 +22,7 @@ DEFINE_STATIC_KEY_FALSE(use_asid_allocator);
>  
>  static unsigned long asid_bits;
>  static unsigned long num_asids;
> -static unsigned long asid_mask;
> +unsigned long asid_mask;
>  
>  static atomic_long_t current_version;
>  
> diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c
> index 37ed760d007c..ef701fa83f36 100644
> --- a/arch/riscv/mm/tlbflush.c
> +++ b/arch/riscv/mm/tlbflush.c
> @@ -42,7 +42,7 @@ static void __sbi_tlb_flush_range(struct mm_struct *mm, unsigned long start,
>  	/* check if the tlbflush needs to be sent to other CPUs */
>  	broadcast = cpumask_any_but(cmask, cpuid) < nr_cpu_ids;
>  	if (static_branch_unlikely(&use_asid_allocator)) {
> -		unsigned long asid = atomic_long_read(&mm->context.id);
> +		unsigned long asid = atomic_long_read(&mm->context.id) & asid_mask;

It would be a lot nicer and less error prone to have a small helper
function for this, no ?

>  
>  		if (broadcast) {
>  			sbi_remote_sfence_vma_asid(cmask, start, size, asid);
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 8834e38c06a4..5fa7cc0af853 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -666,6 +666,8 @@ struct mm_struct {
>  
>  extern struct mm_struct init_mm;
>  
> +extern unsigned long asid_mask;
> +
>  /* Pointer magic because the dynamic array size confuses some compilers. */
>  static inline void mm_init_cpumask(struct mm_struct *mm)
>  {


-- 
Damien Le Moal
Western Digital Research