Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 30 Mar 2022 12:48:13 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Mohan Kumar D <mkumard@nvidia.com>, robh+dt@kernel.org,
        krzk+dt@kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, jonathanh@nvidia.com
Subject: Re: [PATCH] arm64: tegra: Enable hda node for P3737 + P3701
Message-ID: <YkQ1bWg00BSRV8W0@orome>
References: <20220325072141.28597-1-mkumard@nvidia.com>
 <f35537de-6352-e6db-b4a6-17b1ab96deda@kernel.org>
 <32e425be-5d78-e1e0-6ec4-70ea21895e15@nvidia.com>
 <ca18fa50-f63b-8131-07a2-8c44daed9f26@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="NWAujopaZLN2XilU"
Content-Disposition: inline
In-Reply-To: <ca18fa50-f63b-8131-07a2-8c44daed9f26@kernel.org>
User-Agent: Mutt/2.2.1 (c8109e14) (2022-02-19)
Precedence: bulk


--NWAujopaZLN2XilU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 25, 2022 at 10:42:17AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2022 10:31, Mohan Kumar D wrote:
> >=20
> > On 3/25/2022 12:56 PM, Krzysztof Kozlowski wrote:
> >> External email: Use caution opening links or attachments
> >>
> >>
> >> On 25/03/2022 08:21, Mohan Kumar wrote:
> >>> Add iommus property for hda and enable the node for P3737 + P3701
> >>> platform.
> >>>
> >>> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
> >>> ---
> >>>   arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 1 +
> >>>   arch/arm64/boot/dts/nvidia/tegra234.dtsi                      | 1 +
> >>>   2 files changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-000=
0.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> >>> index 34d6a01ee1c6..156d5d95fde7 100644
> >>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> >>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> >>> @@ -1751,6 +1751,7 @@
> >>>
> >>>                hda@3510000 {
> >>>                        nvidia,model =3D "NVIDIA Jetson AGX Orin HDA";
> >>> +                     status =3D "okay";
> >> Nodes are enabled by default. Why do you need this?
> > hda node status is set to "disabled" by default in soc dts file=20
> > tegra234.dtsi. The enable is controlled by platform specific dts files.
>=20
> Oh, surprise... why do you override nodes with full path? This is
> error-prone and makes any changes (like node name fixing) difficult.
> This should be overridden by label.

I disagree, though I admit that this is probably very subjective. In my
experience label references lead to completely unreadable DTS files.
We've had bad experiences with these kinds of references early on, so at
some point we decided to discontinue that method on Tegra.

Reflecting the tree hierarchy in board-level DTS files on the other hand
makes it very clear what you're changing and keeps the board-level DTS
quite readable.

Fixing node names hasn't been a big problem for us and any potential
remaining issues are entirely gone now that we can validate DTS files
using dt-schema.

Thierry

--NWAujopaZLN2XilU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmJENWoACgkQ3SOs138+
s6FfqxAAvx8RKOX8UrSmBNVLPEi9U5eGWSADof9pOxLubHzxMG9bFnJYazTUFEwH
TjxTzJVuUppJ5R9hXC2WlaTdu9q8McJhroEDIt5JFy0mkcolBgLNEY2m5KHY6pfM
j3Dn64dEgwyyFUq1OMyKuzKbJB7Qs1Iytfjga6vjP4646WLAi0t7Y0BZOa7mHzYN
EC3H3qGYOu25s0X9nrz0cQyWjrdxZfxr/MPLFc9dui4s9fNZ8dHLcKuzxDQmp/Gu
AZEvoHqtuSG3bAWGn5t1/KcUe966p92vKScLSTKZfjDb8VJmsa9WFatt/PbmGlXH
J4IwOpew/NM9vFjnrhrmPROyfcm4PPA6t8GHk0s9NOUSK5oFx76h1xQEk4b0lU3q
uixAvHHEUKYC29llaGqf67X3ko+BeCfo+edx9dz+jkRXgQoDxYuiGtuLco9n/8KY
4G/VzbNMC5Ct3a5wPNgjDxkr0717ygLyjWijClG5Zpxd01wPlV1CZAnCp3CVaUTm
gua6VJPUy7f4lXpUqUS51Wn2KUcLlKgU2GgggwwW/MWDc6yX4HFmhWO1bDGf46Z6
jzYW4VHvWtGODUnoHDRuh1dnOqswNs3IPtZK+mtluiN0p/m5GKXC9/txg7p5NZsb
5MBJIEmrPMpUZ4O5k/jsi6GXLnVBpFr3BPDHAZd7KeSVAwFJ/Fc=
=0Gj6
-----END PGP SIGNATURE-----

--NWAujopaZLN2XilU--