Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>
CC:     Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RFC v2 01/11] iommu: Add pasid_bits field in struct
 dev_iommu
Thread-Topic: [PATCH RFC v2 01/11] iommu: Add pasid_bits field in struct
 dev_iommu
Thread-Index: AQHYQy9/UVY7D5gKo0W74jOQFA9+b6zXgkEA
Date:   Wed, 30 Mar 2022 07:05:23 +0000
Message-ID: <BN9PR11MB52763DAEC605FD1B21EE4EAF8C1F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220329053800.3049561-1-baolu.lu@linux.intel.com>
 <20220329053800.3049561-2-baolu.lu@linux.intel.com>
In-Reply-To: <20220329053800.3049561-2-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H3oeZUhUjvU56xtLPLwoiEKGKlIJdiijkazk29a9Zp1Vovcb1MiATZF0cvab?=
 =?us-ascii?Q?5E8lYR/ZMJZAyVLTS4j3Mwh864aJMTqDe8r0W+rzruM4ydQ+Lb96Mc3AM+Cl?=
 =?us-ascii?Q?etDXs7B8jIrG28+ylrydDhdJXsxSMWQZVwaJAWazxM6cILnPNlTHp1A1cJyC?=
 =?us-ascii?Q?HRPSB5bD4zoCxHald8mRokg0zH6INFCJ7W8b2vxPswfv52pogqZR3TRPX8Gb?=
 =?us-ascii?Q?hW4lMFvMNHIBnw85pEcMjTCJdb9fpzKeqYGhKe3hZjmOqpc8OQqwCf/yUNGm?=
 =?us-ascii?Q?Z8TS0r++SaJ7oDAxTUHy9TqqMTgjF30ukU9MKX8LXDGvvKPe05srU0bEBzQr?=
 =?us-ascii?Q?uMbhAOInNKiXJD4Ns4cQSLQYdakw+82CsKNjlDCD3wXDPrH0su/oyP7dqBIs?=
 =?us-ascii?Q?IaY28pwESudIQ2CQTs+9Z2RR87z7NZtirjAp2rRzH+iB3a+R7+6qFJrP4ABY?=
 =?us-ascii?Q?55EcNJe5YjUSqLArXTUAlXxlr4zkjRJwDf+fIIDu/JSMZALgHIRiMFWMkErW?=
 =?us-ascii?Q?jwKXVuecWGU3CBjMdIe8kRIFGMSpvIoL0W0xTQUnfGGd1XLP+RZgyxi8QLao?=
 =?us-ascii?Q?1Zbe4mRwfzWcCvqNwBXFHzVYM5VILnKS/eXJFuGqLp0i5GhQQDqb7gxDlq0T?=
 =?us-ascii?Q?682rDbbb8pE1d6WLEe+b0tic/tijyrKk/UHPLEYN4+QGnNkFviuvVX7VbsNt?=
 =?us-ascii?Q?Xp7I6/HAYVefdSTPyWNRxRZrl4Q/9TLgpBQJLPjOit2AZGAk4F+X+Ayc6RyX?=
 =?us-ascii?Q?K0aTTIkvQXlzI48PDAvsPVZuTpV23AOu97vn9fuMyBvybOmnM0EShYiv+hIx?=
 =?us-ascii?Q?4ibkHWIbahYHafZtYBM0K1+pfJbtgFQXGqzdZVU5lWX8v4u28Nx/WpYUXydr?=
 =?us-ascii?Q?QT5GNVD01HANwMnDv6TRC/2/ABixMRHg0e/Fci1jDKVw3Yp2ovmQqxwB9viR?=
 =?us-ascii?Q?uenRmwkvgV018mxYZHE++5UjgWVm1M1HgBpjjR/9GX21LvE0xwoA5KPBF+pO?=
 =?us-ascii?Q?C4pfBHNJtWFRuPyy5asDffd8OAohqGqf8eCSkJ9FUUpIafpaDJBm8Yc1s1qP?=
 =?us-ascii?Q?gTNz/SvnW9DYwhptLM+Nr0/M68Qi550mvJIGBI5G8xZy+vppQu7O6O0wSIEp?=
 =?us-ascii?Q?VvBp0obsWsene4tqHxrDFsRHr/tzThRamlrDhxySsEIn0hFVpyhgI8eqi7af?=
 =?us-ascii?Q?QglxhjVt+Ge0SlDMIPE6TnELfP+yL/AJuuBrQf/mM3GsHFMUDtrvBfZ6nhJs?=
 =?us-ascii?Q?Vuatc0H7ZL7SLTP7fqYtqQ9W1254fp98OI5sPrXmPFHUZh2Q5pF+668lB84+?=
 =?us-ascii?Q?IFD3cuhh5FbKJznlY1h/XoaNHcjzLxO48iHNG43YqokDAiTag0NBG+WjMBod?=
 =?us-ascii?Q?cjXpQqZAZpdE9Eo0wwDmNHdVwIuNJZ7+iqow+i3QXU4CerF3HfiAinoCGFpV?=
 =?us-ascii?Q?bTPIpUJudLu2/8tTplcm9PbNWp50z0uiFZFOzq7Kq9owAoGLG9PI2sDW4Ufh?=
 =?us-ascii?Q?NPw1Mx/NAC4tTGJ7p/Vq1IIGLuWi7zxp6AWBsAgkWVKeH98QeSRQ8KUBrrLD?=
 =?us-ascii?Q?KMzuhRy0D1m1HRXaCiCDc0ErY9yJeee/0nCRAyHrrW2CV71Ebpj8qofR0Jxv?=
 =?us-ascii?Q?9H4buorjwwZOv0hjYXmzP2Y9k5WtqhFniBri/vzLXQq1Knp7rcGansEBv/Qi?=
 =?us-ascii?Q?OaHBYTqog7tcGkuviPB9pQ1OoQy9yUeoRCYIZLXGsKqbad/s9jjeejCtGl00?=
 =?us-ascii?Q?51MqTjAXpQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d627d143-72de-4c22-50f7-08da121ba8e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 07:05:23.1852
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3TT9ili6iravj2rY0XZ9IGvMkjv9RonNkpIAbvls+zVq31ylbXBDZRY35P5GV8//X5qc3KUdh9ZNCE21dj62Ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5207
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, March 29, 2022 1:38 PM
>=20
> Use this field to save the pasid/ssid bits that a device is able to
> support with its IOMMU hardware. It is a generic attribute of a device
> and lifting it into the per-device dev_iommu struct makes it possible
> to allocate a PASID for device without calls into the IOMMU drivers.
> Any iommu driver which suports PASID related features should set this
> field before features are enabled on the devices.

Miss a clarification for non-PCI SVA as discussed here:

https://lore.kernel.org/all/85d61ad6-0cf0-ac65-3312-32d0cdeb1b27@linux.inte=
l.com/


>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  include/linux/iommu.h                       | 1 +
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 ++
>  drivers/iommu/intel/iommu.c                 | 5 ++++-
>  3 files changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 6ef2df258673..36f43af0af53 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -368,6 +368,7 @@ struct dev_iommu {
>  	struct iommu_fwspec		*fwspec;
>  	struct iommu_device		*iommu_dev;
>  	void				*priv;
> +	unsigned int			pasid_bits;
>  };
>=20
>  int iommu_device_register(struct iommu_device *iommu,
> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> index 627a3ed5ee8f..afc63fce6107 100644
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -2681,6 +2681,8 @@ static struct iommu_device
> *arm_smmu_probe_device(struct device *dev)
>  	    smmu->features & ARM_SMMU_FEAT_STALL_FORCE)
>  		master->stall_enabled =3D true;
>=20
> +	dev->iommu->pasid_bits =3D master->ssid_bits;
> +
>  	return &smmu->iommu;
>=20
>  err_free_master:
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 6f7485c44a4b..c1b91bce1530 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4587,8 +4587,11 @@ static struct iommu_device
> *intel_iommu_probe_device(struct device *dev)
>  			if (pasid_supported(iommu)) {
>  				int features =3D pci_pasid_features(pdev);
>=20
> -				if (features >=3D 0)
> +				if (features >=3D 0) {
>  					info->pasid_supported =3D features | 1;
> +					dev->iommu->pasid_bits =3D
> +						fls(pci_max_pasids(pdev)) - 1;
> +				}
>  			}
>=20
>  			if (info->ats_supported && ecap_prs(iommu->ecap)
> &&
> --
> 2.25.1