Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "David Disseldorp" <ddiss@suse.de>
Cc:     "Al Viro" <viro@zeniv.linux.org.uk>, linux-nfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VFS: filename_create(): fix incorrect intent.
In-reply-to: <20220330101408.2bbb47ee@suse.de>
References: <164842900895.6096.10753358086437966517@noble.neil.brown.name>,
 <20220330101408.2bbb47ee@suse.de>
Date:   Thu, 31 Mar 2022 09:59:48 +1100
Message-id: <164868118815.25542.13263176689793254608@noble.neil.brown.name>
Precedence: bulk

On Wed, 30 Mar 2022, David Disseldorp wrote:
> Hi Neil,
>=20
> I gave this a spin and was wondering why xfstests wouldn't start with
> this change...
>=20
> On Mon, 28 Mar 2022 11:56:48 +1100, NeilBrown wrote:
> ...
> >=20
> > diff --git a/fs/namei.c b/fs/namei.c
> > index 3f1829b3ab5b..3ffb42e56a8e 100644
> > --- a/fs/namei.c
> > +++ b/fs/namei.c
> > @@ -3676,7 +3676,6 @@ static struct dentry *filename_create(int dfd, stru=
ct filename *name,
> >  	int type;
> >  	int err2;
> >  	int error;
> > -	bool is_dir =3D (lookup_flags & LOOKUP_DIRECTORY);
> > =20
> >  	/*
> >  	 * Note that only LOOKUP_REVAL and LOOKUP_DIRECTORY matter here. Any
> > @@ -3698,9 +3697,11 @@ static struct dentry *filename_create(int dfd, str=
uct filename *name,
> >  	/* don't fail immediately if it's r/o, at least try to report other err=
ors */
> >  	err2 =3D mnt_want_write(path->mnt);
> >  	/*
> > -	 * Do the final lookup.
> > +	 * Do the final lookup.  Request 'create' only if there is no trailing
> > +	 * '/', or if directory is requested.
> >  	 */
> > -	lookup_flags |=3D LOOKUP_CREATE | LOOKUP_EXCL;
> > +	if (!last.name[last.len] || (lookup_flags & LOOKUP_DIRECTORY))
> > +		lookup_flags |=3D LOOKUP_CREATE | LOOKUP_EXCL;
>=20
> This doesn't look right, as any LOOKUP_DIRECTORY flag gets dropped via
> the prior "lookup_flags &=3D LOOKUP_REVAL;".

Arg.. thanks for testing - I clearly should have tested more broadly.

I could leave the "is_dir" variable there I guess.
Or maybe the masking statement should be=20
    lookup_flags &=3D LOOKUP_REVAL | LOOKUP_DIRECTORY;
as that is a better match for the comment.

Thanks,
NeilBrown