Received: by 2002:a05:6512:2355:0:0:0:0 with SMTP id p21csp205469lfu; Wed, 30 Mar 2022 20:54:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4kcF49Sc6hI/ICX64RlVrE3nxlokWiruLmBw/gC5r7GBxlILbSHIG7sbkBI+5t/WWPQMw X-Received: by 2002:a17:902:b406:b0:14f:bb35:95ab with SMTP id x6-20020a170902b40600b0014fbb3595abmr3342525plr.140.1648698875246; Wed, 30 Mar 2022 20:54:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648698875; cv=none; d=google.com; s=arc-20160816; b=WcxqPyd4+OZfWS3pfjumFkGKiPKjLfcVlEH0450qgXvgbftDG9moP4nuRDeI4FFY9l Sv0Qg33JmvUsPP4PD+QF1Z6HD3pUtUTTljSE6AGp7MuMb+dDFNAAi8YRHAKGJ3LxiMOg mvhvd4L3KwkL+MQ6KHbB33HTl0jTq6GeY2TjgLDuykt14XCE2PJQ14eUGXULk4ZDG+6L OC+f/wsNHV3R63WKgGuqiz97vQLz1CRAfIXOBtwt/r/nUPDywQOLcbGkumNhzGwEPJyJ AHEQkBSHDnSrg4/77CoGqHJ2K9lO1nInKJIM3X+G0SnfEFN1LdQi9zXkSJNaaEgDuXYR fzVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g77oy+gPdBGk4yPSYswkH8e7FD2QKOMiROsxcTjErKI=; b=w7GSzV0cmY2oscetcJERgKOuDUoXYNvFSdvbUPTxt0zjrZCEtgawvR+4Pmg5yqsudy wMk8u34bGSOC4ZjHmKtpUWPPPR/klcJAeUQP2cEfwr8urFArsh0v1mEakJSth6YGEkeu spuGrVpE3bjcHxdZsfaVekcRalkPRtW26y/NVSGww2XgN7QIEcxkpLQl9Yq6ViMc+kC9 iitmayVqQdPLMQwIUyK/Hkl6WboGHVOpxZAy115Zq7jHLmtFI63TZ+ZBOAeImM4BuI1r JGD3cULsXKmgKUYB719x5Vx2E4TpTpHPHDvL4AgAw4F+hlT6Tr+50ds5heChBQmTX/9C R5VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QQvNJAel; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y6-20020a17090322c600b00153b2d164bbsi25316046plg.195.2022.03.30.20.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 20:54:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QQvNJAel; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 18B2B15CB54; Wed, 30 Mar 2022 20:06:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244788AbiC3JZE (ORCPT + 99 others); Wed, 30 Mar 2022 05:25:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244785AbiC3JZC (ORCPT ); Wed, 30 Mar 2022 05:25:02 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A5A025D1; Wed, 30 Mar 2022 02:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648632198; x=1680168198; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=y23RIbKwqNxa/t3JcK6RsI/UqNmh00039XVrepKkUTs=; b=QQvNJAelTiUxF5Hpe6RPejOaDI9CLM6E9w1Jf7luynXu8b68nCM1nz3h ym7ehqWp6KVLAhPlW0irO7hB50uxmybbCCehBwzj7jT6jGBKgyVAQ1snZ ZrMx0Nj6W2EuuyugOzz87yWZCOvmvf4e5VGSFdFmjpYGvaiAxjSZNSM/w rrmmaQvK6Ch32/m1gkSUwbW/3pENCywSr/9pkshfM1Ob6MdJOSgvwDlMD j5hQ6rLDjF2tGOVg84IU0pyRQXImhIAoaYyD3rV8p4v6BSHnvgjJSJOMA QFZU7q1uBKZogx0IHapbcvVuGa+8E5J1CYprznT6QJf0PDjhe6BKpEjPJ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="284403013" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="284403013" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 02:23:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="519609463" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by orsmga002.jf.intel.com with ESMTP; 30 Mar 2022 02:23:13 -0700 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 22U9NCcO004547; Wed, 30 Mar 2022 10:23:12 +0100 From: Alexander Lobakin To: intel-wired-lan@lists.osuosl.org Cc: Alexander Lobakin , Maciej Fijalkowski , Michal Swiatkowski , Wojciech Drewek , Marcin Szycik , Martyna Szapar-Mudlaw , "David S. Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH intel-next] ice: switch: fix a braino in the new dummy packet match definitions Date: Wed, 30 Mar 2022 11:20:46 +0200 Message-Id: <20220330092046.2727362-1-alexandr.lobakin@intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's a trivial mistake[0] in @ice_dummy_pkt_profile due to which it incorrectly states that "plain" TCP IPv6 packets should match on the flag 'inner IPv6', not the 'outer' one. [0] https://lore.kernel.org/netdev/PH0PR11MB5782637EA9771D3ED4E56012FD1E9@PH0PR11MB5782.namprd11.prod.outlook.com Fixes: b5c7ae81ff90 ("ice: switch: convert packet template match code to rodata") Reported-by: Wojciech Drewek Signed-off-by: Alexander Lobakin --- Tony, please squash it with the mentioned commit on applying. Thanks. --- drivers/net/ethernet/intel/ice/ice_switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c index ed7130b7abfe..496250f9f8fc 100644 --- a/drivers/net/ethernet/intel/ice/ice_switch.c +++ b/drivers/net/ethernet/intel/ice/ice_switch.c @@ -1276,8 +1276,8 @@ static const struct ice_dummy_pkt_profile ice_dummy_pkt_profiles[] = { ICE_PKT_PROFILE(udp_ipv6, ICE_PKT_OUTER_IPV6 | ICE_PKT_INNER_UDP), ICE_PKT_PROFILE(vlan_udp, ICE_PKT_INNER_UDP | ICE_PKT_VLAN), ICE_PKT_PROFILE(udp, ICE_PKT_INNER_UDP), - ICE_PKT_PROFILE(vlan_tcp_ipv6, ICE_PKT_INNER_IPV6 | ICE_PKT_VLAN), - ICE_PKT_PROFILE(tcp_ipv6, ICE_PKT_INNER_IPV6), + ICE_PKT_PROFILE(vlan_tcp_ipv6, ICE_PKT_OUTER_IPV6 | ICE_PKT_VLAN), + ICE_PKT_PROFILE(tcp_ipv6, ICE_PKT_OUTER_IPV6), ICE_PKT_PROFILE(vlan_tcp, ICE_PKT_VLAN), ICE_PKT_PROFILE(tcp, 0), }; -- 2.35.1