Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20220303125627.93930-1-d.glazkov@omp.ru>
References: <20220303125627.93930-1-d.glazkov@omp.ru> <20220303081428.12979-1-d.glazkov@omp.ru>
To:     Denis Glazkov <d.glazkov@omp.ru>
Cc:     dhowells@redhat.com, "jarkko@kernel.org" <jarkko@kernel.org>,
        "jmorris@namei.org" <jmorris@namei.org>,
        "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        "mkayaalp@linux.vnet.ibm.com" <mkayaalp@linux.vnet.ibm.com>,
        "serge@hallyn.com" <serge@hallyn.com>,
        "zohar@linux.vnet.ibm.com" <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] KEYS: fix memory leaks when reading certificate
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2996112.1648654634.1@warthog.procyon.org.uk>
Date:   Wed, 30 Mar 2022 16:37:14 +0100
Message-ID: <2996113.1648654634@warthog.procyon.org.uk>
Precedence: bulk

Denis Glazkov <d.glazkov@omp.ru> wrote:

> The `exit()` function usage produce possible memory leaks. This
> patch removes the use of the `exit()` function and adds memory
> free in case of a negative scenarios.

?

Barring a kernel bug, there should be no memory leaks from exit().  _exit() is
the ultimate process cleanup tool.  Calling free() won't necessarily return
the memory allocated by malloc() to the kernel.

Unless you have a good reason to actually tear down everything, just print a
message and call exit on error in little helpers like this.

David