Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Zi Yan <ziy@nvidia.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        David Hildenbrand <david@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>
Subject: Re: [BUG] Crash on x86_32 for: mm: page_alloc: avoid merging non-fallbackable pageblocks with others
Date:   Wed, 30 Mar 2022 17:25:28 -0400
Message-ID: <AF9D3EF9-B070-4ADE-A2D3-C466A4A2D125@nvidia.com>
In-Reply-To: <20220330165337.7138810e@gandalf.local.home>
References: <20220330154208.71aca532@gandalf.local.home>
 <CAHk-=whz_8tRNGCr09X59nMW3JBzFLE-g-F-brxd+AkK+RceCw@mail.gmail.com>
 <B7789993-75EC-4F74-B4E6-AF1CC2CBD9D4@nvidia.com>
 <20220330165337.7138810e@gandalf.local.home>
Content-Type: multipart/signed;
 boundary="=_MailMate_BA3F1FA9-3595-45EA-AFF3-25218BF01ED9_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlhJNHB5RTJSWlYxcHdMYWM5UGIrbjRXRytRZkNhbUZsdlVGY0kwZVJrNTA2?=
 =?utf-8?B?RUdNUy9LUVA0Ulk0M1YyUStSTWhNTDlLL3ArSDNlcGlJZE5ROG1qbTR0dWlr?=
 =?utf-8?B?N2VKbHl0MnJRNlNsNmxaMTNqLy9FN0ZHb2JRODBNWDJwdXVwbElwZ1VSNzZT?=
 =?utf-8?B?N3dYL1VsQ2luOWVjbU5MQWlGUHVkRElubEViQnp4c1Z4Z0hBaWQ3ZUJqUXlE?=
 =?utf-8?B?R0oxemFjT2ZObEJHdkFCVzVmZWtkVThxT3VMN014eHkxT05IQnJZa3hrOFll?=
 =?utf-8?B?ekxnbEMvaXlPWm00Q1E5L0xLVEpIQ0FDUjJSV2Q4QVlReXllakNYMjE1aXVn?=
 =?utf-8?B?ZTc2YTJkYktaSDRKTmEwOU1KcnQ5dlB6U0RLT3NJMVBFcm9vd3U0Wkk5M2xr?=
 =?utf-8?B?akp2SGJrYitoQmRsS0duQW5Wc2tJbjJBQUZEL2FROWRyMjExWjBkMG9pQXM2?=
 =?utf-8?B?YkYvelNyQnlvWVp2OTl2KzFJek1NUGM0K0x3emF1b0k4a2pwV3JBSkJ4VDJ2?=
 =?utf-8?B?S0ZYeFFSbVRZZVJMd3VtNUN2N1VEd2QxTE1SZFRKRnhHR0JpNVF4MDFNNUJ6?=
 =?utf-8?B?T2JRSmlJcGh5eS93MGh1QTJGdC82NTdRMVc4UjdvVnBwMldNajU4T1RUUElZ?=
 =?utf-8?B?QXZITElzalBUbm9XTVFmSytNWGJXVXBFVnlhVlQxeHpQbzFrM3Z6aGpxVG9M?=
 =?utf-8?B?bEVCVkNGY2c0eGxlVHNXbkh4R0Z2NTZ2c0FBNEFIYlYwS2JWK3VtSk1wRnF2?=
 =?utf-8?B?YzJYaEhXUmNHT3NGYmlZZUR6SFpFdzVEWU0rSXlnMldheXlETEQ2MHYvZjJu?=
 =?utf-8?B?cnVQOXNmQWQ5akhhWlEwOC9nUldZWXg2K0tPZUxVWklvbW1wQjNiNjBsQ3lY?=
 =?utf-8?B?TmZ1SVNEVEtJK2NVempJTloxc1RMODlLVEFSUk1XaXlnZFNXeHprdlRJMyto?=
 =?utf-8?B?R08xVUFJYXdtZVFHU2t3SHRMN2ZxYytzSUZnQis4VlVKemp4Wk1SNzlwZXND?=
 =?utf-8?B?cjJCSVJWTEV5cC80MHlLamFMZEJuR3NSVWZtZXZ5TUtPOW5VRVpIYkwzY1FS?=
 =?utf-8?B?NjlWWGtVbDVlTUhDV2VkNVRITU9ibkZIWU50dTloQ2lGNWZJY01QU3JlQkpm?=
 =?utf-8?B?Nm9CeVk1aGhBYitna0hxM2FyQlM0VUNkRTJ4Qi9jaVB3ZWxMRVc3bEFiTENp?=
 =?utf-8?B?eEFGWkNzeERCNmhSeHJDaFVHQlI3R292MGs5Yml2Q1BJOHVSd2VYTS8vaG1G?=
 =?utf-8?B?T0F0bklKdmxwRUxEbEFFdndEaC8rRGhOd1BRcXlpUUxiZUVnOURhV3U4OHhi?=
 =?utf-8?B?L1ZrREloTjNoelIrajlBY21DVWRzcWloMGRkRTRUaUR1c1ptdzlXbU1QYi9s?=
 =?utf-8?B?djFRbjJwMzNOeDgxTDg1N1l5Y0xxd3FMcm5pQ3FoaVRtSE9QUXpXN0xsSlpJ?=
 =?utf-8?B?Q1MwZ2RLemtTd0I4MDF2d3J6TEZMbnhRL1lmZERZc3JVMFkzOEpqd3BydDA3?=
 =?utf-8?B?Umx0eTFsUVh1WGtaWWNKZkV3NFJXVGJacFRPMnNJMlc1L1FESFU0K2tFYm1r?=
 =?utf-8?B?d1VaK2VUallaY0xTVzFjcFBranJnZUFmT0JkbjludDlDVnl6V3B2d01TbHVn?=
 =?utf-8?B?UTJlMWZDOVJsSERva0crd3NBNkxHVEFTVHRCUUNiRUpIZ29HVTE5QU53Y1RD?=
 =?utf-8?B?L1lRaXRUdWNwSjU2aldqOWhQYm5xOUJLcC9YN3lIbTFpNjdrZnRmR3l5TTkr?=
 =?utf-8?B?SnlBcEZEMGNJVHRNNUR0VkpVR0w5MGNkSHdRT2JTMDJDTUtUL01uemF0eFhp?=
 =?utf-8?B?c0FxSlBzb0VkYW80dnJGT0N5YStZNEk0dkIrTW9hT0xuVHhrY1ZGSHNxbjBZ?=
 =?utf-8?B?aXNJTDNHM0xFcFY1UEJnL3B3NHhZdDhveUFFZGVTa3NBdmxWNkNIWTNRSFUx?=
 =?utf-8?B?ZHNhN0lzSlA4V0VWelR4ZEROUmpFUWwxcDhRakZKOThiTDhKM0NMaFVkanZF?=
 =?utf-8?B?clNmODJBRng2ZzVkRWdtSDhEdWdITnpsME9VSkZtVU9FNFBaS2ZOWWRFcXNE?=
 =?utf-8?B?aURtRVdkK09HL09LamNxLzE2QlZZV09JRW0rQ2JkS3lzb0JHc1podW1FYTd1?=
 =?utf-8?B?d3NVRHE3KzBubFQycHozY2FPRnRmUXcxS3JkR3NJNlhMSHR0aFNBSWdQYUZB?=
 =?utf-8?B?NE5vVzJsL1k5TGd5ekJmN0tXd202azlaWWNZUFhDbDArei9wMkozRno1VXRT?=
 =?utf-8?B?b2ZSQm9xSlNmRXBzMDRvWS8zREUzbDUrcWdJcE1hMXF0RDJMZVZldEpId3lG?=
 =?utf-8?B?Uy9zVnBIWDNhcDROVC9pZFZHaEZkTmxBZllRTkVPWDVEbm5rWHN4dz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 843e861f-e286-477f-4092-08da1293d0ef
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 21:25:30.2898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pqJrs2T4jNnFIdnv/5tdOxt+jIZ/CJJiL/XSeOItNXTa6KwGghbVEN83mIYPeNvI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3425
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_BA3F1FA9-3595-45EA-AFF3-25218BF01ED9_=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 30 Mar 2022, at 16:53, Steven Rostedt wrote:

> On Wed, 30 Mar 2022 16:29:28 -0400
> Zi Yan <ziy@nvidia.com> wrote:
>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index bdc8f60ae462..83a90e2973b7 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -1108,6 +1108,8 @@ static inline void __free_one_page(struct page *=
page,
>>
>>                 buddy_pfn =3D __find_buddy_pfn(pfn, order);
>>                 buddy =3D page + (buddy_pfn - pfn);
>> +               if (!page_is_buddy(page, buddy, order))
>> +                       goto done_merging;
>>                 buddy_mt =3D get_pageblock_migratetype(buddy);
>>
>>                 if (migratetype !=3D buddy_mt
>>
>
> The above did not apply to Linus's tree, nor even the problem commit
> (before or after), but I found where the code is, and added it manually=
=2E
>
> It does appear to allow the machine to boot.
>
I just pulled Linus=E2=80=99s tree and grabbed the diff. Anyway, thanks.

I would like to get more understanding of the issue before blindly sendin=
g
this as a fix.

Merge the other thread:
>
> Not sure if this matters or not, but my kernel command line has:
>
>   crashkernel=3D256M
>
> Could that have caused this to break?

Unlikely, 256MB is MAX_ORDER_NR_PAGES aligned (MAX_ORDER is 11 here).
__find_buddy_pfn() will not get any buddy_pfn from crashkernel memory
region, since that would cross MAX_ORDER_NR_PAGES boundary.

page_is_buddy() checks page_is_guard(buddy), PageBuddy(buddy),
buddy_order(buddy), and page_zone_id(buddy), where page_is_guard(buddy)
is always false since CONFIG_DEBUG_PAGEALLOC is not set in your config.
So either PageBuddy(buddy) is false, buddy_order(buddy) !=3D order,
or page_zone_id(buddy) is not the same as page_zone_id(page).

Do you mind adding the following code right before my fix code above
and provide a complete boot log? I would like to understand what
went wrong. Thanks.

pr_info("buddy_pfn: %lx, PageBuddy: %d, buddy_order: %d (vs %d), page_zon=
e_id: %d (vs %d)\n",
        buddy_pfn, PageBuddy(buddy), buddy_order(buddy), order, page_zone=
_id(buddy),
        page_zone_id(page));


--
Best Regards,
Yan, Zi

--=_MailMate_BA3F1FA9-3595-45EA-AFF3-25218BF01ED9_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmJEysgPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUuJIQAJZXnQfS7HSasI03ON7nskoLMx22gOAurHIM
Gk6j5YhPSeQWMEiI/zbM/oEPhs/L02O22gKzvDrmAYu4ocTkKijxR9a0NJjuoI88
oHx4iMN5xoVcUwRbUXoqjDDT9x1xft6ePdnFtctVroc+ZlyUMjHZjurnvydiN1T6
2YoUx2/eEsHZhQs8SRvtRrN09LusZv9HJDZit+y3WB1eMB6QTmOdBhJBrFkqB474
clNWGP+oikICTzeQ13zqiR0G8I4nzyIJHB8BdYz9m3oNo/1F871vLw4yedH5WosJ
FPBJOSalDhEZidUMD/1OzvKkQRlA0AFusv257EZJaIA33fzzqlA7yvVqW0eZAPZh
4kWPdAS9pKkrjNREO/lCQlTDe46379tLozj5+woAptlcCIZTlkBgsKR4nA3JHB49
+0KcRGIv5GLJmAbZi7PJC/KY9kKIrjKZo+mxvoOIYb7ycZa3/Zn43GBrSeMTAzJx
hNueeg0zONcp7lnZHXSCgWngJNcG0RDlHoK2fpB9Gvett9c9Ya/FASANX/uOnuQv
PIPe/zorqXB2QXscMtlVbX858XkurgVguXrcDppu329WxLp6ZZzHL5rnw6VErfBx
R+8hTEneJ7moYEZol8wTzn7e0E9bIkU/5VDwOSSxQk+HLFkpxOZdJYz+Mf8LVdXv
y0F6tNto
=7fuB
-----END PGP SIGNATURE-----

--=_MailMate_BA3F1FA9-3595-45EA-AFF3-25218BF01ED9_=--