Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 30 Mar 2022 10:17:59 +0200
Message-ID: <s5hwngbhn0o.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     tiwai@suse.com, kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Hui Wang <hui.wang@canonical.com>,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Kailang Yang <kailang@realtek.com>, Sami Loone <sami@loone.fi>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020
In-Reply-To: <20220330061335.1015533-1-kai.heng.feng@canonical.com>
References: <20220330061335.1015533-1-kai.heng.feng@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 30 Mar 2022 08:13:33 +0200,
Kai-Heng Feng wrote:
> 
> Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
> issue") is to solve recording issue met on AL236, by matching codec
> variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.
> 
> This match can be too broad and Mi Notebook Pro 2020 is broken by the
> patch.
> 
> Instead, use codec ID to be narrow down the scope, in order to make
> ALC256 unaffected.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
> Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  Fix wrong comparison, || -> &&

Thanks, applied now.


Takashi