Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <45acc349-8fea-f755-065c-c561949c45af@roeck-us.net>
Date:   Wed, 30 Mar 2022 13:02:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option
Content-Language: en-US
To:     Alistair Francis <alistair@alistair23.me>, lgirdwood@gmail.com,
        robh+dt@kernel.org, kernel@pengutronix.de, lee.jones@linaro.org,
        broonie@kernel.org
Cc:     linux-hwmon@vger.kernel.org, geert@linux-m68k.org,
        linux-kernel@vger.kernel.org, shawnguo@kernel.org,
        alistair23@gmail.com, s.hauer@pengutronix.de, andreas@kemnade.info,
        rui.zhang@intel.com, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-imx@nxp.com, amitk@kernel.org
References: <20220330094126.30252-1-alistair@alistair23.me>
 <20220330094126.30252-2-alistair@alistair23.me>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220330094126.30252-2-alistair@alistair23.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/30/22 02:41, Alistair Francis wrote:
> Add a specific MFD_SY7636A config option.
> 
> As part of this change we can use MFD_SY7636A as a dependency for all
> SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> it no longer needs to be selectable.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/Kconfig     |  1 +
>   drivers/mfd/Kconfig       | 12 +++++++++++-
>   drivers/regulator/Kconfig |  1 +
>   3 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 68a8a27ab3b7..74b60d24e740 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1693,6 +1693,7 @@ config SENSORS_SIS5595
>   
>   config SENSORS_SY7636A
>   	tristate "Silergy SY7636A"
> +	depends on MFD_SY7636A
>   	help
>   	  If you say yes here you get support for the thermistor readout of
>   	  the Silergy SY7636A PMIC.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3b59456f5545..c47cb755757b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1095,6 +1095,16 @@ config MFD_SPMI_PMIC
>   	  Say M here if you want to include support for the SPMI PMIC
>   	  series as a module.  The module will be called "qcom-spmi-pmic".
>   
> +config MFD_SY7636A
> +	tristate "Silergy SY7636A voltage regulator"
> +	depends on I2C
> +	select MFD_SIMPLE_MFD_I2C
> +	help
> +	  Enable support for Silergy SY7636A voltage regulator.
> +
> +	  To enable support for building sub-devices as modules,
> +	  choose M here.
> +
>   config MFD_RDC321X
>   	tristate "RDC R-321x southbridge"
>   	select MFD_CORE
> @@ -1202,7 +1212,7 @@ config MFD_SI476X_CORE
>   	  module will be called si476x-core.
>   
>   config MFD_SIMPLE_MFD_I2C
> -	tristate "Simple Multi-Functional Device support (I2C)"
> +	tristate
>   	depends on I2C
>   	select MFD_CORE
>   	select REGMAP_I2C
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 5ef2306fce04..c8ce6e5eea24 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -1219,6 +1219,7 @@ config REGULATOR_STW481X_VMMC
>   
>   config REGULATOR_SY7636A
>   	tristate "Silergy SY7636A voltage regulator"
> +	depends on MFD_SY7636A
>   	help
>   	  This driver supports Silergy SY3686A voltage regulator.
>