Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp14662pxb; Wed, 30 Mar 2022 21:30:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIno3acPTJ3QPbCNTMHKacqLr0n814ZXjtCjuOK4iiyP9TWb5rMool/ybRYZjmY8bhGmUD X-Received: by 2002:a05:6a00:10c8:b0:4fa:81cc:c86e with SMTP id d8-20020a056a0010c800b004fa81ccc86emr3241317pfu.23.1648701001081; Wed, 30 Mar 2022 21:30:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648701001; cv=none; d=google.com; s=arc-20160816; b=UyNgjet4xTdHyvI7Oz4NJ0UvImtrpGG7yEiCTXz83Uv4ORfIYNPRlkhU7X/HKYBOPR yxP9OrYDzFlJPzEfnGlQbx8rau+c2AZLSPcyDtfsB+EXoW4slF5WXIpSZZmIBqO+u6cR wBTuhiiIxW3w/wpkpTQCplhyNpNUxEH2aCB2CZt0nanjMChFRp2vcLF7H87XST2E+aHz jiRME01Bgr6N4eA8fsxyUrTNjryz7LY/YKs3LekDgjUYcwqkykYiazIhLN/SUXExqg85 Nb2ZxqGC6R73rWtjg7ccKWGOQXRzvxTv9wMz7ut0mf7fLuRBpfb/JcKZHhAYRra62cCd XE6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ShlAuSZLyEq25xAfycHWI7hECNIi/GQOtl1mtKw5Shk=; b=z5I3lHEoNpPmfnM4UT3TTMhMcThnUHhJTqQdshiv8GQyuVWtrciio323MINfK2MLB6 3RDX4tPH+VKvkk9zYR1QYmc2hOQr/1m5IGQr97s29qhbszc0A8UdcrolG99OLYJBEnq5 +qOVKQeLJG7bi4Z99Gl5rD4b7F8T1EfVb0sPPFieMbmL8f48Qijci+DXALO3zIv02HQX 6REhoAPIbrlHuBZemvhwMOmd5Ayrevsfqa7J1pCbGC0ChQvUIXBkRgQikj+j0viJlp8r oostugrLdElbBvYlmaNtgIJT27mcw98UPqs7tc7GTNzuZ97NAEkMsSirQ9lV6kOK+YED 7+OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hpQUdyyu; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id w23-20020a170902d71700b0015498a2b02bsi21103436ply.316.2022.03.30.21.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 21:30:01 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hpQUdyyu; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C608B1D4C14; Wed, 30 Mar 2022 20:24:12 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239771AbiC3FsH (ORCPT + 99 others); Wed, 30 Mar 2022 01:48:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243045AbiC3Fr4 (ORCPT ); Wed, 30 Mar 2022 01:47:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB60D25B931; Tue, 29 Mar 2022 22:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ShlAuSZLyEq25xAfycHWI7hECNIi/GQOtl1mtKw5Shk=; b=hpQUdyyucc04FsSCWb013XTcO0 y2GjL8gVriHew3MYCDqfR8ivlsTCoQ7g8whXxPt36DScOa0Zo6Zj9DDqJWWziGgLmYOJpAfGCm0qq BH77DEtEPOutPjLuav55+27+6J+YBCiF+PSdGg7AfoHRcx/iByOBAWfP1jvPNIXff6RArvYBV8qF0 xnpWDCU3i+zCa/FxT/6PAxeN2Nx5zkJXV7JD+75XSBZIxKikg3jWrTOOe6gDK1DULV3xnjxXMX0e0 h/JxGdqxaSEruRTcEV2rZgvsEtKc/eSNEqJKpEO88YBfEdbgpkV3cAsUYswOBVFv+kuRmz1KOt5Dn 0yyRSCjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZR9m-00EMtx-Iy; Wed, 30 Mar 2022 05:46:10 +0000 Date: Tue, 29 Mar 2022 22:46:10 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com, Christoph Hellwig Subject: Re: [PATCH v11 5/8] mm: move pgoff_address() to vma_pgoff_address() Message-ID: References: <20220227120747.711169-1-ruansy.fnst@fujitsu.com> <20220227120747.711169-6-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220227120747.711169-6-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 27, 2022 at 08:07:44PM +0800, Shiyang Ruan wrote: > Since it is not a DAX-specific function, move it into mm and rename it > to be a generic helper. FYI, there is a patch in -mm and linux-next: "mm: rmap: introduce pfn_mkclean_range() to cleans PTEs" that adds a vma_pgoff_address which seems like a bit of a superset of the one added in this patch, but only is in mm/internal.h.