Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ef991f0d-d0d2-f422-96d8-0951d593d2a5@intel.com>
Date:   Wed, 30 Mar 2022 13:05:03 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v2 1/2] selftests/sgx: Use rip relative addressing for
 encl_stack
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     Shuah Khan <skhan@linuxfoundation.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        "open list:INTEL SGX" <linux-sgx@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220322074313.7444-1-jarkko@kernel.org>
 <7b7732ec-c7ff-cf92-510f-64c83ed985cd@intel.com> <YkRvFkEO8Ic1VdQ8@iki.fi>
 <0031a4f0-75f6-3104-1825-dcc2528f61b0@intel.com>
 <f68d472877b7136c32d8770603a3de38de59c322.camel@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <f68d472877b7136c32d8770603a3de38de59c322.camel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aERUS2JNUUZURWNwQXdnMXR4SEFzdU9HczlSREVCTmNBOW9GbnBtRzlrdk5G?=
 =?utf-8?B?Y3BJUktvVnA3QTNYVFdLeklvZFpDb3krMWo3WmJBZ1l4dWJHSjI4WGtqaTVs?=
 =?utf-8?B?c1lqYzZnSnJhQUJWOUF2UXkwelMyaEJOUXNJU2Y0WWpRdldnWHpFUGJRZ3VW?=
 =?utf-8?B?a3RMVlZuZVZKbU1sZUZTZC9iZ1JDcGtFWTd6NXkvWG14RXVqYVg0eWZDQkFH?=
 =?utf-8?B?R1FVaGhlTmhIREdibXlCSUVNamVuZHE4ck1FdjNsYUwwL1ZLTnhxd3RMQTRo?=
 =?utf-8?B?d0JKUkxhd0p6cVhIdEQ5RzBMVEpLQllydENhb0pVOVNrQm9paWFHT0FKV0tE?=
 =?utf-8?B?UDh1MDhiOWc5ZzRiYUY3emFXL3hhN0ltbDBxQmF0eXRwY1VzNThBZFZvYmZH?=
 =?utf-8?B?U20xMU15QVNhcGlxYkxCN2lJNTJFaG04TkEwVkN2T1dKemhZWWtadmxHK2lz?=
 =?utf-8?B?WlZXVTRXallHaVlaMllsOEQ0YUtnNHYxUU5adUJzcTYyYW1FRXhpK3E0ajcz?=
 =?utf-8?B?b20yZWRMVEM4RDZBT0FsV0cybVMxOUgyRjZXLzV3c3dWRzdWRVhNd0tYVlF2?=
 =?utf-8?B?UUdJeDZPWHZIT0FtVU1HRlA3bnRUbCs4WmRpRkx4ellzeWpPOXlNNjBpRS81?=
 =?utf-8?B?V2I4UTY0Z0RoWmFvNVl6OS9IUnNkcHBQTmlLRHlEUmw4cUs1aDI2SUM1YVlK?=
 =?utf-8?B?TDRiUXphZ2REMHMzT3BhbkNEcHAzZmFkRE5WNTVPc09GdCs2eWd5QkxzVFNC?=
 =?utf-8?B?ZnZZYzRBSVFQUVU4Vkdvc3E4Ymd2NXczZTJIZG1aMDc4ZERCSk5tVGhScTFV?=
 =?utf-8?B?bnYvR3NQd2IvZ21LbVUvaFphUTNLL1JoaHJDNEsrcU5JRUtRUUFDWld3UGhr?=
 =?utf-8?B?aWhxSWVBT1ozTWRSMmtWTnRqdWl4NkJXcW1wQisxZExpQUVOWE1hcStPeERw?=
 =?utf-8?B?b1pSdkRjMWI1c0YvV0NLNXhieHBMcE9YL09rbFJsRlRVcWVWZm9jSDlabGd6?=
 =?utf-8?B?WGR0MldhZFNRY1QwNTRmTkVCQVdISCtiTGlMUGRnQUFvRHlFYVZWTGZpYjdR?=
 =?utf-8?B?ellOYUxkOVlYY1F2S1NIVVViRjVOMC9mSks5Q0hzTSttMDIzMmlUZC8yVmZ2?=
 =?utf-8?B?TVlEWFFxYjlrbTk3Zjd1MWIzdzVvdW1neGg3bFhMWGF5NmVpV2xYaE84K1BR?=
 =?utf-8?B?UDhSV1BlNnlaL1ZNWlFEK0pDVVFGMWZuRVdsMGNBQ2lST3MyQ2RyYk9oLzFk?=
 =?utf-8?B?Y0I2YkZwUEZIenRUczdqNThKWmt5UXhPOXJOZzh6dlVtMDN4SUlkbnhGUEV4?=
 =?utf-8?B?YlZIOUVOK1dBaHQ5WUxIZzcrcDRhWDFWdFhqYVd6TFpGM3MwMUNOVzd2d25h?=
 =?utf-8?B?dW1TUUNSS2VscWd0dW9ZUGdUejBrYWlsVExLYklpT1owMSt2ZUcwaWVMcmRR?=
 =?utf-8?B?L003bUQraHdjWmh6UzBvREtjWkorb0h0QWNoMit1OXd4eHBaR2ZXWmViUzZm?=
 =?utf-8?B?UEZicWlEcGN4QTArTDNoRmViVktwYnFReDlVdHI0cUFLdEoxbDExQ0dVOTBq?=
 =?utf-8?B?amNHb2tFUTI2OUdtNkhIbzhUMW90Y3NENCtBck5MQXZERVF3a2NrOFplRm1K?=
 =?utf-8?B?cmFoZ0lSYTBkOGNoVitGUkJTRnVQWFRhbWwzYU1HMUNNQXpXWXhjeDM0cVJ3?=
 =?utf-8?B?ZXpVMDVlTGlQUXZzKzVRYmJ3NCtPUlYyQWRZUXRWSURPNGtyMjl4Mkw3NUhW?=
 =?utf-8?B?Ry9GYWtsYVIzcEZRUW5UWHk1Z25VWURya0JVWk92bWJSK21PUXk1YWJTN0t5?=
 =?utf-8?B?UVV0Y3p2YVJYd0UxenJGQnBuQ2dWck92YXBFZlh5R3FHZ2tqcTJWMEdOQmhJ?=
 =?utf-8?B?eFU2TW9jSkpWZGZnK3R2cEdsU1hoMHpaMlNIWEF6Vm91Mllpc1BoLy9URWJ0?=
 =?utf-8?B?MHB5akJYU1AwWVlzLzBGemhENHZLUkt4empWTTRqSThvbEJrcVJJeFpibXZJ?=
 =?utf-8?B?VWZ4RldrR29Mamc5WlJUWThZaHZIblgva2pGRzFSWGFRSHhIblpGbkJoVmh3?=
 =?utf-8?B?UnM2OFRBL3JSZVdqSWtJWWJ6QTdYbGVhTlRkWGdzTW9hbzZBK2d6NXd4VEJJ?=
 =?utf-8?B?QlNGYnRtSnRUTW13a05qazF1azF6REJsWDBMUzFzRm10UWVad2lJSmFBRFVD?=
 =?utf-8?B?WGFXM1pMak1SZ2V6RDZ6YlJYM1RnMEg1ZHFRa1NFeWRZWGJITWRsaXRidnNU?=
 =?utf-8?B?T0s4eHNTWEdQeloyN3d5b3l4Y2V6K21PVFl6UVovUzRudU5rM0VHVGdMZWl4?=
 =?utf-8?B?N0czRW1waVdaR1Q3cTZObDhrWk1uZW1FT2wrZzBGRzJzbUhvcGtUTFFxMTEv?=
 =?utf-8?Q?JCfzV15NdoTMAxbY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac768b08-d53d-4801-23e4-08da12889630
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 20:05:07.3135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FWkuZp9Bo2gSbSjq+7eV8jJMzSmh1WBzRUm3TMFlcdeiVLFUCkRT2H8Hvaxa4fWkPRhXnAIDlLS9d5eG8ivEZ+02+unJO+zJFOt+zqIXaxk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4549
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/30/2022 12:03 PM, Jarkko Sakkinen wrote:
> On Wed, 2022-03-30 at 10:40 -0700, Reinette Chatre wrote:
>> Could you please elaborate how the compiler will fix it up?
> 
> Sure.
> 
> Here's the disassembly of the RBX version:
> 
> [0x000021a9]> pi 1
> lea rax, [rbx + loc.encl_stack]
> 
> Here's the same with s/RBX/RIP/:
> 
> [0x000021a9]> pi 5
> lea rax, loc.encl_stack
> 
> Compiler will substitute correct offset relative to the RIP,
> well, because it can and it makes sense.

It does not make sense to me because, as proven with my test,
the two threads end up sharing the same stack memory.

Reinette