Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 30 Mar 2022 13:15:13 -0100
From:   Melissa Wen <mwen@igalia.com>
To:     Rodrigo Siqueira Jordao <rjordrigo@amd.com>
Cc:     amd-gfx@lists.freedesktop.org, airlied@linux.ie,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        daniel@ffwll.ch, harry.wentland@amd.com, Rodrigo.Siqueira@amd.com,
        sunpeng.li@amd.com, Xinhui.Pan@amd.com,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
        Jasdeep Dhillon <jdhillon@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] remove DC_FP_* wrappers in dml files
Message-ID: <20220330141513.s6gw44gbh6whwqow@mail.igalia.com>
References: <20220326202448.2046077-1-mwen@igalia.com>
 <1721b4cb-adab-4e5b-070f-c26d0e2c6bbf@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="z7lxjmd4y3nsnzuv"
Content-Disposition: inline
In-Reply-To: <1721b4cb-adab-4e5b-070f-c26d0e2c6bbf@amd.com>
Precedence: bulk


--z7lxjmd4y3nsnzuv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03/30, Rodrigo Siqueira Jordao wrote:
>=20
>=20
> On 2022-03-26 16:24, Melissa Wen wrote:
> >  From FPU documentation, developers must not use DC_FP_START/END in dml
> > files, but invoke it when calling FPU-associated functions (isolated in
> > dml folder). Therefore, the first patch renames dcn10_validate_bandwidth
> > in dml/calcs to dcn_ for generalization, declares dcn10_validate_bandwi=
dth
> > in dcn10 - that calls dcn_validate_bandwidth and wraps with DC_FP_*
> > accordingly. The second patch removes invocations of DC_FP_* from dml
> > files and properly wraps FPU functions in dc code outside dml folder.
> >=20
> > Melissa Wen (2):
> >    drm/amd/display: detach fpu operations from dcn10_validate_bandwidth
> >      in calcs
> >    drm/amd/display: remove DC_FP_* wrapper from dml folder
> >=20
> >   .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 10 ++++++++--
> >   .../drm/amd/display/dc/dcn10/dcn10_resource.c | 16 ++++++++++++++++
> >   .../drm/amd/display/dc/dml/calcs/dcn_calcs.c  | 19 +------------------
> >   .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c  |  2 --
> >   .../gpu/drm/amd/display/dc/inc/dcn_calcs.h    |  2 +-
> >   5 files changed, 26 insertions(+), 23 deletions(-)
> >=20
>=20
>=20
> Hi,
>=20
> Thanks a lot for your patch!
>=20
> I reviewed and tested this series and lgtm. Applied to amd-staging-drm-ne=
xt.
>=20
> Btw, I agree with Christian. Can you try to find a way to add a compilati=
on
> error or warning if the developer tries to add DC_FP_* inside DML?

Yes, I agree too. I'll try to address it as soon as possible.=20
>=20
> Also, about the question of recursive calling to DC_FP_*, it should be sa=
fe
> if using DC_FP_*.

Thanks,

Melissa
>=20
> Thanks
> Siqueira

--z7lxjmd4y3nsnzuv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmJEZe0ACgkQwqF3j0dL
ehyvKQ//WM6GLxBSzGMkxkvL8lb+02tZyIMirq8fvaxe16llFJ3bLKadPHSMjweI
Ki2KG7wWM81D0bZHf4vw6TYLIZXMPhl11N4mgm+Y1LwWht+hHcLpvAJj8ClC2Hdu
9k+EiNiv2xH77QOHf8pHcWpvxLX18VU6iEnfXsu4E2qmo/tG4rtD/u4W2vdzzKfC
N0z5F8cftdoeJkuXDvzab/DGt/ejVsZNSZsc1uawxpIdK56C35t8Ya9ahA2IdRmm
eCNZLlOUUD1DCYaQ2MCV4+WkCB5VOXDf0TJ0iyuhUT/LkSE72wfkkKY6ompC1v/E
J5lqIDYnc3COlAUx3uXfal0lUWdr5eRGMAkllRDpCdS188355S5Rx0+S3pa9R46s
UcbZOVMxdaVV6aV7tsz0XT7V5Zfb5y5EyCTOQ8HXjkAk29xZgAU+yBQBIlWWeLq/
Oj9ER6Qqv3G20x2t2xYBGrdmhuOWbOLcD+XUdY56+jdiObJMmBXXZ2T1+2Zom/D+
1s9RCXlmop3wGsx8/InQuWEULjuOFBnay8w6llq2vGS0lx9scG0XW8HIir+nTubc
DkMfucxn8dTkAT+r61A9S2wo6POTAmY/xT38t6KVoM4pr5xsiPXZu12AWq09H82D
LR8TnWC6EYN8GKLlXcHbjZpGFOM2l5AhRZ8fs4yR1T3yJtmRAek=
=3gRv
-----END PGP SIGNATURE-----

--z7lxjmd4y3nsnzuv--