Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <5ba0e090-c1c0-b237-73ac-3eb4b007f5f4@gmail.com>
Date:   Thu, 31 Mar 2022 09:52:47 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] media: mc: delete redundant code in
 __media_device_unregister_entity
Content-Language: en-US
To:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220324102752.47077-1-hbh25y@gmail.com>
 <Yjx2Xm7JmS+E8d7M@pendragon.ideasonboard.com>
 <YkQ5ic2b/gaF8cF+@paasikivi.fi.intel.com>
From:   Hangyu Hua <hbh25y@gmail.com>
In-Reply-To: <YkQ5ic2b/gaF8cF+@paasikivi.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/3/30 19:05, Sakari Ailus wrote:
> On Thu, Mar 24, 2022 at 03:47:10PM +0200, Laurent Pinchart wrote:
>> Hi Hangyu,
>>
>> Thank you for the patch.
>>
>> On Thu, Mar 24, 2022 at 06:27:52PM +0800, Hangyu Hua wrote:
>>> media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to
>>> set it again.
>>>
>>> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>
>>> ---
>>>   drivers/media/mc/mc-device.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
>>> index cf5e459b1d96..7727c619043e 100644
>>> --- a/drivers/media/mc/mc-device.c
>>> +++ b/drivers/media/mc/mc-device.c
>>> @@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
>>>   
>>>   	/* invoke entity_notify callbacks to handle entity removal?? */
>>>   
>>> -	entity->graph_obj.mdev = NULL;
> 
> Removed the extra newline above, too. Applied.
> 
> Please run scripts/checkpatch.pl on the patches, too.

Thanks. I will make a v2 with this change.
> 
>>>   }
>>>   
>>>   /**
>>
>> -- 
>> Regards,
>>
>> Laurent Pinchart
>