Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c5341578-e0a6-4ad7-5b6c-95b31b16faad@nvidia.com>
Date:   Wed, 30 Mar 2022 14:33:47 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186
 onward
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        krzysztof.kozlowski@canonical.com, robh+dt@kernel.org,
        thierry.reding@gmail.com, digetx@gmail.com, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220316092525.4554-1-amhetre@nvidia.com>
 <20220316092525.4554-3-amhetre@nvidia.com>
 <04bb5ef2-15c3-d561-3572-76dc803275ef@collabora.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <04bb5ef2-15c3-d561-3572-76dc803275ef@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU1UR1BRQnhPRUF2SS9waEV3eE5aTFdwMGtHeGtFWjE1dlZzdTU3MHV5eHla?=
 =?utf-8?B?OFlXSDErd3ZFSmpKU3JCUDNGY1F5YWZRRXFxaEhZVTd5SmFjYzhtblZ6WE92?=
 =?utf-8?B?cjZ1V1dPY1pDeGZrK1Jod25WM1NKenJ3WVgxZzFITWVNZ1VpMmw0d0hIUnN2?=
 =?utf-8?B?OHNKdURITHhLaG1zSkUrY1ZTUDJVQlY2dXdLSVlwRmo4bUFoTkRqMEFCbmF2?=
 =?utf-8?B?eUsrdEdvNzlxY3RZS1ZlMWRpbzFDT0E0OFErYUxVRngzVEZ0S3RpVE1ydE44?=
 =?utf-8?B?ME1tTWlNaVZBeGxhdTk1MVdtZExUb0xMdDVTbmdwdmxVdnZvVHg5MEVjSlJZ?=
 =?utf-8?B?bzNGK1lncmVtMmFxOXp2b0FjcVkwdy9KVFNraVpLSFJEZTZ5MnBVcmdUSHZJ?=
 =?utf-8?B?ZSsrZzhtQkJYTFZGSG5YMEVQYWJnZzBOQ3M1MHQ4NDFRQ2NIcDRLeDUyRDRz?=
 =?utf-8?B?aHo2NW9adVlQdGRMZ0MrOWhreTRsMm8xbjllSXZzd292aytnM2lCTmx5ako1?=
 =?utf-8?B?b2hwZUNnZXBMTDFWdDVueENDdVVOV2pxQkJETFRaU01GWVUyM3N6TmpnT3R0?=
 =?utf-8?B?Z09hR2ZPWVhHQkV4SU1qZlVhMmhqa1haT1E5T2R0engzOGtKUk1qcm8yNW5C?=
 =?utf-8?B?MWs1VzhPbnlMekJ2WHFLL0lVazN0TytZMmNUb0dvVTd0c2FTTVhPREg1M2t0?=
 =?utf-8?B?R3FWdFQvZzMyZ1FjRkRHUnp1aXdQNjhINDZmYnlUYWxpVGhieVpGZU0rb3ps?=
 =?utf-8?B?Q2l1U1oyQ3BwbEV0U3kyTjJ3TE9oTng1VEM5ZmlvM2htSUNRMjNWUzFyRTJO?=
 =?utf-8?B?L2h1bXdTS202aENnckRla3IvSFl5YTlUQnZIbUJ4alJBbE5UcGdxRXR6d3hw?=
 =?utf-8?B?NVdtTWRrNjAzdjUwVEI1RUJ2WlkveEVhNmJyQ2xvUXBkSlQrVUJ0UVJGSEJH?=
 =?utf-8?B?SzYvQjh5MkR2NVRaSXVwc0lGdktvMHJqQXZmTzZHdHdLakF2NGNzbjRtUytS?=
 =?utf-8?B?TzJxRzVUTGk2RlVmMnBLdkVYMFhmWHF6UkNKK2NMUlBkQ044RzgvOW5RRU9Z?=
 =?utf-8?B?TzFmK08wK0QvNnJ1QUNCYS8yanBsK1pzazI2NHBpRFFqTkR2UTcxUnIramJl?=
 =?utf-8?B?QXE2Q1NiNmNuNDd3SGVZM2VxbnpuNXlrTG5udFgxLzVtcDNsSVcyaVhrd1c5?=
 =?utf-8?B?U2xQOUxZOTZ1MElkeTk5SDB6ckQwRU0yd2ZPS2hqU2tsTUpTR08xMjBqY0l3?=
 =?utf-8?B?REM1Y0pnU0RObGNXRzBMbGNjNmQyejJrU3ZnTTRWakhBYUVyVWk0bWxHM3RJ?=
 =?utf-8?B?NmIvOVYrQTI4VVlBbmorQU5URmRXNEtDNERIMC9DMkpZQTBxZ3YxTnRuZ0xV?=
 =?utf-8?B?UlpkaFRZUU4xQmdReC9POVB4MW5kM0oxK0pDNHpLUGpQa0p5Q21uV2JMM3Rn?=
 =?utf-8?B?R3RscGZLY1Vsck9wMUxYRW1yMGttWkN1eitaN1p0K2RGeWh5SFhnQmc3SFpE?=
 =?utf-8?B?SFVQN2hIbEhrVHRtZWx5dEJHT2FtZWtMZlBHaGJLRWVicElzcmMwK09hT0lZ?=
 =?utf-8?B?M3cwekJ4bkNIcnR2aGRUekpvTTZyQ0o5Z1BNOVhrNWNvZ3B4dmI1Vi8xdDky?=
 =?utf-8?B?Q2NvUnN4VXE2bUhpRjYyalpiUjRESzRNQ2p0Wk1xaTYzVHFlTGhoRytMWlBu?=
 =?utf-8?B?T0c1dm0xeVZiaTBKVWFhV0N3QlBITi9Kc01LOG9JQzZJNHVMOFFGeG95VzND?=
 =?utf-8?B?M05ObHpiZFlFK2U2NnBzTEIyVE9rN0lPZEt2WWgwVFVyV1E4SkdTbVlYOUJa?=
 =?utf-8?B?SngyWHk0U1MzRUNpVVp3OXZ5dmJoZnd1eGcxYzBVQW9HU05USVdjSHFnMUZw?=
 =?utf-8?B?NW85dTE0NGN4RGRkNUJ0aHJoMnVCN0ZzWU1SMFRQZzgxQ2lVVElhNTB3SDJZ?=
 =?utf-8?B?MVBVTmlGT045RW01cld6SDJCYk1iQ3lZeGk2Tm11R0pXR0l4S2JZQmhSWXBM?=
 =?utf-8?B?Zmx4RGptWGtabmJraGR2NjhDeENrZy9mdlIyREhhV1RBZjJoNWRlamh6dVpa?=
 =?utf-8?B?bmFueFJET1ZhOW5wOTJkc3JjZzZPcm5wa3NGRmpvSGdLY0lJN0lCZEdLMGs0?=
 =?utf-8?B?RGM5QXhWTDBkZGE0WjJMNGVmUVJTMWRHSlE5emp6dkxNSHBlR2l1WGVFbXN1?=
 =?utf-8?B?alFpR2R5UDlPK2tLL2V2TEJqZlZ0UFE3VTlOb005QitUZjBrZ0JEdHpqL01Y?=
 =?utf-8?B?KzJOVHVMSDZBSTNJOGdSd2p1Tm1qdENHdkM4Ry9Pdm5FUHpLeTYyY2o4MGtj?=
 =?utf-8?B?d1NDK2haV3Bqbjl2bXJGZS9FL0JOMHNSWkZZRWlQMHdpOWhwWjhWdz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cbacd21-9b39-4adb-5179-08da122c3b57
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 09:04:01.3379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gnXZvcjUY287wFC2heUE0k3vQoWpFERIclGDwEHGOg98RyIUiwxYuR3fpIqSXVOHHrCIa0SpAOsUY3Q7QiVJ7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3623
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/30/2022 5:36 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 3/16/22 12:25, Ashish Mhetre wrote:
>> Add new function 'get_int_channel' in tegra_mc_soc struture which is
>> implemented by tegra SOCs which support multiple MC channels. This
>> function returns the channel which should be used to get the information
>> of interrupts.
>> Remove static from tegra30_mc_handle_irq and use it as interrupt handler
>> for MC interrupts on tegra186, tegra194 and tegra234 to log the errors.
>> Add error specific MC status and address register bits and use them on
>> tegra186, tegra194 and tegra234.
>> Add error logging for generalized carveout interrupt on tegra186, tegra194
>> and tegra234.
>> Add error logging for route sanity interrupt on tegra194 an tegra234.
>> Add register for higher bits of error address which is available on
>> tegra194 and tegra234.
>> Add a boolean variable 'has_addr_hi_reg' in tegra_mc_soc struture which
>> will be true if soc has register for higher bits of memory controller
>> error address. Set it true for tegra194 and tegra234.
>>
>> Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Reported what? You should add this tag only if patch addresses reported
> problem. This patch doesn't address anything, hence the tag is
> inappropriate, you should remove it.

Okay, smatch warning was reported on v4 of this patch which is fixed in
v5. Then I understand that we don't need to add Reported-by if we fix
bug in subsequent versions, right?