Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
To:     shuah@kernel.org, akpm@linux-foundation.org
Cc:     Sidhartha Kumar <sidhartha.kumar@oracle.com>, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: [PATCH] selftest/vm: clarify error statement in gup_test
Date:   Wed, 30 Mar 2022 21:52:57 +0000
Message-Id: <20220330215257.112029-1-sidhartha.kumar@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g9RHHRWfB1XaotkPFPqa3Tc/E7IswmZUNeQj+r3tBqCJ8BQ66j5PBgyJqNsY?=
 =?us-ascii?Q?kydKO+VZt6CxfR1DRe2353SsoePsgOp+h7Zm9RlczOOW35OfQf83i0YHJTlo?=
 =?us-ascii?Q?t2Iqk65IB3yLIJ5oyEEDTXXjQLrhfiKv/bWZ+NbIxwWhCAYT9o5v9yiXxrmR?=
 =?us-ascii?Q?lnH+RN36qoYKEDBUMlJ2MLLVynzkj5/u4ZdK/r/0tBO81r0fwrIP3gvfP0Y4?=
 =?us-ascii?Q?CqzNP+rI9TVxMIsOrAgf1FwuaFWDHPHxt6/SH+aDbufzCLbMdd/mrqVnb1kQ?=
 =?us-ascii?Q?ZLb1eTQQdyv7He9hsAVpnKRzYIiUQW7yhHjc7FCDGAPrszAv8tVV+xYpcAKK?=
 =?us-ascii?Q?Vk5KMXg37gvnd5QCw/TFdUAY680EfyAI55K78LHKhV/br3vbGG1K7SvN8QMb?=
 =?us-ascii?Q?Ko78QuC8NMw44+u3dUF0Qoczs/IHA4wWjxRXkSWrA9rq8WYG7BR0aRixJ8FC?=
 =?us-ascii?Q?olxF1JyrrsYTHYaaZ/R6Id/pf3mjjeUvyh+TXFh8Kx5fvJKG87vrERyGDIPV?=
 =?us-ascii?Q?JmYER6MTOeHpf3V9fXUVkoEJ4b/TGv5ZIdHbwXwL3OqkNmaPiJuAEmy7L74y?=
 =?us-ascii?Q?uEse063EwTUdEOSm+lWz8Rur8w3v9hVCP6YzW0w3wa/NcyLXeMUHSXRVjK4k?=
 =?us-ascii?Q?eW9ykBvHhmyw97Rab9YHEgXd1Uby67VjWLY1rkvC/9nyj0VwRQxwTv+EbEM6?=
 =?us-ascii?Q?yaEENE9qvtsE+Rb/SVthAwQqMF2/OovqtsnQ//2AiWIf7YVsFtECvkq3m+bw?=
 =?us-ascii?Q?+GeXLRJKih+Aj2HJQwyeJWPS47CeFFrP/YH7t8JpCQYzPw90cnM6okK0xdPp?=
 =?us-ascii?Q?M/jqD+d6k13c+h8h3PEv4UKE86hs1G4a9nsPr2PdiiwFqOFemCbIpUg/+XtT?=
 =?us-ascii?Q?rnkp541gL0+5w9jDI1tk9Ogf1DOHPwwjxnp3AiCaqLyNtVWCfvLgbAw3evEj?=
 =?us-ascii?Q?Sfg1tu+9YiWssjOoN79H5WZj9eYp8AMhI5sRunsUVqT9rkBEzurhD0NuP9Ni?=
 =?us-ascii?Q?6DmmP5PXv0eTDFUCBNddNFUwOe+EtHmCzQJM47YI/cQvf3buX7rttykLRGX8?=
 =?us-ascii?Q?llpCz2RhX9iPaLh1sxqjQlFD9Af6ag/W3rneVbxR5hBQ4dYtM8FpptfspGsd?=
 =?us-ascii?Q?IEEwgq4vmQiSJzREvzESrHghqvAa7DMKaLfCJxbT6C88MvPsKv8C+lrsOmb0?=
 =?us-ascii?Q?8UAZDz5eGpwb7u1dPwcX43oG4emqd5cyn2Cqf3KMB+Uq2ir/cj2O5oG+On+r?=
 =?us-ascii?Q?5CJDyMBN9Gfsi1B4A3sRaVn0qSM1Qf9HVwbZgMJBjsx4+dvLsa9cTmji/fHR?=
 =?us-ascii?Q?SKS8c8UHQBfz2do+r8zHAQtivCTBFFt+a82ld/WSKOLRLQCbGvuQ4LJ4qFOx?=
 =?us-ascii?Q?lU8n1HaK4t6fjlPsuO8qRJM8A+NSiYfNGi+xIwXVllPNmc1MgSMYYZF7LDVp?=
 =?us-ascii?Q?m2WRb8wO3ol92HPS9dud2PDVUqtGH6kD2VqAJmp1VdG7EPRkjm7QCX6le1vQ?=
 =?us-ascii?Q?hpoBMDYkbEFRfBWqwWM7eBxjkYvOMnWkwuKlpDLpkCBg6dLYCx/49mhn7Yuv?=
 =?us-ascii?Q?T8PLVWUBf9zoU2z4pdIUwbqTbV24Aps9vqoui447GMirqEnL/BuxMEG6v6Tw?=
 =?us-ascii?Q?FG0Pvt9Qe+6hin86YoV7NmWHs+pEiBhdCJ6Z/32FiY3wzWxyUOyq7w73Wrgn?=
 =?us-ascii?Q?+h03PpDre+MVP7Mh56uTdTkz1FuTkaV3Vt0NxasjjQqNMtbtpfo+tThDQtoV?=
 =?us-ascii?Q?fwuu+pFF3NqDhToKJCsilhRn3wOVa88=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3059185-b0bf-4d5b-570c-08da1297afb9
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 21:53:12.6835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fv3X4qrUPmKxHkT/7Hih/NNpXu6g0vkKKKxJOv0BSbDCVOF5NpDa44VauQMeiHsWUGvJUFNK8NIfDMRFELP7hKoUswdoTR9uNyKLoYDOxXs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2702
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10302 signatures=695566
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203300106
X-Proofpoint-ORIG-GUID: Kp-UZRmJ_nqIrzb0FcVSh-50d2uuJMlA
X-Proofpoint-GUID: Kp-UZRmJ_nqIrzb0FcVSh-50d2uuJMlA
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Print two possible reasons /sys/kernel/debug/gup_test
cannot be opened to help users of this test diagnose
failures.

Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: stable@vger.kernel.org # 5.15+
---
 tools/testing/selftests/vm/gup_test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/vm/gup_test.c b/tools/testing/selftests/vm/gup_test.c
index fe043f67798b0..c496bcefa7a0e 100644
--- a/tools/testing/selftests/vm/gup_test.c
+++ b/tools/testing/selftests/vm/gup_test.c
@@ -205,7 +205,9 @@ int main(int argc, char **argv)
 
 	gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR);
 	if (gup_fd == -1) {
-		perror("open");
+		perror("failed to open /sys/kernel/debug/gup_test");
+		printf("check if CONFIG_GUP_TEST is enabled in kernel config\n");
+		printf("check if debugfs is mounted at /sys/kernel/debug\n");
 		exit(1);
 	}
 
-- 
2.24.1