Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <38d43b49-9999-af2d-e3cd-3917c481651b@vivo.com>
Date:   Thu, 31 Mar 2022 11:03:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH linux-next] RDMA: simplify if-if to if-else
Content-Language: en-US
To:     Leon Romanovsky <leon@kernel.org>,
        Haakon Bugge <haakon.bugge@oracle.com>
Cc:     Mustafa Ismail <mustafa.ismail@intel.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Yishai Hadas <yishaih@nvidia.com>,
        OFED mailing list <linux-rdma@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "zhengkui_guo@outlook.com" <zhengkui_guo@outlook.com>
References: <20220328130900.8539-1-guozhengkui@vivo.com>
 <YkQ43f9pFnU+BnC7@unreal> <76AE36BF-01F9-420B-B7BF-A7C9F523A45C@oracle.com>
 <YkQ/092IYsQxU9bi@unreal> <93D39EC2-6C71-45D8-883A-F8DAA6ECFEDF@oracle.com>
 <YkRTidagKVgSUGld@unreal>
From:   Guo Zhengkui <guozhengkui@vivo.com>
In-Reply-To: <YkRTidagKVgSUGld@unreal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWI5MC82cTJPYXpNWk9OKytiMkwrVzY0cHZ5Z3d5Z1FaVlUrajlmQ0xhdVNW?=
 =?utf-8?B?ZHJUcnBkM1hOdi80NXduNUNyeVZVenhtOTBiZldpdyszV1dzdm9Yc05hRDhn?=
 =?utf-8?B?TkVHRzB3WGhnSzBoclA2ekJNUnB4TFVYUEZCbEE1N1RYaXF3Nis0TlhFRjFJ?=
 =?utf-8?B?Z1JCWEY1RnNrZDVLR2ZhWlQxY2piclB1NFRFT2hSdFBJUjFmVzRIYTNGV0dq?=
 =?utf-8?B?RCt1UVdKOHZmdU1ndlZSazcrekNPOGV5dENBZXJuaTh1OWlxN0kvRXRlaEhM?=
 =?utf-8?B?RlNoSDAwM3dVQUNGUXdvSUUzb3lHQTl3Vkd3U3ljcURoWnZPVWxvSUsvMzV6?=
 =?utf-8?B?Tyt2MkZyeC91aWJqNXhxSUdiV2xTaUxudVltQStqTGU1Y1lyMUFOdGJwK1B2?=
 =?utf-8?B?Tm1aeGlKMFZvb2JUUm1RbU5IZTEzeHhmNHpJL3Q2Y29QVFBmYTdLSGtCdFo4?=
 =?utf-8?B?bkMwYm5vNUtZclhVNGtkTmgwWVVNYTl6VDFXUlNscjRtak01NDI3aWJ3NGpR?=
 =?utf-8?B?anA1ak9LbFRaZi9BN3RZeW1UYTVxb1cyWFU2N2xWTGNJLzA2KzNIdnFVVXFX?=
 =?utf-8?B?aGwwbFRzZ0w4R1FYT1F1ZUVQSFN6d3owd2RkVEZ0dmFjZkx0ZHF3L094WTdS?=
 =?utf-8?B?c3ZLR1pYVUFMaXFvZW1xRDlEeDAxMFo1bUtjQlRUcGk5Ykp0emZlVW44Wm5y?=
 =?utf-8?B?UnpPSXlGb2g2c0ZodmJRSEw0VkJrQmJpYXNZaDI3L09aNjR6UWpkbzM3TThZ?=
 =?utf-8?B?UEtpQzNpWU1UWklONkorY3dQYW4zbjNPTVRqa2IzT2ZuQzhBWTJLNml4TEhI?=
 =?utf-8?B?c1VJK3NyQWxlWXJ6MHRWbk45MCtkNG12cmdaaVJrZExxT1lnT2dKc0RPZkZJ?=
 =?utf-8?B?Q0VuVzhjQU9jcVVDL1pVckI3K2V0anBZTS9EaEZ4TGdPOTdEc3h4dGtaN2Jp?=
 =?utf-8?B?aGpmdFpodzRBWVJtVWpZOERuZUt3SEJkc05PYTVtbVFpMlgyTVROOEJlbkYr?=
 =?utf-8?B?NkIwRndoQVk2djltWlZvMTlza21jTWMzQTlZTWdhOGVpbWx2ZGlSMzgwSHkr?=
 =?utf-8?B?T3laWnV5OUMvUmhiTE5ESGpTV3RCdmVYT2RpaWd6ZWllYU02L0NhdS9nOEh4?=
 =?utf-8?B?dUNNWUxWVlh1V1pvblUydkRZampKL240MXdEbUpXMUc1YW40bGJENTR1NGQ2?=
 =?utf-8?B?S1g2UnBKZ1hhTHR2Y05IdkhSQ1pFVnR4a1V4dXg0dWlPZk9nMmtocGFidVZm?=
 =?utf-8?B?emh4bDMzSHpiUXZ1anZzQXZaREkvOWE1MUlsK1Q2SlNvTS9MWmRpNG81WU16?=
 =?utf-8?B?YXpMaytKU1J6ZTRwTmpPZms0SGs3RnBFaHVYTmpPQjVoV0d5Zmw0NGlVWWxP?=
 =?utf-8?B?cXRJN2FuKzQrUUJJNm4xbFY5SEpaWXpXbi9nd2F4Y2RXQlNMYkFQaTNtYmpR?=
 =?utf-8?B?WW5zL0tqZXZTaC9FeGZMcWRGYkFGRTV6NVVjSnFwNGF1SmFUVFVzZDZoVFFQ?=
 =?utf-8?B?RWZjeTg0dkJiemkxZjIwMm5GMHYxdU9yQVpJUDlORWgvTlpkOStCbm5KTVhi?=
 =?utf-8?B?VmdraFRRR2U4OG5ZRWxKWkpUcWVzWFU0UkcycTl3ZjI2MllVUzdQVENuRVB3?=
 =?utf-8?B?MGpIQi90Zjhid0g3VjZqOHdHWnBNZzVFMVdiUWFXMXRZNzBzS1RLMmc1cCtX?=
 =?utf-8?B?Ty8yU3lEdmRFZjFndG96U3Q5dm5mK3dFWHZsQlVlLzdyc2VrZjhacmNGZmpI?=
 =?utf-8?B?RG5SVEVMc1R5bEdGK0tRTjRPTmdvbzdWTllEU0lWb290R1AwMjBrRllGOGhE?=
 =?utf-8?B?cVh5eDVYOXIxWTcxV0gwTXVCcUFzNFIxcG9RVWE0NXV2N0gwTmU2TE9SQW1k?=
 =?utf-8?B?c0toY2dOODkwdVhOVVpzcXh5OFVEcjRENGgrSGpmNkVZK0Jicjlxc1c4amR6?=
 =?utf-8?B?SklUVEIxUnQ0NDNEZ0NRa1puM2VSNUp0RmhUZG9IZnZtYzUvK2JHWDlJazBF?=
 =?utf-8?B?VjYxVlU3V3JteG1LT2pIQmkxL2JsdFNiYU9xditjM0xEVXJoVzBVUEIxT0J6?=
 =?utf-8?B?YmJoMmE5U25UYmVjOElSbFpzKzd4LzM2Sksxb0NvbEdFc1RTcDVMa1FRUFNl?=
 =?utf-8?B?c010OWdDWVpUcW52aGdjeE9mNllGdlhKYndvclQ5SDduKzBJTFBGdHBFTUhl?=
 =?utf-8?B?eWQ3Um1PWXUrbDRPT3JCVXNwL1lBV3dDNkYvei9lRWVaYjBwaHZsK2ZCaGZW?=
 =?utf-8?B?NzFBMzFVM0tuM2dxaElMdkJjVnpnRjFialhmbDk3WG9DVzFJUE9SaWZKWUIz?=
 =?utf-8?B?TnZjVDRTTi9jb2RSZ09YMHFwNGp6emxGRElNK3pYZ3hjR0p1VXVJUT09?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 331a29c1-7b5b-48ea-2478-08da12c30b5f
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 03:03:34.7553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tqg8ZJ2EMvpx+37ZOef9rl8+SzGnampjnfwLwFIJpXuRPVeMY6oCBqjPFyff9L6WZbgQb4wgjUqiHPjTEc8m2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5261
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/3/30 20:56, Leon Romanovsky wrote:
> On Wed, Mar 30, 2022 at 12:26:51PM +0000, Haakon Bugge wrote:
>>
>>
>>> On 30 Mar 2022, at 13:32, Leon Romanovsky <leon@kernel.org> wrote:
>>>
>>> On Wed, Mar 30, 2022 at 11:06:03AM +0000, Haakon Bugge wrote:
>>>>
>>>>
>>>>> On 30 Mar 2022, at 13:02, Leon Romanovsky <leon@kernel.org> wrote:
>>>>>
>>>>> On Mon, Mar 28, 2022 at 09:08:59PM +0800, Guo Zhengkui wrote:
>>>>>> `if (!ret)` can be replaced with `else` for simplification.
>>>>>>
>>>>>> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
>>>>>> ---
>>>>>> drivers/infiniband/hw/irdma/puda.c | 4 ++--
>>>>>> drivers/infiniband/hw/mlx4/mcg.c   | 3 +--
>>>>>> 2 files changed, 3 insertions(+), 4 deletions(-)
>>>>>>
>>>>>
>>>>> Thanks,
>>>>> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
>>>>
>>>> Fix the unbalanced curly brackets at the same time?
>>>
>>> I think that it is ok to have if () ... else { ... } code.
>>
>>
>> Hmm, doesn't the kernel coding style say:
>>
>> "Do not unnecessarily use braces where a single statement will do."
>>
>> [snip]
>>
>> "This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches"
> 
> ok, if it is written in documentation, let's follow it.
> 
> Thanks for pointing that out.

Should I resubmit the patch including unbalanced curly brackets fixing? 
If not, I can submit another patch to fix this problem.

> 
>>
>>
>> Thxs, Håkon
>>
>>
>>>
>>> There is one place that needs an indentation fix, in mlx4, but it is
>>> faster to fix when applying the patch instead of asking to resubmit.
>>>
>>> thanks
>>>
>>>>
>>>>
>>>> Thxs, Håkon
>>

Thanks,

Zhengkui