Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp116181pxb; Thu, 31 Mar 2022 00:45:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw18hvLLJxRVs3U9AvYbXN92s0msPcmV6iXXRTBKWAZrvZsI/2tRytVP60Xzrya/1orrcnF X-Received: by 2002:a05:6402:1718:b0:419:564:6b62 with SMTP id y24-20020a056402171800b0041905646b62mr15294493edu.361.1648712716178; Thu, 31 Mar 2022 00:45:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648712716; cv=none; d=google.com; s=arc-20160816; b=Y5iXO8NjiOk2R+kvid9f6yB/npg/U50OCsD3FpsATe/i5qpcoL+eoHA+q+KF9akO3/ zTvm0+3ra2tIwI4c1trx4QaS+DScukuoPT1DLcv/oNdkAQiEutGBWHg8KYFVLi2zBX0U 7cO9NZJzIG4Fi3On92c2atjZZW1wFuCTvGOcECqhov71cG+oBAirFJGsPCedrayQCtc+ xs87vYWlP1QZlwNp8yny1Or3/PNhx19H/z1XHuuupJKQvBzqM8EQ/BfoIeooDHl4iRsn k+uWcuNV6vsB//GBw31/r8UQdgo1PO1C80APlDvWF5bcL6gPQje/QoyKNUFqN8JfkXbX FtAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=VtSyhCBRl6DDd411G5kv1lVJwnclO4BJfyyDJEiIIQQ=; b=KC+wZVyVKXBSVxI0IrT5QIlnp8/4hjXb+9sAGSnomIKCEQ77yXInRRYddgUFst02O1 To1EUgt8qN8TaCwlxwz1MpKfH0Y1Y5DvFnWeHOxM9ZXBes+ZSa8W6nUJWN8uIkDWWFeA 4JVfAeAMVhEApJerJ1EZio5mcB0BMqJpuVyp9jYCfBssp3eAd76kBQ5zhah5Lu5Jxptc gtbx4ImYsbWE0rA979r+f9ao9hvsngNCqrUb6mwgQ4vXHR3o6o/wr5mesi51pDx59edD BZ84ft8wRSVk+ohVTjSz8XLglnTzuoF/GQ6rtBYStmZ5aBafZvese7gd8nH5yz3Ydbfr 3FBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=r44vCvmN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gg8-20020a170906898800b006df76385d41si20703554ejc.481.2022.03.31.00.44.50; Thu, 31 Mar 2022 00:45:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=r44vCvmN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231840AbiCaHMm (ORCPT + 99 others); Thu, 31 Mar 2022 03:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231757AbiCaHMW (ORCPT ); Thu, 31 Mar 2022 03:12:22 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC2F65B3D0 for ; Thu, 31 Mar 2022 00:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VtSyhCBRl6DDd411G5kv1lVJwnclO4BJfyyDJEiIIQQ=; b=r44vCvmN1Q4mZOvdEid41+bbQ5 VKde0jyZ1PAJJAX0DQvXUNXjYSbMR1O5y/GpPW12E/zBP4Ou/3pxCBLCxNGgEagFfeZZKdrYbAvAK ElofHY/yYSPxonnlV2KM5fTIjQ2+rvQoVtrymkk0xUq8gX6TW5utiHtovTWK4jzin952Psuu6hRKh 7XhKlR1bR4UQ5Y74um1Q+1n2mTwtQr6cdP50g3hD7RHVsQB3J8jJfAIuBGcTtClXl+iNWZrfzScZ3 YN52iT+ZbYPjxUAHzZiKDZToAUJtGC+XPCl/vloKT8jPTEFjb5Tt+uPvmme/N9OFiiVv4KXbl6ahh 1wgxDnqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58038) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nZowt-0004L7-2C; Thu, 31 Mar 2022 08:10:26 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nZowp-0007QG-Sx; Thu, 31 Mar 2022 08:10:23 +0100 Date: Thu, 31 Mar 2022 08:10:23 +0100 From: "Russell King (Oracle)" To: Austin Kim Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, austin.kim@lge.com, p4ranlee@gmail.com Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel=' Message-ID: References: <20220330110715.GA1534@raspberrypi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330110715.GA1534@raspberrypi> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote: > From: Austin Kim > > Add invalid value check expression when no crashkernel= or invalid value > specified using kdump. Hi, I think you mean when "crashkernel=0" is specified, as other invalid input should result in -EINVAL being returned. Please update the patch description and comment. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!