Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 11:22:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     David Kershner <david.kershner@unisys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: unisys: Remove "struct dentry
 *eth_debugfs_dir"
Message-ID: <20220331082202.GZ12805@kadam>
References: <20220331064751.29634-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220331064751.29634-1-fmdefrancesco@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A7rHk4U+Lr+ARkfl4nu2wbDiNv2l6V8/LtZ5EvJG/en1PXIcY3L9a8mGKV4G?=
 =?us-ascii?Q?rhgwAPa5ZQIC0Ih9tOMrtq3TK2fh/aI3Fc8Z5CtQTVw8I2sPnJGFJsIdk4MD?=
 =?us-ascii?Q?DAkofmqFcmA9SG/cjokJzMwS2YSgc/AVKcYdOEl+kj4Qrs61VnNST0cf+WlB?=
 =?us-ascii?Q?PoWCKszVm0SE9N7q5I1OjjowBapggpiH1XOpGsF28hI/g6imnRjSYT7+9WxH?=
 =?us-ascii?Q?EIicciV/DIZYFxe5SBC/kiU9LE3yGwFgzSf9Z3dTY0wQgNP1JDi91pbfPSAh?=
 =?us-ascii?Q?OYnXEh4CiGwpre1J+7GTyE8JQRk/v9qBGPs0w/+pWmMh1bui132nAvDJIpXf?=
 =?us-ascii?Q?d1L4PJ29BCdAAbTNCt8QAdJSaV2GDlHCxgR2kF4YOJsh1Io/2SaQKg1yBlr5?=
 =?us-ascii?Q?zUZW+hn/5bZTQGtWjzsvf+7RYDxC8g08vDGCzDSv/rdGc4WCDjkUnL8ch8Vt?=
 =?us-ascii?Q?qM24z7/wXwT+aC4qyjmyS8WWGoavClsvoOtJ6PpNLTPZyJuzBiK7Maxc3PPI?=
 =?us-ascii?Q?0Z2IJ56cJtTg5agoPBFDZY1hdkIuQ2qSc1O2MBBkXaxooctJVIh59s50u/Wj?=
 =?us-ascii?Q?Y6Nm7o+w+Z4uVuer+oFH1eMqj2UIFBYZduWqqXzz9CTbqxL/SxCKSvITlRuo?=
 =?us-ascii?Q?VDUmlg/vBQ4bliuQ/hnVTFp5RxcoZPHNQiFi945GmyZNFiXAJ62vDEWrUj+j?=
 =?us-ascii?Q?MO8Gktc8JbEiOhYAU1UinsuSJdNEifdzhZCGd7xL3/xtN1LO+1MJ88LdIhDP?=
 =?us-ascii?Q?sawzZt2XGtudlS57SES1nBd6dZ76YKbc2li+a+y+till3f5u8LNvyJ2L1Xov?=
 =?us-ascii?Q?xo/+E9SpZx0WfyzdwgxNzPQlB/KQdOqXDrKUL8EFPgUIr9m6BY6Z1GvEwRdH?=
 =?us-ascii?Q?SU0vXfxc21FUqA6/VMqqgOCbgID2WeGEx9r+773xUsR8NWaEdAWNiLWX71Hw?=
 =?us-ascii?Q?89lJKC+Tzund9gKIkFElKmqBKM3jDvmqe2f9K6gYsKnMngR8k8NmHszZUmMX?=
 =?us-ascii?Q?jWk+E5Yt0YhiC/NeB039Ym9u7tJfnFoVPidHSJjV7/r2YQyRyXLWGihZSC+2?=
 =?us-ascii?Q?RBvKwrjc54dTORv6ZoWYkXTc9oxAKzEf/GPYK6gEhIOZfVDYveFxsm9SWPC4?=
 =?us-ascii?Q?Tf4CpKFKfmLC4ibT7q1TVOfrDnmjB4KtrPQDVwCVICemwbFw2aF6FTEI2aIg?=
 =?us-ascii?Q?suqu/os72A5ql6d7IrFiPNGD3Ixpio9jUOjyf4Vy5by28iZH8/8zfDzTss1i?=
 =?us-ascii?Q?9ShIIkSvgbYgdOxksMmqmpFp0Ahd2IyjrGoevNFOCKZmrbvtPcFPfh8Ee0OT?=
 =?us-ascii?Q?1yNQ8EE/pk1QwS+1I1ZoX5pvhsHD9Q25z9bwAMj/JSkgaxZprjAuncsH9ZtD?=
 =?us-ascii?Q?oMklkn33XVw7Cs8pYNyFNFh0T0LlBK6h8j6ItwNBqENxPis2YQ4frI1cjyrF?=
 =?us-ascii?Q?7IZENVKwfDlUm3+Qq+kl4Vv0Sj2yJZ8v0VPb01K064W7j6DQmIlWboRbGSbw?=
 =?us-ascii?Q?FYnDWDcfyv8dOpYOYF7YwoMxyGf0+m/5gf1DgjoM0WAQcA67UhkRjpvUJ15p?=
 =?us-ascii?Q?OoCkRPYUzI0+5YBfli6JxFFdO3fBTFzgUjljhe7rFVutox+t15Dn5sAwTKEo?=
 =?us-ascii?Q?6I2C/4WsTp42tziQEdY7F0SIt4ywek25yqoX2DHLxvAZCwlLce26fN9zGH8o?=
 =?us-ascii?Q?pdmgTYxm/W+ADU/eig1CItiZB4a+2xPpZ/+ZqEZHfPXlEA+3UlFSqs3J4+Si?=
 =?us-ascii?Q?D5I/XVpKECBQPnfcxsMwPBml/p86V90=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dca9d4f5-4c72-4188-ee55-08da12ef8fbd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 08:22:14.6762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JU8xJm21a6xc1pbNIHdKnIYyt+2PPOoznYkiZycEQtkas9L9Nye8wWSY/GMSauUhu2TbCTyXnQq2uf4hbyO2p17s5tJ/ddU3qni2sp7+trs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5474
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-03-31_03:2022-03-29,2022-03-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=805
 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203310045
X-Proofpoint-GUID: UxkyHAjZaNkyEOwzQ5z-FQupR_w6HRYd
X-Proofpoint-ORIG-GUID: UxkyHAjZaNkyEOwzQ5z-FQupR_w6HRYd
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 31, 2022 at 08:47:51AM +0200, Fabio M. De Francesco wrote:
> There is no need for "struct dentry *eth_debugfs_dir" which is used for
> debug / sysfs directories. Therefore, remove this "struct dentry" and
> everything related (i.e., creation and removal).
> 
> As a side effect of this change, the code has no more need of the
> "cleanup_register_netdev" label, which can also be removed.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> 
> v1 - v2: Add a couple of "Suggested-by" tags which were forgotten. 
> Thanks to Dan Carpenter and Greg Kroah-Hartman.
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter