Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp258944pxb; Thu, 31 Mar 2022 04:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2uKvnFA8xBgLyH3loO7A1THCpZ1UzTTvRXziAr0G1+wsmW3B5uQfzdAz0rgwM58DgWbOf X-Received: by 2002:a17:902:c784:b0:156:15b:a739 with SMTP id w4-20020a170902c78400b00156015ba739mr4739831pla.146.1648727895649; Thu, 31 Mar 2022 04:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648727895; cv=none; d=google.com; s=arc-20160816; b=AV1xpjifz4vCxV9mKWY27ld4Syi5hN5wxnEFDr1t2GbSmOWJqSyr3sn/AHC3pa2aBe vQAisZKU+iCsPTmkYr6E0Nl5DQGsRDa4ogh8VAcCApjEVUpULFRHgARE2HT44oa92oLr W6Y5GQtmmmG/nPM8bclXeHwl9C0a5XO5lOp0OrauwzB2xMJZBWH3iJImfIsCEJ2XrWpn vSe3stKDsuWQZfupWNWDTxtWfsIoJobViN9XqeFqIBA7xoDqHml5yTh2oN0Pi3WmjCOY D8O1cPYJgjES/Koz0qSk8QX93TTxbwL2pOX1hjtwx6Mp1x6GR0SodbT28TLlxZjci1f5 dEWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XOT0k1ybQELd4rlEFW+WQOkEbWaImDp7J4ZPXs2esew=; b=dD85L3M4+TqTGEUdEad1+MtK+VhuSjPdt52UajBgWnmbL64jYtvkfILxHJfkZ4m4nG jZCgm1aa2Mh+dJkBY7Xmo+hFIiGyp9sOfWsavrblpYkfqwIiaV2JPFqICeifnYoW4M/J 0xKvmxrtTnYTZIyT2nq+AUespqQZn47Am7dQf9tD1HBYXylvJH5Eyd54tsSJcuQiwTCW yevHGcSPSPjxnQJOd6UWaGNoRo4mIEKWQiBjfBPgpofXIbu3Wcy8LuG1VOaQXTdyxiFE N0nawhLX3kgTC7HPc2xMy+/8jxIbzlaBaefihNsrVVKF76S3Y6YrBSqv8D6YgTvuh8Oh y2jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=e66tOk8W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d192-20020a6368c9000000b00398700c9d98si10876909pgc.98.2022.03.31.04.58.03; Thu, 31 Mar 2022 04:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=e66tOk8W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233998AbiCaJaV (ORCPT + 99 others); Thu, 31 Mar 2022 05:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234003AbiCaJ3Z (ORCPT ); Thu, 31 Mar 2022 05:29:25 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE3E91FF422; Thu, 31 Mar 2022 02:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648718846; x=1680254846; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mPcmSRFysKdQJULNHMdsCcsem8XlXgWIUxePX6FqmbU=; b=e66tOk8W/E0fWH/7ffuke1+vLmGKS753EjTf+Sd7H3LTwjwjfFeP1Sdk YPpDOxKDp9J3lm6ztf4Y2sZyok/q7i/5Mh27rz2dDbeibrWRSnxJfQEnQ ybUq5UXSGsve3t1spi7ROQJmFLUpMPUMzAuvl24/6xG++3wUVwdB+YMe1 o8kjdbK31UAN0JFkzz13QVzhs/Bxi6pFzGr4V0qK0PCixxICLJo+ws0CT qlKHibwceo1P53bs2hMoY0KKXPvuv/t6+fbjXs2aBnr2mY68zRo7LwQoE HfRxHo6Wozc1ANd14UWLSntZEK+tRDYBWSNoFmKFBhhrQyxlS+tlgxhvo w==; X-IronPort-AV: E=McAfee;i="6200,9189,10302"; a="239705897" X-IronPort-AV: E=Sophos;i="5.90,224,1643702400"; d="scan'208";a="239705897" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 02:27:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,224,1643702400"; d="scan'208";a="695423344" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 31 Mar 2022 02:27:23 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 31 Mar 2022 12:27:23 +0300 Date: Thu, 31 Mar 2022 12:27:23 +0300 From: Heikki Krogerus To: Won Chung Cc: Tomas Winkler , Mika Westerberg , Benson Leung , Prashant Malani , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] misc/mei: Add NULL check to component match callback functions Message-ID: References: <20220331084918.2592699-1-wonchung@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331084918.2592699-1-wonchung@google.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Won, On Thu, Mar 31, 2022 at 08:49:18AM +0000, Won Chung wrote: > Component match callback functions need to check if expected data is > passed to them. Without this check, it can cause a NULL pointer > dereference when another driver registers a component before i915 > drivers have their component master fully bind. > > Fixes: 1e8d19d9b0dfc ("mei: hdcp: bind only with i915 on the same PCH") > Fixes: c2004ce99ed73 ("mei: pxp: export pavp client to me client bus") > Suggested-by: Heikki Krogerus > Suggested-by: Mika Westerberg > Signed-off-by: Won Chung > Cc: stable@vger.kernel.org > --- > Changes from v2: > - Correctly add "Suggested-by" tag > - Add "Cc: stable@vger.kernel.org" > > Changes from v1: > - Add "Fixes" tag > - Send to stable@vger.kernel.org You are sending these really fast. Before you send the next one, please wait for at least one day. thanks, -- heikki