Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 31 Mar 2022 13:32:07 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Nas Chung <nas.chung@chipsnmedia.com>
Cc:     "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
        "kernel@collabora.com" <kernel@collabora.com>,
        "dafna3@gmail.com" <dafna3@gmail.com>,
        "bob.beckett@collabora.com" <bob.beckett@collabora.com>,
        "kiril.bicevski@collabora.com" <kiril.bicevski@collabora.com>,
        "lafley.kim" <lafley.kim@chipsnmedia.com>,
        Scott Woo <scott.woo@chipsnmedia.com>,
        "olivier.crete@collabora.com" <olivier.crete@collabora.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "daniel@0x0f.com" <daniel@0x0f.com>
Subject: Re: [PATCH v6 4/6] staging: media: wave5: Add TODO file
Message-ID: <YkWRN4ac0ivRn4aB@kroah.com>
References: <SL2P216MB12463DE2E1E100E2498A5C33FBE19@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
 <SL2P216MB1246D7900A0B9620F1E1A038FBE19@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SL2P216MB1246D7900A0B9620F1E1A038FBE19@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
Precedence: bulk

On Thu, Mar 31, 2022 at 09:55:10AM +0000, Nas Chung wrote:
> From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> 
> Add a TODO file listing all that is need for destaging.
> 
> Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
>  drivers/staging/media/wave5/TODO | 64 ++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 drivers/staging/media/wave5/TODO
> 
> diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO
> new file mode 100644
> index 000000000000..425ed42a234c
> --- /dev/null
> +++ b/drivers/staging/media/wave5/TODO
> @@ -0,0 +1,64 @@
> +* Test on real silicon once available
> +
> +  This driver has so far been tested on pre-silicon FPGA and on the beta BeagleV
> +  board which uses the StarFive JH7100 beta SoC.
> +
> +  Testing on FPGA shows it working fine, though the FPGA uses polled interrupts
> +  and copied buffers between the host and it's on board RAM.
> +
> +  Testing on BeagleV shows buffer corruption that is currently attributed to a
> +  known silicon issue in the SoC that makes the cache coherent interconnect not
> +  so coherent.
> +  This can likely be solved when the riscv non-coherent dma support lands and
> +  provide optional v4l2 non-contiguous allocator, though it remains to be seen
> +  whether support non-coherent use cases will be useful in real world hw.
> +
> +  Until we can test and resolve any issues on final silicon (due 2H 2021)
> +  this driver should remain in staging.

Then why not just wait?  Why merge this now?  What is the benifit of us
taking this code at this point in time for hardware that is no one has
as it is not even created?

thanks,

greg k-h