Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eelco Chaudron <echaudro@redhat.com>
To:     =?utf-8?q?St=C3=A9phane?= Graber <stgraber@ubuntu.com>
Cc:     netdev@vger.kernel.org, Pravin B Shelar <pshelar@ovn.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, dev@openvswitch.org,
        linux-kernel@vger.kernel.org,
        Frode Nordahl <frode.nordahl@canonical.com>
Subject: Re: [PATCH] openvswitch: Add recirc_id to recirc warning
Date:   Thu, 31 Mar 2022 10:28:13 +0200
Message-ID: <1D0EA638-3067-4F74-8E94-3D766D262B39@redhat.com>
In-Reply-To: <20220330194244.3476544-1-stgraber@ubuntu.com>
References: <20220330194244.3476544-1-stgraber@ubuntu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 30 Mar 2022, at 21:42, St=C3=A9phane Graber wrote:

> When hitting the recirculation limit, the kernel would currently log
> something like this:
>
> [   58.586597] openvswitch: ovs-system: deferred action limit reached, =
drop recirc action
>
> Which isn't all that useful to debug as we only have the interface name=

> to go on but can't track it down to a specific flow.
>
> With this change, we now instead get:
>
> [   58.586597] openvswitch: ovs-system: deferred action limit reached, =
drop recirc action (recirc_id=3D0x9e)
>
> Which can now be correlated with the flow entries from OVS.
>
> Suggested-by: Frode Nordahl <frode.nordahl@canonical.com>
> Signed-off-by: St=C3=A9phane Graber <stgraber@ubuntu.com>
> Tested-by: Stephane Graber <stgraber@ubuntu.com>
> ---

This change looks good to me, and it makes debugging easier.

Acked-by: Eelco Chaudron <echaudro@redhat.com>

>  net/openvswitch/actions.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> index 780d9e2246f3..7056cb1b8ba0 100644
> --- a/net/openvswitch/actions.c
> +++ b/net/openvswitch/actions.c
> @@ -1539,8 +1539,8 @@ static int clone_execute(struct datapath *dp, str=
uct sk_buff *skb,
>  				pr_warn("%s: deferred action limit reached, drop sample action\n",=

>  					ovs_dp_name(dp));
>  			} else {  /* Recirc action */
> -				pr_warn("%s: deferred action limit reached, drop recirc action\n",=

> -					ovs_dp_name(dp));
> +				pr_warn("%s: deferred action limit reached, drop recirc action (re=
circ_id=3D%#x)\n",
> +					ovs_dp_name(dp), recirc_id);
>  			}
>  		}
>  	}
> -- =

> 2.34.1